Skip to content

Commit 9df06c9

Browse files
committed
Update SideBySide tests to Connector/NET 8.0.18.
This version changes the .NET data type of "YEAR" to Int16.
1 parent 3c1ab41 commit 9df06c9

File tree

2 files changed

+15
-4
lines changed

2 files changed

+15
-4
lines changed

tests/SideBySide/DataTypes.cs

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -775,11 +775,14 @@ public void QueryTime(string column, string dataTypeName, object[] expected)
775775
[InlineData("`Year`", "YEAR", new object[] { null, 1901, 2155, 0, 2016 })]
776776
public void QueryYear(string column, string dataTypeName, object[] expected)
777777
{
778+
Func<MySqlDataReader, object> getValue = reader => reader.GetInt32(0);
778779
#if BASELINE
779-
// mysql-connector-net incorrectly returns "INT" for "YEAR"
780-
dataTypeName = "INT";
780+
// Connector/NET incorrectly returns "SMALLINT" for "YEAR", and returns all YEAR values as short values
781+
dataTypeName = "SMALLINT";
782+
expected = expected.Select(x => x is null ? null : (object) (short) (int) x).ToArray();
783+
getValue = reader => reader.GetInt16(0);
781784
#endif
782-
DoQuery("times", column, dataTypeName, expected, reader => reader.GetInt32(0));
785+
DoQuery("times", column, dataTypeName, expected, getValue);
783786
}
784787

785788
[Theory]
@@ -1062,7 +1065,11 @@ private static object CreateGeometry(byte[] data)
10621065
[InlineData("DateTime", "datatypes_times", MySqlDbType.DateTime, 26, typeof(DateTime), "N", 0, 6)]
10631066
[InlineData("Timestamp", "datatypes_times", MySqlDbType.Timestamp, 26, typeof(DateTime), "N", 0, 6)]
10641067
[InlineData("Time", "datatypes_times", MySqlDbType.Time, 17, typeof(TimeSpan), "N", 0, 6)]
1068+
#if BASELINE
1069+
[InlineData("Year", "datatypes_times", MySqlDbType.Year, 4, typeof(short), "N", 0, 0)]
1070+
#else
10651071
[InlineData("Year", "datatypes_times", MySqlDbType.Year, 4, typeof(int), "N", 0, 0)]
1072+
#endif
10661073
[InlineData("Geometry", "datatypes_geometry", MySqlDbType.Geometry, int.MaxValue, typeof(byte[]), "LN", 0, 0)]
10671074
public void GetSchemaTable(string column, string table, MySqlDbType mySqlDbType, int columnSize, Type dataType, string flags, int precision, int scale) =>
10681075
DoGetSchemaTable(column, table, mySqlDbType, columnSize, dataType, flags, precision, scale);
@@ -1318,7 +1325,11 @@ public void GetColumnSchema(string column, string table, MySqlDbType mySqlDbType
13181325
[InlineData("DateTime", "datatypes_times", MySqlDbType.DateTime, "DATETIME", typeof(DateTime), 2, null)]
13191326
[InlineData("Timestamp", "datatypes_times", MySqlDbType.Timestamp, "TIMESTAMP", typeof(DateTime), 2, null)]
13201327
[InlineData("Time", "datatypes_times", MySqlDbType.Time, "TIME", typeof(TimeSpan), 2, null)]
1328+
#if BASELINE
1329+
[InlineData("Year", "datatypes_times", MySqlDbType.Year, "YEAR", typeof(short), 2, (short) 1901)]
1330+
#else
13211331
[InlineData("Year", "datatypes_times", MySqlDbType.Year, "YEAR", typeof(int), 2, 1901)]
1332+
#endif
13221333
#if !BASELINE
13231334
[InlineData("value", "datatypes_json_core", MySqlDbType.JSON, "JSON", typeof(string), 4, "[]")]
13241335
[InlineData("Geometry", "datatypes_geometry", MySqlDbType.Geometry, "GEOMETRY", typeof(byte[]), 2, null)]

tests/SideBySide/SideBySide.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
</ItemGroup>
4343

4444
<ItemGroup Condition=" '$(Configuration)' == 'Baseline' ">
45-
<PackageReference Include="MySql.Data" Version="8.0.16" />
45+
<PackageReference Include="MySql.Data" Version="8.0.18" />
4646
</ItemGroup>
4747

4848
<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp1.1.2' ">

0 commit comments

Comments
 (0)