Support ReadOnlyMemory<byte> as MySqlParameter.Value. Fixes #624

Author: bgrainger

src/MySqlConnector/MySql.Data.MySqlClient/MySqlParameter.cs

@@ -254,11 +254,13 @@ internal void AppendSqlString(ByteBufferWriter writer, StatementPreparerOptions
 			{
 				writer.WriteString(ulongValue);
 			}
-			else if (Value is byte[] byteArrayValue)
+			else if (Value is byte[] || Value is ReadOnlyMemory<byte>)
 			{
+				var memoryValue = Value is byte[] byteArrayValue ? byteArrayValue.AsSpan() : ((ReadOnlyMemory<byte>) Value).Span;
+
 				// determine the number of bytes to be written
-				var length = byteArrayValue.Length + s_binaryBytes.Length + 1;
-				foreach (var by in byteArrayValue)
+				var length = memoryValue.Length + s_binaryBytes.Length + 1;
+				foreach (var by in memoryValue)
 				{
 					if (by == 0x27 || by == 0x5C)
 						length++;
@@ -267,7 +269,7 @@ internal void AppendSqlString(ByteBufferWriter writer, StatementPreparerOptions
 				var span = writer.GetSpan(length);
 				s_binaryBytes.CopyTo(span);
 				var index = s_binaryBytes.Length;
-				foreach (var by in byteArrayValue)
+				foreach (var by in memoryValue)
 				{
 					if (by == 0x27 || by == 0x5C)
 						span[index++] = 0x5C;

tests/SideBySide/InsertTests.cs

@@ -391,6 +391,30 @@ value set('one', 'two', 'four', 'eight') null
 			Assert.Equal(new[] { "one", "one,two", "one,four", "one,two,four" }, m_database.Connection.Query<string>(@"select value from insert_mysql_set where find_in_set('one', value) order by rowid"));
 		}
 
+
+#if !BASELINE
+		[Fact]
+		public void InsertReadOnlyMemory()
+		{
+			using (var connection = new MySqlConnection(AppConfig.ConnectionString))
+			{
+				connection.Open();
+				connection.Execute(@"drop table if exists insert_mysql_blob;
+create table insert_mysql_blob(
+	rowid integer not null primary key auto_increment,
+	value mediumblob null
+);");
+
+				using (var cmd = new MySqlCommand("insert into insert_mysql_blob(value) values(@data);", connection))
+				{
+					cmd.Parameters.AddWithValue("@data", new ReadOnlyMemory<byte>(new byte[] { 0, 1, 2, 3, 4, 5, 6, 7, 8 }, 1, 6));
+					cmd.ExecuteNonQuery();
+				}
+				Assert.Equal(new byte[] { 1, 2, 3, 4, 5, 6 }, connection.Query<byte[]>(@"select value from insert_mysql_blob;").Single());
+			}
+		}
+#endif
+
 		readonly DatabaseFixture m_database;
 	}
 }