Support DbProviderFactories.RegisterFactory. Fixes #526

Author: bgrainger

docs/content/overview/dbproviderfactories.md

@@ -0,0 +1,35 @@
+---
+lastmod: 2019-03-06
+date: 2019-03-06
+menu:
+  main:
+    parent: getting started
+title: DbProviderFactories
+weight: 15
+---
+
+Using DbProviderFactories
+==========
+
+MySqlConnector can be registered with `DbProviderFactories` and obtained via `DbProviderFactories.GetFactory(MySqlClientFactory.InvariantName)`, or by
+using the methods [described here](https://docs.microsoft.com/en-us/dotnet/framework/data/adonet/obtaining-a-dbproviderfactory).
+
+## .NET Framework
+
+For .NET Framework applications, add the following section to your `app.config` or `web.config`:
+
+```xml
+<system.data>
+  <DbProviderFactories>
+     <add name="MySqlConnector"
+        invariant="MySqlConnector"
+        description="Async MySQL ADO.NET Connector"
+        type="MySql.Data.MySqlClient.MySqlClientFactory, MySqlConnector, Culture=neutral, PublicKeyToken=d33d3e53aa5f8c92" />
+  </DbProviderFactories>
+</system.data>
+```
+
+## .NET Core
+
+For .NET Core 2.1 or later, call `MySqlClientFactory.Register()` during application startup. This will register MySqlConnector's
+`DbProviderFactory` implementation in the central `DbProviderFactories` registry.

src/MySqlConnector/MySql.Data.MySqlClient/MySqlClientFactory.cs

@@ -5,6 +5,7 @@ namespace MySql.Data.MySqlClient
 	public sealed class MySqlClientFactory : DbProviderFactory
 	{
 		public static readonly MySqlClientFactory Instance = new MySqlClientFactory();
+		public static readonly string InvariantName = "MySqlConnector";
 
 		public override DbCommand CreateCommand() => new MySqlCommand();
 		public override DbConnection CreateConnection() => new MySqlConnection();
@@ -16,6 +17,10 @@ public sealed class MySqlClientFactory : DbProviderFactory
 		public override DbDataAdapter CreateDataAdapter() => new MySqlDataAdapter();
 #endif
 
+#if !NETSTANDARD1_3 && !NETSTANDARD2_0 && !NET45 && !NET461 && !NET471
+		public static void Register() => DbProviderFactories.RegisterFactory(InvariantName, Instance);
+#endif
+
 		private MySqlClientFactory()
 		{
 		}

tests/SideBySide/ClientFactoryTests.cs

@@ -43,5 +43,30 @@ public void CreateDataAdapter()
 			Assert.IsType<MySqlDataAdapter>(MySqlClientFactory.Instance.CreateDataAdapter());
 		}
 #endif
+
+#if !NETCOREAPP1_1_2 && !NETCOREAPP2_0
+		[Fact]
+		public void DbProviderFactories()
+		{
+#if NETCOREAPP2_1
+			MySqlClientFactory.Register();
+#endif
+#if BASELINE
+			var providerInvariantName = "MySql.Data.MySqlClient";
+#else
+			var providerInvariantName = MySqlClientFactory.InvariantName;
+#endif
+			var factory = System.Data.Common.DbProviderFactories.GetFactory(providerInvariantName);
+			Assert.NotNull(factory);
+			Assert.Same(MySqlClientFactory.Instance, factory);
+
+			using (var connection = new MySqlConnection())
+			{
+				factory = System.Data.Common.DbProviderFactories.GetFactory(connection);
+				Assert.NotNull(factory);
+				Assert.Same(MySqlClientFactory.Instance, factory);
+			}
+		}
+#endif
 	}
 }

tests/SideBySide/app.config

@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<configuration>
+  <system.data>
+    <DbProviderFactories>
+      <add name="MySqlConnector" invariant="MySqlConnector" description="Async MySQL ADO.NET Connector" type="MySql.Data.MySqlClient.MySqlClientFactory, MySqlConnector, Culture=neutral, PublicKeyToken=d33d3e53aa5f8c92" />
+      <add name="MySQL Data Provider" invariant="MySql.Data.MySqlClient" description=".Net Framework Data Provider for MySQL" type="MySql.Data.MySqlClient.MySqlClientFactory, MySql.Data, Version=8.0.10.0, Culture=neutral, PublicKeyToken=c5687fc88969c44d" />
+    </DbProviderFactories>
+  </system.data>
+</configuration>