Skip to content

Commit bbecf03

Browse files
committed
Remove MySqlSslMode.Preferred.
This enum value has been deleted in MySql.Data 8.0.11.
1 parent 1bb5950 commit bbecf03

File tree

3 files changed

+16
-4
lines changed

3 files changed

+16
-4
lines changed

tests/MySqlConnector.Tests/MySqlConnectionStringBuilderTests.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,11 @@ public void Defaults()
5151
#if !BASELINE
5252
Assert.Null(csb.ServerRsaPublicKeyFile);
5353
#endif
54+
#if !BASELINE
5455
Assert.Equal(MySqlSslMode.Preferred, csb.SslMode);
56+
#else
57+
Assert.Equal(MySqlSslMode.Required, csb.SslMode);
58+
#endif
5559
Assert.True(csb.TreatTinyAsBoolean);
5660
Assert.False(csb.UseCompression);
5761
Assert.Equal("", csb.UserID);

tests/SideBySide/SslTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ public SslTests(DatabaseFixture database)
1313
m_database = database;
1414
}
1515

16+
#if !BASELINE
1617
[SkippableFact(ConfigSettings.RequiresSsl)]
1718
public async Task ConnectSslPreferred()
1819
{
@@ -25,18 +26,17 @@ public async Task ConnectSslPreferred()
2526
using (var cmd = connection.CreateCommand())
2627
{
2728
await connection.OpenAsync();
28-
#if !BASELINE
2929
Assert.True(connection.SslIsEncrypted);
3030
Assert.True(connection.SslIsSigned);
3131
Assert.True(connection.SslIsAuthenticated);
3232
Assert.False(connection.SslIsMutuallyAuthenticated);
33-
#endif
3433
cmd.CommandText = "SHOW SESSION STATUS LIKE 'Ssl_version'";
3534
var sslVersion = (string)await cmd.ExecuteScalarAsync();
3635
Assert.False(string.IsNullOrWhiteSpace(sslVersion));
3736
}
3837
}
3938
}
39+
#endif
4040

4141
[SkippableTheory(ConfigSettings.RequiresSsl | ConfigSettings.KnownClientCertificate)]
4242
[InlineData("ssl-client.pfx", null, null)]

tests/SideBySide/TestUtilities.cs

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,19 @@ public static string GetSkipReason(ServerFeatures serverFeatures, ConfigSettings
4141
return null;
4242

4343
var csb = AppConfig.CreateConnectionStringBuilder();
44-
if (configSettings.HasFlag(ConfigSettings.RequiresSsl) && (csb.SslMode == MySqlSslMode.None || csb.SslMode == MySqlSslMode.Preferred))
44+
if (configSettings.HasFlag(ConfigSettings.RequiresSsl) && (csb.SslMode == MySqlSslMode.None
45+
#if !BASELINE
46+
|| csb.SslMode == MySqlSslMode.Preferred
47+
#endif
48+
))
4549
return "Requires SslMode=Required or higher in connection string";
4650

4751
if (configSettings.HasFlag(ConfigSettings.TrustedHost) &&
48-
(csb.SslMode == MySqlSslMode.None || csb.SslMode == MySqlSslMode.Preferred || csb.SslMode == MySqlSslMode.Required))
52+
(csb.SslMode == MySqlSslMode.None ||
53+
#if !BASELINE
54+
csb.SslMode == MySqlSslMode.Preferred ||
55+
#endif
56+
csb.SslMode == MySqlSslMode.Required))
4957
{
5058
return "Requires SslMode=VerifyCA or higher in connection string";
5159
}

0 commit comments

Comments
 (0)