Clean up broken AI code.

Signed-off-by: Bradley Grainger <[email protected]>

Author: bgrainger

src/MySqlConnector/Core/TypeMapper.cs

@@ -56,7 +56,7 @@ private TypeMapper()
 		AddColumnTypeMetadata(new("FLOAT", typeFloat, MySqlDbType.Float));
 
 		 // vector
-		var typeFloatArray = AddDbTypeMapping(new(typeof(float[]), [DbType.Object], convert: static o => (float[])o));
+		var typeFloatArray = AddDbTypeMapping(new(typeof(float[]), [DbType.Object]));
 		AddColumnTypeMetadata(new("VECTOR", typeFloatArray, MySqlDbType.Vector, binary: true, simpleDataTypeName: "VECTOR", createFormat: "VECTOR({0})"));
 
 		// string

src/MySqlConnector/MySqlDataReader.cs

@@ -428,14 +428,6 @@ public override T GetFieldValue<T>(int ordinal)
 			return (T) (object) GetDateOnly(ordinal);
 		if (typeof(T) == typeof(TimeOnly))
 			return (T) (object) GetTimeOnly(ordinal);
-		if (typeof(T) == typeof(ReadOnlySpan<float>))
-		{
-			var value = GetValue(ordinal);
-			if (value is float[] floatArray)
-			{
-				return (T) (object) new ReadOnlySpan<float>(floatArray);
-			}
-		}
 #endif
 
 		return base.GetFieldValue<T>(ordinal);

src/MySqlConnector/MySqlParameter.cs

@@ -3,6 +3,7 @@
 using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
 using System.Numerics;
+using System.Runtime.InteropServices;
 using System.Text;
 #if NET8_0_OR_GREATER
 using System.Text.Unicode;
@@ -282,7 +283,7 @@ internal void AppendSqlString(ByteBufferWriter writer, StatementPreparerOptions
 		{
 			writer.WriteString(ulongValue);
 		}
-		else if (Value is byte[] or ReadOnlyMemory<byte> or Memory<byte> or ArraySegment<byte> or MySqlGeometry or MemoryStream)
+		else if (Value is byte[] or ReadOnlyMemory<byte> or Memory<byte> or ArraySegment<byte> or MySqlGeometry or MemoryStream or float[])
 		{
 			var inputSpan = Value switch
 			{
@@ -291,6 +292,7 @@ internal void AppendSqlString(ByteBufferWriter writer, StatementPreparerOptions
 				Memory<byte> memory => memory.Span,
 				MySqlGeometry geometry => geometry.ValueSpan,
 				MemoryStream memoryStream => memoryStream.TryGetBuffer(out var streamBuffer) ? streamBuffer.AsSpan() : memoryStream.ToArray().AsSpan(),
+				float[] floatArray => MemoryMarshal.AsBytes(floatArray.AsSpan()),
 				_ => ((ReadOnlyMemory<byte>) Value).Span,
 			};
 
@@ -554,17 +556,6 @@ internal void AppendSqlString(ByteBufferWriter writer, StatementPreparerOptions
 		{
 			writer.WriteString((ulong) Value);
 		}
-		else if (Value is float[] floatArrayValue)
-		{
-			writer.Write((byte) '[');
-			for (int i = 0; i < floatArrayValue.Length; i++)
-			{
-				if (i > 0)
-					writer.Write((byte) ',');
-				writer.WriteString(floatArrayValue[i]);
-			}
-			writer.Write((byte) ']');
-		}
 		else
 		{
 			throw new NotSupportedException($"Parameter type {Value.GetType().Name} is not supported; see https://mysqlconnector.net/param-type. Value: {Value}");
@@ -740,6 +731,11 @@ private void AppendBinary(ByteBufferWriter writer, object value, StatementPrepar
 		{
 			writer.Write(unchecked((ulong) BitConverter.DoubleToInt64Bits(doubleValue)));
 		}
+		else if (value is float[] floatArrayValue)
+		{
+			writer.WriteLengthEncodedInteger(unchecked((ulong) floatArrayValue.Length * 4));
+			writer.Write(MemoryMarshal.AsBytes(floatArrayValue.AsSpan()));
+		}
 		else if (value is decimal decimalValue)
 		{
 			writer.WriteLengthEncodedAsciiString(decimalValue.ToString(CultureInfo.InvariantCulture));
@@ -882,14 +878,6 @@ private void AppendBinary(ByteBufferWriter writer, object value, StatementPrepar
 		{
 			writer.Write((ulong) value);
 		}
-		else if (value is float[] floatArrayValue)
-		{
-			writer.WriteLengthEncodedInteger((ulong) (floatArrayValue.Length * 4));
-			foreach (var floatValue in floatArrayValue)
-			{
-				writer.Write(BitConverter.GetBytes(floatValue));
-			}
-		}
 		else
 		{
 			throw new NotSupportedException($"Parameter type {value.GetType().Name} is not supported; see https://mysqlconnector.net/param-type. Value: {value}");

src/MySqlConnector/Protocol/ColumnType.cs

@@ -24,6 +24,7 @@ internal enum ColumnType
 	Bit = 16,
 	Timestamp2 = 17,
 	DateTime2 = 18,
+	Vector = 242,
 	Json = 0xF5,
 	NewDecimal = 0xF6,
 	Enum = 0xF7,

tests/MySqlConnector.Tests/MySqlParameterTests.cs

@@ -423,37 +423,4 @@ public void ScaleMixed()
 		((IDbDataParameter) parameter).Scale = 12;
 		Assert.Equal((byte) 12, ((MySqlParameter) parameter).Scale);
 	}
-
-	[Fact]
-	public void SetValueToFloatArrayInfersType()
-	{
-		var parameter = new MySqlParameter { Value = new float[] { 1.0f, 2.0f, 3.0f } };
-		Assert.Equal(DbType.Object, parameter.DbType);
-		Assert.Equal(MySqlDbType.Vector, parameter.MySqlDbType);
-	}
-
-	[Fact]
-	public void ConstructorNameTypeVector()
-	{
-		var parameter = new MySqlParameter("@vector", MySqlDbType.Vector);
-		Assert.Equal("@vector", parameter.ParameterName);
-		Assert.Equal(MySqlDbType.Vector, parameter.MySqlDbType);
-		Assert.Equal(DbType.Object, parameter.DbType);
-		Assert.False(parameter.IsNullable);
-		Assert.Null(parameter.Value);
-		Assert.Equal(ParameterDirection.Input, parameter.Direction);
-		Assert.Equal(0, parameter.Precision);
-		Assert.Equal(0, parameter.Scale);
-		Assert.Equal(0, parameter.Size);
-#if MYSQL_DATA
-		Assert.Equal(DataRowVersion.Default, parameter.SourceVersion);
-#else
-		Assert.Equal(DataRowVersion.Current, parameter.SourceVersion);
-#endif
-#if MYSQL_DATA
-		Assert.Null(parameter.SourceColumn);
-#else
-		Assert.Equal("", parameter.SourceColumn);
-#endif
-	}
 }