Remove Utility.EmptyByteArray.

This was only necessary for .NET 4.5 compatibility.

Signed-off-by: Bradley Grainger <[email protected]>

Author: bgrainger

src/MySqlConnector/Protocol/Payloads/AuthenticationMethodSwitchRequestPayload.cs

@@ -22,7 +22,7 @@ public static AuthenticationMethodSwitchRequestPayload Create(ReadOnlySpan<byte>
 			// if the packet is just the header byte (0xFE), it's an "Old Authentication Method Switch Request Packet"
 			// (possibly sent by a server that doesn't support CLIENT_PLUGIN_AUTH)
 			name = "mysql_old_password";
-			data = Utility.EmptyByteArray;
+			data = Array.Empty<byte>();
 		}
 		else
 		{

src/MySqlConnector/Protocol/Payloads/EmptyPayload.cs

@@ -4,5 +4,5 @@ namespace MySqlConnector.Protocol.Payloads;
 
 internal static class EmptyPayload
 {
-	public static PayloadData Instance { get; } = new(Utility.EmptyByteArray);
+	public static PayloadData Instance { get; } = new(Array.Empty<byte>());
 }

src/MySqlConnector/Protocol/Serialization/AuthenticationUtility.cs

@@ -10,7 +10,7 @@ namespace MySqlConnector.Protocol.Serialization;
 internal static class AuthenticationUtility
 {
 	public static byte[] CreateAuthenticationResponse(ReadOnlySpan<byte> challenge, string password) =>
-		string.IsNullOrEmpty(password) ? Utility.EmptyByteArray : HashPassword(challenge, password);
+		string.IsNullOrEmpty(password) ? Array.Empty<byte>() : HashPassword(challenge, password);
 
 	/// <summary>
 	/// Hashes a password with the "Secure Password Authentication" method.
@@ -57,7 +57,7 @@ public static byte[] HashPassword(ReadOnlySpan<byte> challenge, string password)
 	public static byte[] CreateScrambleResponse(ReadOnlySpan<byte> nonce, string password)
 	{
 		var scrambleResponse = string.IsNullOrEmpty(password)
-			? Utility.EmptyByteArray
+			? Array.Empty<byte>()
 			: HashPasswordWithNonce(nonce, password);
 
 		return scrambleResponse;

src/MySqlConnector/Utilities/Utility.cs

@@ -473,8 +473,6 @@ public static TimeSpan ParseTimeSpan(ReadOnlySpan<byte> value)
 		throw new FormatException("Couldn't interpret '{0}' as a valid TimeSpan".FormatInvariant(Encoding.UTF8.GetString(originalValue)));
 	}
 
-	public static byte[] EmptyByteArray { get; } = Array.Empty<byte>();
-
 #if !NETCOREAPP2_1_OR_GREATER && !NETSTANDARD2_1_OR_GREATER
 	public static bool TryComputeHash(this HashAlgorithm hashAlgorithm, ReadOnlySpan<byte> source, Span<byte> destination, out int bytesWritten)
 	{