Fix ByteHandler memory leak. Fixes #1247

bgrainger · bgrainger · commit cc241f0b1f04 · 2022-12-05T16:44:31.000-08:00
diff --git a/src/MySqlConnector/Protocol/Serialization/StandardPayloadHandler.cs b/src/MySqlConnector/Protocol/Serialization/StandardPayloadHandler.cs
@@ -32,7 +32,9 @@ public IByteHandler ByteHandler
 		}
 		set
 		{
+			var oldByteHandler = m_byteHandler;
 			m_byteHandler = value ?? throw new ArgumentNullException(nameof(value));
+			oldByteHandler?.Dispose();
 			m_bufferedByteReader = new();
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,9 @@ public IByteHandler ByteHandler`
`32`	`32`	`}`
`33`	`33`	`set`
`34`	`34`	`{`
	`35`	`+ var oldByteHandler = m_byteHandler;`
`35`	`36`	`m_byteHandler = value ?? throw new ArgumentNullException(nameof(value));`
	`37`	`+ oldByteHandler?.Dispose();`
`36`	`38`	`m_bufferedByteReader = new();`
`37`	`39`	`}`
`38`	`40`	`}`