Merge pull request #265 from adampoit/fix-old-guids

Escape single quote and backslash when writing GUIDs as byte arrays.

Author: bgrainger

src/MySqlConnector/MySqlClient/MySqlParameter.cs

@@ -161,7 +161,12 @@ internal void AppendSqlString(BinaryWriter writer, StatementPreparerOptions opti
 				if ((options & StatementPreparerOptions.OldGuids) != 0)
 				{
 					writer.WriteUtf8("_binary'");
-					writer.Write(guidValue.ToByteArray());
+					foreach (var by in guidValue.ToByteArray())
+					{
+						if (by == 0x27 || by == 0x5C)
+							writer.Write((byte) 0x5C);
+						writer.Write(by);
+					}
 					writer.Write((byte) '\'');
 				}
 				else

tests/SideBySide/InsertTests.cs

@@ -166,6 +166,38 @@ public void InsertDateTimeOffset()
 			Assert.Equal(value.datetimeoffset1.Value.UtcDateTime, datetime);
 		}
 
+		[Fact]
+		public void InsertOldGuid()
+		{
+			var csb = AppConfig.CreateConnectionStringBuilder();
+			csb.OldGuids = true;
+			using (var connection = new MySqlConnection(csb.ConnectionString))
+			{
+				connection.Open();
+				connection.Execute(@"drop table if exists old_guids;
+create table old_guids(id integer not null primary key auto_increment, guid binary(16) null);");
+
+				var guid = new Guid(1, 2, 3, 0x27, 0x5C, 0x7B, 0x7D, 0x22, 0x25, 0x26, 0x2C);
+
+				using (var cmd = connection.CreateCommand())
+				{
+					cmd.CommandText = @"insert into old_guids(guid) values(@guid)";
+					var parameter = cmd.CreateParameter();
+					parameter.ParameterName = "@guid";
+					parameter.Value = guid;
+					cmd.Parameters.Add(parameter);
+					cmd.ExecuteNonQuery();
+				}
+
+				using (var cmd = connection.CreateCommand())
+				{
+					cmd.CommandText = @"select guid from old_guids;";
+					var selected = (Guid) cmd.ExecuteScalar();
+					Assert.Equal(guid, selected);
+				}
+			}
+		}
+
 		[Fact]
 		public void InsertEnumValue()
 		{