Fix MySqlParameter.Clone; add tests.

Add overload of Clone with strongly-typed return value. Implement Clone by setting fields, not by invoking a constructor (so that HasSetDbType is initialised correctly).

Signed-off-by: Bradley Grainger <[email protected]>

Author: bgrainger

docs/content/tutorials/migrating-from-connector-net.md

@@ -136,3 +136,4 @@ The following bugs in Connector/NET are fixed by switching to MySqlConnector. (~
 * [#91754](https://bugs.mysql.com/bug.php?id=91754): Inserting 16MiB `BLOB` shifts it by four bytes when prepared
 * [#91770](https://bugs.mysql.com/bug.php?id=91770): `TIME(n)` column loses microseconds with prepared command
 * [#92367](https://bugs.mysql.com/bug.php?id=92367): `MySqlDataReader.GetDateTime` and `GetValue` return inconsistent values
+* [#92734](https://bugs.mysql.com/bug.php?id=92734): `MySqlParameter.Clone` doesn't copy all property values

src/MySqlConnector/MySql.Data.MySqlClient/MySqlParameter.cs

@@ -10,11 +10,9 @@
 
 namespace MySql.Data.MySqlClient
 {
-
-#if !NETSTANDARD1_3
-	public sealed class MySqlParameter : DbParameter, IDbDataParameter, ICloneable
-#else
 	public sealed class MySqlParameter : DbParameter, IDbDataParameter
+#if !NETSTANDARD1_3
+		, ICloneable
 #endif
 	{
 		public MySqlParameter()
@@ -159,24 +157,40 @@ public override void ResetDbType()
 			HasSetDbType = false;
 		}
 
+		public MySqlParameter Clone() => new MySqlParameter(this);
+
+#if !NETSTANDARD1_3
+		object ICloneable.Clone() => Clone();
+#endif
+
 		internal MySqlParameter WithParameterName(string parameterName) => new MySqlParameter(this, parameterName);
 
-		private MySqlParameter(MySqlParameter other, string parameterName)
+		private MySqlParameter(MySqlParameter other)
 		{
 			m_dbType = other.m_dbType;
 			m_mySqlDbType = other.m_mySqlDbType;
 			m_direction = other.m_direction;
 			HasSetDbType = other.HasSetDbType;
 			IsNullable = other.IsNullable;
 			Size = other.Size;
-			ParameterName = parameterName ?? other.ParameterName;
-			Value = other.Value;
-#if !NET45
+			m_name = other.m_name;
+			NormalizedParameterName = other.NormalizedParameterName;
+			m_value = other.m_value;
 			Precision = other.Precision;
 			Scale = other.Scale;
+			SourceColumn = other.SourceColumn;
+			SourceColumnNullMapping = other.SourceColumnNullMapping;
+#if !NETSTANDARD1_3
+			SourceVersion = other.SourceVersion;
 #endif
 		}
 
+		private MySqlParameter(MySqlParameter other, string parameterName)
+			: this(other)
+		{
+			ParameterName = parameterName ?? throw new ArgumentNullException(nameof(parameterName));
+		}
+
 		internal bool HasSetDirection => m_direction.HasValue;
 
 		internal bool HasSetDbType { get; set; }
@@ -617,13 +631,6 @@ private static void WriteTime(ByteBufferWriter writer, TimeSpan timeSpan)
 			}
 		}
 
-#if !NETSTANDARD1_3
-		public object Clone()
-		{
-			return new MySqlParameter(ParameterName, MySqlDbType, Size, Direction, IsNullable, Precision, Scale, SourceColumn, SourceVersion, Value);
-		}
-#endif
-
 		static readonly byte[] s_nullBytes = { 0x4E, 0x55, 0x4C, 0x4C }; // NULL
 		static readonly byte[] s_trueBytes = { 0x74, 0x72, 0x75, 0x65 }; // true
 		static readonly byte[] s_falseBytes = { 0x66, 0x61, 0x6C, 0x73, 0x65 }; // false

tests/SideBySide/ParameterTests.cs

@@ -208,6 +208,104 @@ public void ConstructorEverything()
 		}
 #endif
 
+		[Fact]
+		public void CloneParameterName()
+		{
+			var parameter = new MySqlParameter { ParameterName = "test" };
+			var clone = parameter.Clone();
+			Assert.Equal(parameter.ParameterName, clone.ParameterName);
+		}
+
+		[Fact]
+		public void CloneDbType()
+		{
+			var parameter = new MySqlParameter { DbType = DbType.Int64 };
+			var clone = parameter.Clone();
+			Assert.Equal(parameter.DbType, clone.DbType);
+		}
+
+		[Fact]
+		public void CloneMySqlDbType()
+		{
+			var parameter = new MySqlParameter { MySqlDbType = MySqlDbType.MediumText };
+			var clone = parameter.Clone();
+			Assert.Equal(parameter.MySqlDbType, clone.MySqlDbType);
+		}
+
+		[Fact]
+		public void CloneDirection()
+		{
+			var parameter = new MySqlParameter { Direction = ParameterDirection.InputOutput };
+			var clone = parameter.Clone();
+			Assert.Equal(parameter.Direction, clone.Direction);
+		}
+
+		[SkippableFact(Baseline = "https://bugs.mysql.com/bug.php?id=92734")]
+		public void CloneIsNullable()
+		{
+			var parameter = new MySqlParameter { IsNullable = true };
+			var clone = parameter.Clone();
+			Assert.Equal(parameter.IsNullable, clone.IsNullable);
+		}
+
+		[SkippableFact(Baseline = "https://bugs.mysql.com/bug.php?id=92734")]
+		public void ClonePrecision()
+		{
+			var parameter = new MySqlParameter { Precision = 10 };
+			var clone = parameter.Clone();
+			Assert.Equal(parameter.Precision, clone.Precision);
+		}
+
+		[SkippableFact(Baseline = "https://bugs.mysql.com/bug.php?id=92734")]
+		public void CloneScale()
+		{
+			var parameter = new MySqlParameter { Scale = 12 };
+			var clone = parameter.Clone();
+			Assert.Equal(parameter.Scale, clone.Scale);
+		}
+
+		[SkippableFact(Baseline = "https://bugs.mysql.com/bug.php?id=92734")]
+		public void CloneSize()
+		{
+			var parameter = new MySqlParameter { Size = 8 };
+			var clone = parameter.Clone();
+			Assert.Equal(parameter.Size, clone.Size);
+		}
+
+		[Fact]
+		public void CloneSourceColumn()
+		{
+			var parameter = new MySqlParameter { SourceColumn = "test" };
+			var clone = parameter.Clone();
+			Assert.Equal(parameter.SourceColumn, clone.SourceColumn);
+		}
+
+		[SkippableFact(Baseline = "https://bugs.mysql.com/bug.php?id=92734")]
+		public void CloneSourceColumnNullMapping()
+		{
+			var parameter = new MySqlParameter { SourceColumnNullMapping = true };
+			var clone = parameter.Clone();
+			Assert.Equal(parameter.SourceColumnNullMapping, clone.SourceColumnNullMapping);
+		}
+
+#if !NETCOREAPP1_1_2
+		[Fact]
+		public void CloneSourceVersion()
+		{
+			var parameter = new MySqlParameter { SourceVersion = DataRowVersion.Proposed };
+			var clone = parameter.Clone();
+			Assert.Equal(parameter.SourceVersion, clone.SourceVersion);
+		}
+#endif
+
+		[Fact]
+		public void CloneValue()
+		{
+			var parameter = new MySqlParameter { Value = "test" };
+			var clone = parameter.Clone();
+			Assert.Equal(parameter.Value, clone.Value);
+		}
+
 		[Theory]
 		[InlineData(1, DbType.Int32, MySqlDbType.Int32)]
 		[InlineData(1.0, DbType.Double, MySqlDbType.Double)]