Fix parsing 'nan' on .NET Framework.

Utf8Parser is case-sensitive in .NET Framework.

Run MySqlConnector.Tests unit tests on .NET Framework. Fix a difference between .NET Framework and .NET formatting of floats.

Author: bgrainger

src/MySqlConnector/Core/TextRow.cs

@@ -98,21 +98,25 @@ protected override object GetValueCore(ReadOnlySpan<byte> data, ColumnDefinition
 		case ColumnType.Float:
 			if (Utf8Parser.TryParse(data, out float floatValue, out var floatBytesConsumed) && floatBytesConsumed == data.Length)
 				return floatValue;
-			ReadOnlySpan<byte> floatInfinity = new byte[] { 0x2D, 0x69, 0x6E, 0x66 }; // "-inf"
+			ReadOnlySpan<byte> floatInfinity = "-inf"u8;
 			if (data.SequenceEqual(floatInfinity))
 				return float.NegativeInfinity;
 			if (data.SequenceEqual(floatInfinity.Slice(1)))
 				return float.PositiveInfinity;
+			if (data.SequenceEqual("nan"u8))
+				return float.NaN;
 			throw new FormatException($"Couldn't parse value as float: {Encoding.UTF8.GetString(data)}");
 
 		case ColumnType.Double:
 			if (Utf8Parser.TryParse(data, out double doubleValue, out var doubleBytesConsumed) && doubleBytesConsumed == data.Length)
 				return doubleValue;
-			ReadOnlySpan<byte> doubleInfinity = new byte[] { 0x2D, 0x69, 0x6E, 0x66 }; // "-inf"
+			ReadOnlySpan<byte> doubleInfinity = "-inf"u8;
 			if (data.SequenceEqual(doubleInfinity))
 				return double.NegativeInfinity;
 			if (data.SequenceEqual(doubleInfinity.Slice(1)))
 				return double.PositiveInfinity;
+			if (data.SequenceEqual("nan"u8))
+				return double.NaN;
 			throw new FormatException($"Couldn't parse value as double: {Encoding.UTF8.GetString(data)}");
 
 		case ColumnType.Decimal:

tests/MySqlConnector.Tests/MySqlConnector.Tests.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup Condition=" '$(Configuration)' != 'MySqlData' ">
-    <TargetFrameworks>netcoreapp3.1;net7.0</TargetFrameworks>
+    <TargetFrameworks>net481;net7.0</TargetFrameworks>
   </PropertyGroup>
 
  <PropertyGroup Condition=" '$(Configuration)' == 'MySqlData' ">
@@ -25,6 +25,10 @@
     <PackageReference Include="xunit" Version="2.4.2" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.5" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.4.1" />
+    <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.3">
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+      <PrivateAssets>all</PrivateAssets>
+    </PackageReference>
   </ItemGroup>
 
   <ItemGroup Condition=" '$(Configuration)' != 'MySqlData' ">
@@ -36,9 +40,4 @@
     <Compile Remove="ByteBufferWriterTests.cs;CachedProcedureTests.cs;CancellationTests.cs;ConnectionTests.cs;FakeMySqlServer.cs;FakeMySqlServerConnection.cs;LoadBalancerTests.cs;MySqlDecimalTests.cs;MySqlExceptionTests.cs;MySqlParameterCollectionNameToIndexTests.cs;NormalizeTests.cs;ServerVersionTests.cs;StatementPreparerTests.cs;TypeMapperTests.cs;UtilityTests.cs" />
   </ItemGroup>
 
-  <ItemGroup Condition=" '$(TargetFramework)' == 'net462' ">
-    <Reference Include="System" />
-    <Reference Include="Microsoft.CSharp" />
-  </ItemGroup>
-
 </Project>

tests/MySqlConnector.Tests/StatementPreparerTests.cs

@@ -5,6 +5,7 @@
 using System.Text;
 using MySqlConnector.Core;
 using MySqlConnector.Protocol.Serialization;
+using MySqlConnector.Utilities;
 using Xunit;
 
 namespace MySqlConnector.Tests;
@@ -156,7 +157,11 @@ public void FormatParameter(object parameterValue, string replacedValue, bool no
 			new object[] { 3_456_789_012u, "3456789012" },
 			new object[] { -12_345_678_901L, "-12345678901" },
 			new object[] { 12_345_678_901UL, "12345678901" },
+#if NET481
+			new object[] { 1.0123456f, "1.01234555" },
+#else
 			new object[] { 1.0123456f, "1.0123456" },
+#endif
 			new object[] { 1.0123456789012346, "1.0123456789012346" },
 			new object[] { 123456789.123456789m, "123456789.123456789" },
 			new object[] { "1234", "'1234'" },