Handle synchronously-thrown exceptions consistently.

Both sync and async exceptions should go through TryAsyncContinuation. This ensures that a synchronously-thrown SocketException will transition the MySqlSession to the failed state.

Author: bgrainger

src/MySqlConnector/Serialization/MySqlSession.cs

@@ -447,7 +447,16 @@ private void ShutdownSocket()
 		private ValueTask<int> TryAsync<TArg>(Func<TArg, IOBehavior, ValueTask<int>> func, TArg arg, IOBehavior ioBehavior, CancellationToken cancellationToken)
 		{
 			VerifyConnected();
-			var task = func(arg, ioBehavior);
+			ValueTask<int> task;
+			try
+			{
+				task = func(arg, ioBehavior);
+			}
+			catch (Exception ex)
+			{
+				task = ValueTaskExtensions.FromException<int>(ex);
+			}
+
 			if (task.IsCompletedSuccessfully)
 				return task;
 
@@ -468,7 +477,16 @@ private int TryAsyncContinuation(Task<int> task)
 		private ValueTask<PayloadData> TryAsync(Func<ProtocolErrorBehavior, IOBehavior, ValueTask<ArraySegment<byte>>> func, IOBehavior ioBehavior, CancellationToken cancellationToken)
 		{
 			VerifyConnected();
-			var task = func(ProtocolErrorBehavior.Throw, ioBehavior);
+			ValueTask<ArraySegment<byte>> task;
+			try
+			{
+				task = func(ProtocolErrorBehavior.Throw, ioBehavior);
+			}
+			catch (Exception ex)
+			{
+				task = ValueTaskExtensions.FromException<ArraySegment<byte>>(ex);
+			}
+
 			if (task.IsCompletedSuccessfully)
 			{
 				var payload = new PayloadData(task.Result);