Reduce severity of "intermediate" log statements.

When a session fails to ping the server when it's retrieved from the connection pool, it's ultimately logged as a warning. Reduce the severity (from Error) of log messages that are logged before that happens.

This removes spurious errors (that are handled inside the library) from clients' log output.

Author: bgrainger

src/MySqlConnector/Core/ServerSession.cs

@@ -562,7 +562,7 @@ public ValueTask<PayloadData> ReceiveReplyAsync(IOBehavior ioBehavior, Cancellat
 			catch (Exception ex)
 			{
 				m_logArguments[1] = ex.Message;
-				Log.Error(ex, "{0} failed in ReceiveReplyAsync: {1}", m_logArguments);
+				Log.Info(ex, "{0} failed in ReceiveReplyAsync: {1}", m_logArguments);
 				if ((ex as MySqlException)?.Number == (int) MySqlErrorCode.CommandTimeoutExpired)
 					HandleTimeout();
 				task = ValueTaskExtensions.FromException<ArraySegment<byte>>(ex);
@@ -593,7 +593,7 @@ public ValueTask<int> SendReplyAsync(PayloadData payload, IOBehavior ioBehavior,
 			catch (Exception ex)
 			{
 				m_logArguments[1] = ex.Message;
-				Log.Error(ex, "{0} failed in SendReplyAsync: {1}", m_logArguments);
+				Log.Info(ex, "{0} failed in SendReplyAsync: {1}", m_logArguments);
 				task = ValueTaskExtensions.FromException<int>(ex);
 			}
 
@@ -996,7 +996,6 @@ private int TryAsyncContinuation(Task<int> task)
 			if (task.IsFaulted)
 			{
 				SetFailed();
-				Log.Error(task.Exception.InnerException, "{0} failed in TryAsyncContinuation", m_logArguments);
 				task.GetAwaiter().GetResult();
 			}
 			return 0;
@@ -1005,10 +1004,7 @@ private int TryAsyncContinuation(Task<int> task)
 		private PayloadData TryAsyncContinuation(Task<ArraySegment<byte>> task)
 		{
 			if (task.IsFaulted)
-			{
 				SetFailed();
-				Log.Error(task.Exception.InnerException, "{0} failed in TryAsyncContinuation", m_logArguments);
-			}
 			ArraySegment<byte> bytes;
 			try
 			{
@@ -1027,7 +1023,7 @@ private PayloadData TryAsyncContinuation(Task<ArraySegment<byte>> task)
 
 		internal void SetFailed()
 		{
-			Log.Error("{0} setting state to Failed", m_logArguments);
+			Log.Info("{0} setting state to Failed", m_logArguments);
 			lock (m_lock)
 				m_state = State.Failed;
 		}