Stop sending final MySqlRowsCopied event.

This was a workaround for the lack of a RowsCopied property, which will be added.

Author: bgrainger

src/MySqlConnector/MySql.Data.MySqlClient/MySqlBulkCopy.cs

@@ -283,13 +283,6 @@ await m_valuesEnumerator.MoveNextAsync().ConfigureAwait(false) :
 					var payload2 = new PayloadData(new ArraySegment<byte>(buffer, 0, outputIndex));
 					await m_connection.Session.SendReplyAsync(payload2, ioBehavior, cancellationToken).ConfigureAwait(false);
 				}
-
-				// send final RowsCopied event (if it wasn't already sent)
-				if (eventArgs is object && rowsCopied % NotifyAfter != 0)
-				{
-					eventArgs.RowsCopied = rowsCopied;
-					MySqlRowsCopied!(this, eventArgs);
-				}
 			}
 			finally
 			{

tests/SideBySide/BulkLoaderAsync.cs

@@ -506,8 +506,8 @@ public async Task BulkLoadDataTableWithTooLongData()
 		[Theory]
 		[InlineData(0, 15, 0, 0)]
 		[InlineData(5, 15, 3, 15)]
-		[InlineData(5, 16, 4, 16)]
-		[InlineData(int.MaxValue, 15, 1, 15)]
+		[InlineData(5, 16, 3, 15)]
+		[InlineData(int.MaxValue, 0, 0, 0)]
 		public async Task BulkCopyNotifyAfter(int notifyAfter, int rowCount, int expectedEventCount, int expectedRowsCopied)
 		{
 			using var connection = new MySqlConnection(GetLocalConnectionString());
@@ -547,7 +547,7 @@ public async Task BulkCopyNotifyAfter(int notifyAfter, int rowCount, int expecte
 		[InlineData(0, 40, 0, 0, 0, 40)]
 		[InlineData(5, 40, 15, 3, 15, 0)]
 		[InlineData(5, 40, 20, 4, 20, 16)]
-		[InlineData(int.MaxValue, 20, 0, 1, 20, 20)]
+		[InlineData(int.MaxValue, 20, 0, 0, 0, 20)]
 		public async Task BulkCopyAbort(int notifyAfter, int rowCount, int abortAfter, int expectedEventCount, int expectedRowsCopied, long expectedCount)
 		{
 			using var connection = new MySqlConnection(GetLocalConnectionString());

tests/SideBySide/BulkLoaderSync.cs

@@ -702,8 +702,8 @@ public void BulkLoadDataTableWithTooLongString()
 		[Theory]
 		[InlineData(0, 15, 0, 0)]
 		[InlineData(5, 15, 3, 15)]
-		[InlineData(5, 16, 4, 16)]
-		[InlineData(int.MaxValue, 15, 1, 15)]
+		[InlineData(5, 16, 3, 15)]
+		[InlineData(int.MaxValue, 0, 0, 0)]
 		public void BulkCopyNotifyAfter(int notifyAfter, int rowCount, int expectedEventCount, int expectedRowsCopied)
 		{
 			using var connection = new MySqlConnection(GetLocalConnectionString());
@@ -743,7 +743,7 @@ public void BulkCopyNotifyAfter(int notifyAfter, int rowCount, int expectedEvent
 		[InlineData(0, 40, 0, 0, 0, 40)]
 		[InlineData(5, 40, 15, 3, 15, 0)]
 		[InlineData(5, 40, 20, 4, 20, 16)]
-		[InlineData(int.MaxValue, 20, 0, 1, 20, 20)]
+		[InlineData(int.MaxValue, 20, 0, 0, 0, 20)]
 		public void BulkCopyAbort(int notifyAfter, int rowCount, int abortAfter, int expectedEventCount, int expectedRowsCopied, long expectedCount)
 		{
 			using var connection = new MySqlConnection(GetLocalConnectionString());