Merge v1.3 into master.

Conflicts:
	src/MySqlConnector/Core/Row.cs
	src/MySqlConnector/Core/ServerSession.cs
	src/MySqlConnector/MySqlConnection.cs
	src/MySqlConnector/Protocol/Payloads/EofPayload.cs
	src/MySqlConnector/Protocol/Serialization/StreamByteHandler.cs
	src/MySqlConnector/Utilities/Utility.cs

Author: bgrainger

src/MySqlConnector/Core/Row.cs

@@ -170,7 +170,7 @@ public Guid GetGuid(int ordinal)
 		if (value is string stringValue && Guid.TryParse(stringValue, out guid))
 			return guid;
 
-		if (value is byte[] bytes && bytes.Length == 16)
+		if (value is byte[] { Length: 16 } bytes)
 			return CreateGuidFromBytes(Connection.GuidFormat, bytes);
 
 		throw new InvalidCastException("The value could not be converted to a GUID: {0}".FormatInvariant(value));
@@ -421,7 +421,7 @@ public float GetFloat(int ordinal)
 		// Use explicit range checks to guard against that.
 		return value switch
 		{
-			double doubleValue => (doubleValue >= float.MinValue && doubleValue <= float.MaxValue ? (float) doubleValue : throw new InvalidCastException("The value cannot be safely cast to Single.")),
+			double doubleValue => (doubleValue is >= float.MinValue and <= float.MaxValue ? (float) doubleValue : throw new InvalidCastException("The value cannot be safely cast to Single.")),
 			decimal decimalValue => (float) decimalValue,
 			_ => (float) value
 		};

src/MySqlConnector/Core/ServerSession.cs

@@ -882,7 +882,7 @@ private async ValueTask<PayloadData> ReceiveReplyAsyncAwaited(ValueTask<ArraySeg
 		catch (Exception ex)
 		{
 			SetFailed(ex);
-			if (ex is MySqlException msex && msex.ErrorCode == MySqlErrorCode.CommandTimeoutExpired)
+			if (ex is MySqlException { ErrorCode: MySqlErrorCode.CommandTimeoutExpired })
 				HandleTimeout();
 			throw;
 		}
@@ -1009,11 +1009,11 @@ private async Task<bool> OpenTcpSocketAsync(ConnectionSettings cs, ILoadBalancer
 								}
 							}
 						}
-						catch (ObjectDisposedException ex) when (cancellationToken.IsCancellationRequested)
+						catch (ObjectDisposedException) when (cancellationToken.IsCancellationRequested)
 						{
 							SafeDispose(ref tcpClient);
 							Log.Info("Session{0} connect timeout expired connecting to IpAddress {1} for HostName '{2}'", m_logArguments[0], ipAddress, hostName);
-							throw new MySqlException(MySqlErrorCode.UnableToConnectToHost, "Connect Timeout expired.", ex);
+							throw new MySqlException(MySqlErrorCode.UnableToConnectToHost, "Connect Timeout expired.");
 						}
 					}
 				}
@@ -1066,10 +1066,10 @@ private async Task<bool> OpenUnixSocketAsync(ConnectionSettings cs, IOBehavior i
 						socket.Connect(unixEp);
 					}
 				}
-				catch (ObjectDisposedException ex) when (cancellationToken.IsCancellationRequested)
+				catch (ObjectDisposedException) when (cancellationToken.IsCancellationRequested)
 				{
 					Log.Info("Session{0} connect timeout expired connecting to UNIX Socket '{1}'", m_logArguments);
-					throw new MySqlException(MySqlErrorCode.UnableToConnectToHost, "Connect Timeout expired.", ex);
+					throw new MySqlException(MySqlErrorCode.UnableToConnectToHost, "Connect Timeout expired.");
 				}
 			}
 		}
@@ -1120,7 +1120,7 @@ private async Task<bool> OpenNamedPipeAsync(ConnectionSettings cs, int startTick
 				{
 					m_logArguments[1] = cs.PipeName;
 					Log.Info("Session{0} connect timeout expired connecting to named pipe '{1}'", m_logArguments);
-					throw new MySqlException(MySqlErrorCode.UnableToConnectToHost, "Connect Timeout expired.", ex);
+					throw new MySqlException(MySqlErrorCode.UnableToConnectToHost, "Connect Timeout expired.");
 				}
 			}
 		}
@@ -1382,7 +1382,7 @@ await sslStream.AuthenticateAsClientAsync(clientAuthenticationOptions.TargetHost
 				throw new MySqlException(MySqlErrorCode.UnableToConnectToHost, "SSL Authentication Error", ex);
 			if (ex is IOException && clientCertificates is not null)
 				throw new MySqlException(MySqlErrorCode.UnableToConnectToHost, "MySQL Server rejected client certificate", ex);
-			if (ex is Win32Exception win32 && win32.NativeErrorCode == -2146893007) // SEC_E_ALGORITHM_MISMATCH (0x80090331)
+			if (ex is Win32Exception { NativeErrorCode: -2146893007 }) // SEC_E_ALGORITHM_MISMATCH (0x80090331)
 				throw new MySqlException(MySqlErrorCode.UnableToConnectToHost, "The server doesn't support the client's specified TLS versions.", ex);
 			throw;
 		}

src/MySqlConnector/MySqlConnection.cs

@@ -408,10 +408,10 @@ internal async Task OpenAsync(IOBehavior? ioBehavior, CancellationToken cancella
 			cancellationToken.ThrowIfCancellationRequested();
 			throw;
 		}
-		catch (SocketException ex)
+		catch (SocketException)
 		{
 			SetState(ConnectionState.Closed);
-			throw new MySqlException(MySqlErrorCode.UnableToConnectToHost, "Unable to connect to any of the specified MySQL hosts.", ex);
+			throw new MySqlException(MySqlErrorCode.UnableToConnectToHost, "Unable to connect to any of the specified MySQL hosts.");
 		}
 
 		if (m_connectionSettings.AutoEnlist && System.Transactions.Transaction.Current is not null)
@@ -856,10 +856,10 @@ private async ValueTask<ServerSession> CreateSessionAsync(ConnectionPool? pool,
 				return session;
 			}
 		}
-		catch (OperationCanceledException ex) when (timeoutSource?.IsCancellationRequested ?? false)
+		catch (OperationCanceledException) when (timeoutSource?.IsCancellationRequested ?? false)
 		{
 			var messageSuffix = (pool?.IsEmpty ?? false) ? " All pooled connections are in use." : "";
-			throw new MySqlException(MySqlErrorCode.UnableToConnectToHost, "Connect Timeout expired." + messageSuffix, ex);
+			throw new MySqlException(MySqlErrorCode.UnableToConnectToHost, "Connect Timeout expired." + messageSuffix);
 		}
 		catch (MySqlException ex) when ((timeoutSource?.IsCancellationRequested ?? false) || (ex.ErrorCode == MySqlErrorCode.CommandTimeoutExpired))
 		{

src/MySqlConnector/Protocol/Payloads/EofPayload.cs

@@ -30,7 +30,7 @@ public static EofPayload Create(ReadOnlySpan<byte> span)
 	/// <param name="payload">The payload to examine.</param>
 	/// <returns><c>true</c> if this is an EOF packet; otherwise, <c>false</c>.</returns>
 	public static bool IsEof(PayloadData payload) =>
-		payload.Span.Length > 0 && payload.Span.Length < 9 && payload.HeaderByte == Signature;
+		payload.Span.Length is > 0 and < 9 && payload.HeaderByte == Signature;
 
 	public const byte Signature = 0xFE;
 

src/MySqlConnector/Protocol/Serialization/StreamByteHandler.cs

@@ -38,7 +38,7 @@ ValueTask<int> DoReadBytesSync(Memory<byte> buffer)
 			}
 			catch (Exception ex)
 			{
-				if (RemainingTimeout != Constants.InfiniteTimeout && ex is IOException ioException && ioException.InnerException is SocketException socketException && socketException.SocketErrorCode == SocketError.TimedOut)
+				if (RemainingTimeout != Constants.InfiniteTimeout && ex is IOException { InnerException: SocketException { SocketErrorCode: SocketError.TimedOut } })
 					return ValueTaskExtensions.FromException<int>(MySqlException.CreateForTimeout(ex));
 				return ValueTaskExtensions.FromException<int>(ex);
 			}

src/MySqlConnector/Utilities/Utility.cs

@@ -620,7 +620,7 @@ public static SslProtocols GetDefaultSslProtocols()
 			try
 			{
 				var property = typeof(ServicePointManager).GetProperty("DisableSystemDefaultTlsVersions", BindingFlags.NonPublic | BindingFlags.Static);
-				disableSystemDefaultTlsVersions = property is null || (property.GetValue(null) is bool b && b);
+				disableSystemDefaultTlsVersions = property is null || property.GetValue(null) is true;
 			}
 			catch (Exception)
 			{