Raise Component.Disposed from DisposeAsync. Fixes #1235

Author: bgrainger

src/MySqlConnector/MySqlConnection.cs

@@ -694,6 +694,11 @@ public async Task DisposeAsync()
 		finally
 		{
 			m_isDisposed = true;
+
+			// Component implements the Dispose pattern, with some core logic implemented in Dispose(bool disposing). DbConnection
+			// adds DisposeAsync but doesn't implement the full DisposeAsyncCore pattern. Thus, although DisposeAsync is supposed
+			// to call Dispose(false), we call Dispose(true) here to execute that base class logic in both the sync and async paths.
+			base.Dispose(true);
 		}
 	}
 

tests/IntegrationTests/ConnectAsync.cs

@@ -524,6 +524,17 @@ public async Task UnixDomainSocket()
 		Assert.Equal(ConnectionState.Open, connection.State);
 	}
 
+	[Fact]
+	public async Task DisposeAsyncRaisesDisposed()
+	{
+		var disposedCount = 0;
+		var connection = new MySqlConnection(AppConfig.ConnectionString);
+		connection.Disposed += (sender, args) => disposedCount++;
+		await connection.OpenAsync().ConfigureAwait(false);
+		await connection.DisposeAsync().ConfigureAwait(false);
+		Assert.Equal(1, disposedCount);
+	}
+
 	readonly DatabaseFixture m_database;
 }
 

tests/IntegrationTests/ConnectSync.cs

@@ -589,5 +589,16 @@ public void UnixDomainSocket()
 		Assert.Equal(ConnectionState.Open, connection.State);
 	}
 
+	[Fact]
+	public void DisposeRaisesDisposed()
+	{
+		var disposedCount = 0;
+		var connection = new MySqlConnection(AppConfig.ConnectionString);
+		connection.Disposed += (sender, args) => disposedCount++;
+		connection.Open();
+		connection.Dispose();
+		Assert.Equal(1, disposedCount);
+	}
+
 	readonly DatabaseFixture m_database;
 }