Skip to content

Commit fea73f0

Browse files
committed
Enable all GetSchemaTable tests for baseline build.
Opt out of the specific problem for "ColumnSize" values.
1 parent 69f57df commit fea73f0

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

docs/content/tutorials/migrating-from-connector-net.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,3 +93,4 @@ property doesn't reference the active transaction. See [#333](https://github.com
9393
* [#84701](https://bugs.mysql.com/bug.php?id=84701): Can't create a paramter using a 64-bit enum with a value greater than int.MaxValue
9494
* [#85185](https://bugs.mysql.com/bug.php?id=85185): `ConnectionReset=True` does not preserve connection charset
9595
* [#86263](https://bugs.mysql.com/bug.php?id=86263): Transaction isolation level affects all transactions in session
96+
* [#87868](https://bugs.mysql.com/bug.php?id=87868): `ColumnSize` in schema table is incorrect for `CHAR(36)` and `BLOB` columns

tests/SideBySide/DataTypes.cs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -608,11 +608,9 @@ public void InsertLargeBlobSync(string column, int size)
608608
[InlineData("Double", "datatypes_reals", 22, typeof(double), false, false, true, 0, 31)]
609609
[InlineData("MediumDecimal", "datatypes_reals", 30, typeof(decimal), false, false, true, 28, 8)]
610610
[InlineData("utf8", "datatypes_strings", 300, typeof(string), false, false, true, 0, 0)]
611-
#if !BASELINE
612611
[InlineData("guid", "datatypes_strings", 36, typeof(Guid), false, false, true, 0, 0)]
613612
[InlineData("guidbin", "datatypes_strings", 36, typeof(Guid), false, false, true, 0, 0)]
614613
[InlineData("Blob", "datatypes_blobs", 65535, typeof(byte[]), true, false, true, 0, 0)]
615-
#endif
616614
[InlineData("Date", "datatypes_times", 10, typeof(DateTime), false, false, true, 0, 0)]
617615
[InlineData("Time", "datatypes_times", 17, typeof(TimeSpan), false, false, true, 0, 6)]
618616
public void GetSchemaTable(string column, string table, int columnSize, Type dataType, bool isLong, bool isKey, bool allowDbNull, int precision, int scale)
@@ -633,7 +631,13 @@ public void GetSchemaTable(string column, string table, int columnSize, Type dat
633631
#endif
634632
Assert.Equal(ordinal, schema["ColumnOrdinal"]);
635633
Assert.Equal(dataType, schema["DataType"]);
634+
#if BASELINE
635+
// https://bugs.mysql.com/bug.php?id=87868
636+
if (dataType != typeof(byte[]) && dataType != typeof(Guid))
637+
Assert.Equal(columnSize, schema["ColumnSize"]);
638+
#else
636639
Assert.Equal(columnSize, schema["ColumnSize"]);
640+
#endif
637641
Assert.Equal(isLong, schema["IsLong"]);
638642
Assert.Equal(isKey, schema["IsKey"]);
639643
Assert.Equal(allowDbNull, schema["AllowDBNull"]);

0 commit comments

Comments
 (0)