add DebugOnly tests

Author: caleblloyd

.ci/test.ps1

@@ -24,6 +24,11 @@ dotnet test tests\SideBySide\SideBySide.csproj -c Release
 if ($LASTEXITCODE -ne 0){
     exit $LASTEXITCODE;
 }
+echo "Executing Debug Only tests"
+dotnet test tests\SideBySide\SideBySide.csproj -c Debug --filter "FullyQualifiedName~SideBySide.DebugOnlyTests"
+if ($LASTEXITCODE -ne 0){
+    exit $LASTEXITCODE;
+}
 
 echo "Executing tests with Compression, No SSL"
 Copy-Item -Force .ci\config\config.compression.json tests\SideBySide\config.json

.travis.yml

@@ -18,6 +18,7 @@ script:
 - dotnet test tests/MySqlConnector.Tests/MySqlConnector.Tests.csproj -c Release -f netcoreapp1.1.1
 - dotnet build tests/SideBySide/SideBySide.csproj -c Release -f netcoreapp1.1.1
 - echo 'Executing tests with No Compression, No SSL' && ./.ci/use-config.sh config.json 172.17.0.1 3307 && time dotnet test tests/SideBySide/SideBySide.csproj -c Release -f netcoreapp1.1.1
+- echo 'Executing Debug Only tests' && time dotnet test tests/SideBySide/SideBySide.csproj -c Debug -f netcoreapp1.1.1 --filter "FullyQualifiedName~SideBySide.DebugOnlyTests"
 - echo 'Executing tests with Compression, No SSL' && ./.ci/use-config.sh config.compression.json 172.17.0.1 3307 && time dotnet test tests/SideBySide/SideBySide.csproj -c Release -f netcoreapp1.1.1
 - echo 'Executing tests with No Compression, SSL' && ./.ci/use-config.sh config.ssl.json 172.17.0.1 3307 && time dotnet test tests/SideBySide/SideBySide.csproj -c Release -f netcoreapp1.1.1
 - echo 'Executing tests with Compression, SSL' && ./.ci/use-config.sh config.compression+ssl.json 172.17.0.1 3307 && time dotnet test tests/SideBySide/SideBySide.csproj -c Release -f netcoreapp1.1.1

src/MySqlConnector/MySqlClient/ConnectionPool.cs

@@ -215,7 +215,11 @@ private ConnectionPool(ConnectionSettings cs)
 		}
 
 		static readonly ConcurrentDictionary<string, ConnectionPool> s_pools = new ConcurrentDictionary<string, ConnectionPool>();
+#if DEBUG
+		static readonly TimeSpan ReaperInterval = TimeSpan.FromSeconds(1);
+#else
 		static readonly TimeSpan ReaperInterval = TimeSpan.FromMinutes(1);
+#endif
 		static readonly Task Reaper = Task.Run(async () => {
 			while (true)
 			{

src/MySqlConnector/MySqlConnector.csproj

@@ -36,6 +36,10 @@
     <PackageReference Include="System.Threading.Tasks.Extensions" Version="4.3.0" />
   </ItemGroup>
 
+  <PropertyGroup Condition=" '$(Configuration)' == 'Debug' ">
+    <DefineConstants>DEBUG</DefineConstants>
+  </PropertyGroup>
+
   <ItemGroup>
     <Compile Update="MySqlClient\MySqlCommand.cs">
       <SubType>Component</SubType>

tests/SideBySide/DebugOnlyTests.cs

@@ -0,0 +1,46 @@
+using System;
+using System.Collections.Generic;
+using System.Threading.Tasks;
+using MySql.Data.MySqlClient;
+using Xunit;
+
+namespace SideBySide
+{
+	public class DebugOnlyTests : IClassFixture<DatabaseFixture>
+	{
+
+		[Theory]
+		[InlineData(1u, 3u, 0u, 5u)]
+		[InlineData(1u, 3u, 3u, 5u)]
+		public async Task ConnectionLifeTime(uint idleTimeout, uint delaySeconds, uint minPoolSize, uint maxPoolSize)
+		{
+			var csb = AppConfig.CreateConnectionStringBuilder();
+			csb.Pooling = true;
+			csb.MinimumPoolSize = minPoolSize;
+			csb.MaximumPoolSize = maxPoolSize;
+			csb.ConnectionIdleTimeout = idleTimeout;
+			HashSet<int> serverThreadIdsBegin = new HashSet<int>();
+			HashSet<int> serverThreadIdsEnd = new HashSet<int>();
+
+			async Task OpenConnections(uint numConnections, HashSet<int> serverIdSet)
+			{
+				using (var connection = new MySqlConnection(csb.ConnectionString))
+				{
+					await connection.OpenAsync();
+					serverIdSet.Add(connection.ServerThread);
+					if (--numConnections <= 0)
+						return;
+					await OpenConnections(numConnections, serverIdSet);
+				}
+			}
+
+			await OpenConnections(maxPoolSize, serverThreadIdsBegin);
+			await Task.Delay(TimeSpan.FromSeconds(delaySeconds));
+			await OpenConnections(maxPoolSize, serverThreadIdsEnd);
+
+			serverThreadIdsEnd.IntersectWith(serverThreadIdsBegin);
+			Assert.Equal((int)minPoolSize, serverThreadIdsEnd.Count);
+		}
+
+	}
+}

tests/SideBySide/SideBySide.csproj

@@ -41,6 +41,10 @@
     <PackageReference Include="MySql.Data" Version="6.9.8" />
   </ItemGroup>
 
+  <ItemGroup Condition=" '$(Configuration)' != 'Debug' ">
+    <Compile Remove="DebugOnlyTests.cs" />
+  </ItemGroup>
+
   <ItemGroup Condition=" '$(TargetFramework)' == 'net462' ">
     <Reference Include="System" />
     <Reference Include="Microsoft.CSharp" />