BUG#37410052: Wrong exception message being shown when

ConnectionRefusedError is raised by the client

This patch fixes the incorrect error message which is being shown by
the client when ConnectionRefusedError is being raised while connecting
with a MySQL server.

Change-Id: I6d99a0ee68e66105c17c975fa9e30717574fea5a

Author: SubCoder1

CHANGES.txt

@@ -18,6 +18,7 @@ v9.3.0
 - BUG#37453587: Github links in PyPI project's pages do not work
 - BUG#37447394: Unable to escape a parameter marker (`%s`) used in a query that should not be treated as a parameter marker
 - BUG#37418436: Arbitrary File Read in MySQL Python Client library
+- BUG#37410052: Bad formatting of exceptions when connecting with Unix sockets
 - BUG#37399636: The C-extension has a memory leak when working with prepared statements
 - BUG#37275524: Exception is not interpreted properly on prepared statements when C extension is in use
 - BUG#36098290: mysql-connector-python is distributed without setup.py or pyproject.toml

mysql-connector-python/lib/mysql/connector/network.py

@@ -788,7 +788,7 @@ def open_connection(self) -> None:
 
         (self._family, socktype, proto, _, sockaddr) = addrinfo
 
-        # Instanciate the socket and connect
+        # Instantiate the socket and connect
         try:
             self.sock = socket.socket(self._family, socktype, proto)
             self.sock.settimeout(self._connection_timeout)
@@ -804,12 +804,8 @@ def open_connection(self) -> None:
             ) from err
         except IOError as err:
             raise InterfaceError(
-                errno=2002,
-                values=(
-                    self.server_host,
-                    self.server_port,
-                    _strioerror(err),
-                ),
+                errno=2003,
+                values=(self.server_host, self.server_port, _strioerror(err)),
             ) from err
         except Exception as err:
-            raise OperationalError(str(err)) from err
+            raise InterfaceError(str(err)) from err

mysql-connector-python/tests/test_bugs.py

@@ -8973,3 +8973,32 @@ def test_bug37275524(self):
                         cur.execute(f"CREATE TABLE {self.table_name} (id INT PRIMARY KEY)")
                         cur.execute(f"INSERT INTO {self.table_name} (id) VALUES (1)")
                         cur.execute(f"INSERT INTO {self.table_name} (id) VALUES (1)")
+
+class BugOra37410052(tests.MySQLConnectorTests):
+    """BUG#37410052: Wrong exception message being shown when ConnectionRefusedError is raised
+    by the client
+
+    ConnectionRefusedError is not being correctly formatted when being raised by the
+    client while connecting with a MySQL server using pure-python implementation of
+    Connector/Python.
+
+    This patch fixes this issue by changing the error log message structure.
+    """
+
+    def test_incorrect_host_err_msg(self):
+        config = tests.get_mysql_config()
+        config["port"] = 4875
+        config["use_pure"] = True
+        config["unix_socket"] = None
+        cnx = MySQLConnection
+
+        self.assertRaises(errors.InterfaceError, cnx, **config)
+        try:
+            with cnx(**config) as _:
+                pass
+        except errors.InterfaceError as err:
+            self.assertNotIn(
+                "%-.100s",
+                str(err),
+                "Error message cannot contain unstructured bind address",
+            )