WL#15440 MySQL REST Service (MRS) - Umbrella WL

Andrzej Religa · dahlerlend · commit 3e83a7b5c951 · 2025-03-13T12:03:37.000+01:00
Post-push fix: adding a proper synchronization to db_object/modify_fields.inc

When the fields definitions are modified using this script the intention
is that this is an atomic change. There are several SQL statements there
so they should be wrapped inside a transaction so that MRS did not see
a partial change which leads to a random test failures.

Change-Id: I1313a2607060836c6c342354c5be699b25722973
diff --git a/mysql-test/suite/router/include/mrs/db_object/modify_fields.inc b/mysql-test/suite/router/include/mrs/db_object/modify_fields.inc
@@ -21,6 +21,8 @@ if (!$mrs_modify_fields)
 let $_columns=$mrs_modify_columns;
 let $_fileds=$mrs_modify_fields;
 
+START TRANSACTION;
+
 while($_columns)
 {
 
@@ -41,6 +43,8 @@ while($_columns)
      WHERE db_column->>"\$.name"="$_column_element";
 }
 
+COMMIT;
+
 --enable_query_log
 --enable_result_log
 

Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,8 @@ if (!$mrs_modify_fields)`
`21`	`21`	`let $_columns=$mrs_modify_columns;`
`22`	`22`	`let $_fileds=$mrs_modify_fields;`
`23`	`23`
	`24`	`+START TRANSACTION;`
	`25`	`+`
`24`	`26`	`while($_columns)`
`25`	`27`	`{`
`26`	`28`
`@@ -41,6 +43,8 @@ while($_columns)`
`41`	`43`	`WHERE db_column->>"\$.name"="$_column_element";`
`42`	`44`	`}`
`43`	`45`
	`46`	`+COMMIT;`
	`47`	`+`
`44`	`48`	`--enable_query_log`
`45`	`49`	`--enable_result_log`
`46`	`50`