BUG#37672626 crash at startup after config-change in jit_executor

rennox · dahlerlend · commit 830fac7049f9 · 2025-03-14T11:09:21.000+01:00
When a max ram usage is defined in the configuration, it will be
determined how many ram per JavaScript context will be assigned.

When starting up, since no contexts have been started, this leads
to a zero division, causing the crash in linux.

This patch fixes the logic so the calculation is done only if there
are active contexts.

Change-Id: Ib1169486f3f76e38a9e987073325912dc9fe2c1b
diff --git a/router/src/jit_executor/src/jit_executor_component.cc b/router/src/jit_executor/src/jit_executor_component.cc
@@ -146,7 +146,9 @@ void JitExecutorComponent::update_active_contexts(
   }
 
   // Now updates the memory limit for each active handler and starts it
-  if (m_global_config.maximum_ram_size.has_value()) {
+  // Total pool is verified here as it could be 0, meaning, no active context
+  // handlers will be left after this update
+  if (total_pool != 0 && m_global_config.maximum_ram_size.has_value()) {
     uint64_t mem_per_pool_item = *m_global_config.maximum_ram_size / total_pool;
 
     for (const auto &it : candidate_context_handlers) {

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,9 @@ void JitExecutorComponent::update_active_contexts(`
`146`	`146`	`}`
`147`	`147`
`148`	`148`	`// Now updates the memory limit for each active handler and starts it`
`149`		`- if (m_global_config.maximum_ram_size.has_value()) {`
	`149`	`+ // Total pool is verified here as it could be 0, meaning, no active context`
	`150`	`+ // handlers will be left after this update`
	`151`	`+ if (total_pool != 0 && m_global_config.maximum_ram_size.has_value()) {`
`150`	`152`	`uint64_t mem_per_pool_item = *m_global_config.maximum_ram_size / total_pool;`
`151`	`153`
`152`	`154`	`for (const auto &it : candidate_context_handlers) {`