Fix allocation errors receiving many result rows

fixes #918
fixes #1265
fixes #1324
fixes #1415

Author: dougwilson

Changes.md

@@ -10,6 +10,7 @@ you spot any mistakes.
 * Add `POOL_CONNLIMIT` code to "No connections available." error #1332
 * Bind underlying connections in pool to same domain as pool #1242
 * Bind underlying socket to same domain as connection #1243
+* Fix allocation errors receiving many result rows #918 #1265 #1324 #1415
 * Fix edge cases constructing long stack traces #1387
 * Fix handshake inactivity timeout on Node.js v4.2.0 #1223 #1236 #1239 #1240 #1241 #1252
 * Fix Query stream to emit close after ending #1349 #1350

lib/protocol/Parser.js

@@ -9,6 +9,7 @@ function Parser(options) {
 
   this._supportBigNumbers = options.config && options.config.supportBigNumbers;
   this._buffer            = new Buffer(0);
+  this._nextBuffers       = [];
   this._longPacketBuffers = [];
   this._offset            = 0;
   this._packetEnd         = null;
@@ -21,12 +22,12 @@ function Parser(options) {
   this._paused            = false;
 }
 
-Parser.prototype.write = function(buffer) {
-  this.append(buffer);
+Parser.prototype.write = function write(chunk) {
+  this._nextBuffers.push(chunk);
 
   while (!this._paused) {
     if (!this._packetHeader) {
-      if (this._bytesRemaining() < 4) {
+      if (!this._combineNextBuffers(4)) {
         break;
       }
 
@@ -50,7 +51,7 @@ Parser.prototype.write = function(buffer) {
       this.incrementPacketNumber();
     }
 
-    if (this._bytesRemaining() < this._packetHeader.length) {
+    if (!this._combineNextBuffers(this._packetHeader.length)) {
       break;
     }
 
@@ -141,7 +142,7 @@ Parser.prototype.peak = function() {
   return this._buffer[this._offset];
 };
 
-Parser.prototype.parseUnsignedNumber = function(bytes) {
+Parser.prototype.parseUnsignedNumber = function parseUnsignedNumber(bytes) {
   if (bytes === 1) {
     return this._buffer[this._offset++];
   }
@@ -362,10 +363,6 @@ Parser.prototype.reachedPacketEnd = function() {
   return this._offset === this._packetEnd;
 };
 
-Parser.prototype._bytesRemaining = function() {
-  return this._buffer.length - this._offset;
-};
-
 Parser.prototype.incrementPacketNumber = function() {
   var currentPacketNumber = this._nextPacketNumber;
   this._nextPacketNumber = (this._nextPacketNumber + 1) % 256;
@@ -383,7 +380,23 @@ Parser.prototype.packetLength = function() {
   }, this._packetHeader.length);
 };
 
-Parser.prototype._combineLongPacketBuffers = function() {
+Parser.prototype._combineNextBuffers = function _combineNextBuffers(bytes) {
+  if ((this._buffer.length - this._offset) >= bytes) {
+    return true;
+  }
+
+  if (!this._nextBuffers.length) {
+    return false;
+  }
+
+  while (this._nextBuffers.length && (this._buffer.length - this._offset) < bytes) {
+    this.append(this._nextBuffers.shift());
+  }
+
+  return (this._buffer.length - this._offset) >= bytes;
+};
+
+Parser.prototype._combineLongPacketBuffers = function _combineLongPacketBuffers() {
   if (!this._longPacketBuffers.length) {
     return;
   }
@@ -392,7 +405,7 @@ Parser.prototype._combineLongPacketBuffers = function() {
 
   var length = this._longPacketBuffers.reduce(function(length, buffer) {
     return length + buffer.length;
-  }, this._bytesRemaining());
+  }, (this._buffer.length - this._offset));
 
   var combinedBuffer = new Buffer(length);