lint: enforce consistent quote style

Author: dougwilson

.eslintrc

@@ -31,6 +31,7 @@
     "no-trailing-spaces": 2,
     "no-unexpected-multiline": 2,
     "no-unreachable": 2,
+    "quotes": [2, "single", { "avoidEscape": true, "allowTemplateLiterals": true }],
     "semi": [2, "always"],
     "use-isnan": 2,
     "valid-jsdoc": 2,

lib/Connection.js

@@ -18,7 +18,7 @@ function Connection(options) {
   this._socket        = options.socket;
   this._protocol      = new Protocol({config: this.config, connection: this});
   this._connectCalled = false;
-  this.state          = "disconnected";
+  this.state          = 'disconnected';
   this.threadId       = null;
 }
 
@@ -256,7 +256,7 @@ Connection.prototype.end = function end(options, callback) {
 };
 
 Connection.prototype.destroy = function() {
-  this.state = "disconnected";
+  this.state = 'disconnected';
   this._implyConnect();
   this._socket.destroy();
   this._protocol.destroy();
@@ -281,7 +281,7 @@ Connection.prototype.escapeId = function escapeId(value) {
 };
 
 Connection.prototype.format = function(sql, values) {
-  if (typeof this.config.queryFormat == "function") {
+  if (typeof this.config.queryFormat == 'function') {
     return this.config.queryFormat.call(this, sql, values, this.config.timezone);
   }
   return SqlString.format(sql, values, this.config.stringifyObjects, this.config.timezone);
@@ -435,7 +435,7 @@ Connection.prototype._handleNetworkError = function(err) {
 };
 
 Connection.prototype._handleProtocolError = function(err) {
-  this.state = "protocol_error";
+  this.state = 'protocol_error';
   this.emit('error', err);
 };
 
@@ -444,17 +444,17 @@ Connection.prototype._handleProtocolDrain = function() {
 };
 
 Connection.prototype._handleProtocolConnect = function() {
-  this.state = "connected";
+  this.state = 'connected';
   this.emit('connect');
 };
 
 Connection.prototype._handleProtocolHandshake = function _handleProtocolHandshake(packet) {
-  this.state    = "authenticated";
+  this.state    = 'authenticated';
   this.threadId = packet.threadId;
 };
 
 Connection.prototype._handleProtocolEnd = function(err) {
-  this.state = "disconnected";
+  this.state = 'disconnected';
   this.emit('end', err);
 };
 

lib/ConnectionConfig.js

@@ -38,11 +38,11 @@ function ConnectionConfig(options) {
     ? true
     : options.typeCast;
 
-  if (this.timezone[0] == " ") {
+  if (this.timezone[0] == ' ') {
     // "+" is a url encoded char for space so it
     // gets translated to space when giving a
     // connection string..
-    this.timezone = "+" + this.timezone.substr(1);
+    this.timezone = '+' + this.timezone.substr(1);
   }
 
   if (this.ssl) {

lib/Pool.js

@@ -159,7 +159,7 @@ Pool.prototype.releaseConnection = function releaseConnection(connection) {
 Pool.prototype.end = function (cb) {
   this._closed = true;
 
-  if (typeof cb != "function") {
+  if (typeof cb != 'function') {
     cb = function (err) {
       if (err) throw err;
     };

lib/protocol/Auth.js

@@ -26,7 +26,7 @@ Auth.token = function(password, scramble) {
   }
 
   // password must be in binary format, not utf8
-  var stage1 = sha1((new Buffer(password, "utf8")).toString("binary"));
+  var stage1 = sha1((new Buffer(password, 'utf8')).toString('binary'));
   var stage2 = sha1(stage1);
   var stage3 = sha1(scramble.toString('binary') + stage2);
   return xor(stage3, stage1);

lib/protocol/Protocol.js

@@ -430,7 +430,7 @@ Protocol.prototype.destroy = function() {
   this._destroyed = true;
   this._parser.pause();
 
-  if (this._connection.state !== "disconnected") {
+  if (this._connection.state !== 'disconnected') {
     if(!this._ended) {
       this.end();
     }

lib/protocol/packets/HandshakeInitializationPacket.js

@@ -89,10 +89,10 @@ HandshakeInitializationPacket.prototype.write = function(writer) {
 
 HandshakeInitializationPacket.prototype.scrambleBuff = function() {
   var buffer = new Buffer(this.scrambleBuff1.length +
-                          (typeof this.scrambleBuff2 != "undefined" ? this.scrambleBuff2.length : 0));
+                          (typeof this.scrambleBuff2 != 'undefined' ? this.scrambleBuff2.length : 0));
 
   this.scrambleBuff1.copy(buffer);
-  if (typeof this.scrambleBuff2 != "undefined") {
+  if (typeof this.scrambleBuff2 != 'undefined') {
     this.scrambleBuff2.copy(buffer, this.scrambleBuff1.length);
   }
 

lib/protocol/packets/RowDataPacket.js

@@ -29,7 +29,7 @@ function parse(parser, fieldPackets, typeCast, nestTables, connection) {
     var fieldPacket = fieldPackets[i];
     var value;
 
-    if (typeof typeCast == "function") {
+    if (typeof typeCast == 'function') {
       value = typeCast.apply(connection, [ new Field({ packet: fieldPacket, parser: parser }), next ]);
     } else {
       value = (typeCast)
@@ -39,7 +39,7 @@ function parse(parser, fieldPackets, typeCast, nestTables, connection) {
           : parser.parseLengthCodedString() );
     }
 
-    if (typeof nestTables == "string" && nestTables.length) {
+    if (typeof nestTables == 'string' && nestTables.length) {
       this[fieldPacket.table + nestTables + fieldPacket.name] = value;
     } else if (nestTables) {
       this[fieldPacket.table] = this[fieldPacket.table] || {};
@@ -93,12 +93,12 @@ function typeCast(field, parser, timeZone, supportBigNumbers, bigNumberStrings,
     case Types.FLOAT:
     case Types.DOUBLE:
       numberString = parser.parseLengthCodedString();
-      return (numberString === null || (field.zeroFill && numberString[0] == "0"))
+      return (numberString === null || (field.zeroFill && numberString[0] == '0'))
         ? numberString : Number(numberString);
     case Types.NEWDECIMAL:
     case Types.LONGLONG:
       numberString = parser.parseLengthCodedString();
-      return (numberString === null || (field.zeroFill && numberString[0] == "0"))
+      return (numberString === null || (field.zeroFill && numberString[0] == '0'))
         ? numberString
         : ((supportBigNumbers && (bigNumberStrings || (Number(numberString) >= IEEE_754_BINARY_64_PRECISION) || Number(numberString) <= -IEEE_754_BINARY_64_PRECISION))
           ? numberString

test/integration/connection/test-timezones.js

@@ -73,7 +73,7 @@ function testNextDate(connection) {
   } else if (offset === 'local') {
     timezone = offset;
   } else {
-    timezone = (offset < 0 ? "-" : "+") + pad2(Math.abs(offset)) + ":00";
+    timezone = (offset < 0 ? '-' : '+') + pad2(Math.abs(offset)) + ':00';
   }
 
   var dt = new Date(day);
@@ -134,5 +134,5 @@ function testNextDate(connection) {
 }
 
 function pad2(v) {
-  return (v < 10 ? "0" : "") + v;
+  return (v < 10 ? '0' : '') + v;
 }

test/integration/connection/test-type-cast-query.js

@@ -6,7 +6,7 @@ common.getTestConnection({typeCast: true}, function (err, connection) {
   assert.ifError(err);
 
   var options = {
-    sql      : "SELECT NOW() as date, POINT(1.2,-3.4) as point",
+    sql      : 'SELECT NOW() as date, POINT(1.2,-3.4) as point',
     typeCast : false
   };