lint: remove undefined variables

Author: dougwilson

.eslintrc

@@ -33,6 +33,7 @@
     "no-regex-spaces": 2,
     "no-sparse-arrays": 2,
     "no-trailing-spaces": 2,
+    "no-undef": 2,
     "no-unexpected-multiline": 2,
     "no-unreachable": 2,
     "no-unused-vars": 2,

test/unit/pool-cluster/test-connection-order-fatal.js

@@ -24,16 +24,12 @@ server.listen(common.fakeServerPort, function(err) {
   pool.getConnection(function (err, connection) {
     assert.ifError(err);
     assert.strictEqual(connection._clusterId, 'SLAVE2');
-
-    conn1 = connection;
     done();
   });
 
   pool.getConnection(function (err, connection) {
     assert.ifError(err);
     assert.strictEqual(connection._clusterId, 'SLAVE2');
-
-    conn2 = connection;
     done();
   });
 });

test/unit/pool/test-acquire-timeout-existing.js

@@ -43,7 +43,6 @@ server.listen(common.fakeServerPort, function (err) {
 });
 
 server.on('connection', function(incomingConnection) {
-  serverConn = incomingConnection;
   incomingConnection.handshake({
     threadId: ++tid
   });

test/unit/pool/test-connection-bad.js

@@ -42,7 +42,6 @@ server.listen(common.fakeServerPort, function(err){
 });
 
 server.on('connection', function(incomingConnection) {
-  serverConn = incomingConnection;
   incomingConnection.handshake({
     threadId: ++tid
   });

test/unit/pool/test-protocol-stray-packet.js

@@ -3,7 +3,8 @@ var common     = require('../../common');
 var pool       = common.createPool({port: common.fakeServerPort});
 var server     = common.createFakeServer();
 
-var connCount = 0;
+var connCount  = 0;
+var connection = null;
 
 server.listen(common.fakeServerPort, function (err) {
   assert.ifError(err);
@@ -18,10 +19,12 @@ server.listen(common.fakeServerPort, function (err) {
   pool.query('SELECT 1', function (err) {
     assert.ifError(err);
 
-    pool.getConnection(function (err) {
+    pool.getConnection(function (err, conn) {
       assert.ifError(err);
       assert.equal(connCount, 2);
 
+      connection = conn;
+
       pool.end(function (err) {
         assert.ifError(err);
         server.destroy();