lint: remove unused variables

Author: dougwilson

.eslintrc

@@ -32,6 +32,7 @@
     "no-trailing-spaces": 2,
     "no-unexpected-multiline": 2,
     "no-unreachable": 2,
+    "no-unused-vars": 2,
     "quotes": [2, "single", { "avoidEscape": true, "allowTemplateLiterals": true }],
     "semi": [2, "always"],
     "use-isnan": 2,

benchmark/parse-100k-blog-rows.js

@@ -11,14 +11,14 @@ var options = {
 };
 
 console.error('Config:', options);
+run();
 
 function createBuffers() {
   var parser = new Parser();
 
   process.stderr.write('Creating row buffers ... ');
 
   var number = 1;
-  var id     = 0;
   var start  = Date.now();
 
   var buffers = [
@@ -53,7 +53,7 @@ function createPacketBuffer(parser, packet) {
   return writer.toBuffer(parser);
 }
 
-function createRowDataPacketBuffer(parser, number) {
+function createRowDataPacketBuffer(parser) {
   var writer = new PacketWriter();
 
   writer.writeLengthCodedString(parser._nextPacketNumber);

benchmark/select-100k-blog-rows.js

@@ -5,7 +5,7 @@ var rowsPerRun = 100000;
 client.connect(function(err) {
   if (err) throw err;
 
-  client.query('USE node_mysql_test', function(err, results) {
+  client.query('USE node_mysql_test', function(err) {
     if (err) throw err;
 
     selectRows();

lib/Connection.js

@@ -105,7 +105,7 @@ Connection.prototype.connect = function connect(options, callback) {
     this._protocol.on('end', function() {
       connection._socket.end();
     });
-    this._socket.on('end', function(err) {
+    this._socket.on('end', function() {
       connection._protocol.end();
     });
 

lib/Pool.js

@@ -119,7 +119,6 @@ Pool.prototype.acquireConnection = function acquireConnection(connection, cb) {
 };
 
 Pool.prototype.releaseConnection = function releaseConnection(connection) {
-  var pool = this;
 
   if (this._acquiringConnections.indexOf(connection) !== -1) {
     // connection is being acquired

lib/PoolConnection.js

@@ -27,7 +27,6 @@ function PoolConnection(pool, options) {
 
 PoolConnection.prototype.release = function release() {
   var pool = this._pool;
-  var connection = this;
 
   if (!pool || pool._closed) {
     return undefined;

lib/protocol/packets/ComPingPacket.js

@@ -1,5 +1,5 @@
 module.exports = ComPingPacket;
-function ComPingPacket(sql) {
+function ComPingPacket() {
   this.command = 0x0e;
 }
 

lib/protocol/packets/ComQuitPacket.js

@@ -1,5 +1,5 @@
 module.exports = ComQuitPacket;
-function ComQuitPacket(sql) {
+function ComQuitPacket() {
   this.command = 0x01;
 }
 

lib/protocol/packets/ComStatisticsPacket.js

@@ -1,5 +1,5 @@
 module.exports = ComStatisticsPacket;
-function ComStatisticsPacket(sql) {
+function ComStatisticsPacket() {
   this.command = 0x09;
 }
 

lib/protocol/packets/EmptyPacket.js

@@ -2,5 +2,5 @@ module.exports = EmptyPacket;
 function EmptyPacket() {
 }
 
-EmptyPacket.prototype.write = function(writer) {
+EmptyPacket.prototype.write = function write() {
 };