Apply recommendations from gemini to user_kustomization

Author: vsalomaki

modules/user_kustomizations/main.tf

@@ -42,6 +42,14 @@ resource "null_resource" "kustomization_user_deploy" {
     inline = [
       <<-EOT
       #!/bin/bash
+      set -e
+
+      function cleanup {
+        echo "Cleaning up ${local.base_destination_folder}..."
+        rm -rf ${local.base_destination_folder}
+      }
+      trap cleanup EXIT
+
       for dest_folder in ${join(" ", local.sorted_kustomization_destination_folders)}; do
         if [ -d "$dest_folder" ]; then
           echo "Running pre-install script from $dest_folder"
@@ -58,8 +66,6 @@ resource "null_resource" "kustomization_user_deploy" {
           /bin/bash "$dest_folder/postinstall.sh"
         fi
       done
-      echo "Cleaning up ${local.base_destination_folder}..."
-      rm -rf ${local.base_destination_folder}/*
       EOT
     ]
   }

modules/user_kustomizations/variables.tf

@@ -26,7 +26,7 @@ variable "kustomizations_map" {
   validation {
     condition = alltrue([
       for key in keys(var.kustomizations_map) :
-      tonumber(key) > 0 && floor(tonumber(key)) == tonumber(key) && can(regex("^[0-9]+$", key))
+      can(regex("^[0-9]+$", key)) && tonumber(key) > 0
     ])
     error_message = "All keys in kustomizations_map must be numeric strings (e.g., '1', '2')."
   }