⚒ update eslintrc (#53)

mysticatea · web-flow · commit 729c0169b2eb · 2020-11-29T17:09:20.000+09:00
diff --git a/.eslintignore b/.eslintignore
diff --git a/.eslintrc.yml b/.eslintrc.yml
@@ -1,18 +1,17 @@
 extends:
-  - plugin:@mysticatea/es2015
+  - plugin:@mysticatea/es2020
   - plugin:@mysticatea/+eslint-plugin
 
+ignorePatterns:
+  - /.nyc_output
+  - /coverage
+  - /node_modules
+  - "!.vuepress"
+  - /docs/.vuepress/dist
+
 overrides:
-  - files: lib/rules/*.js
+  - files: lib/rules/**/*.js
     rules:
       "@mysticatea/eslint-plugin/require-meta-docs-url":
         - error
         - pattern: http://mysticatea.github.io/eslint-plugin-es/rules/{{name}}.html
-
-  - files: scripts/*.js
-    rules:
-      require-jsdoc: off
-
-  - files: "*.vue"
-    parserOptions:
-      parser: babel-eslint
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -58,7 +58,7 @@ jobs:
             os: ubuntu-latest
           # On the minimum supported ESLint/Node.js version
           - eslint: 4
-            node: 8.10
+            node: "8.10"
             os: ubuntu-latest
 
     runs-on: ${{ matrix.os }}
diff --git a/docs/.vuepress/components/eslint-playground.vue b/docs/.vuepress/components/eslint-playground.vue
@@ -83,7 +83,7 @@ export default {
         cookedCode() {
             return (this.code || "").replace(
                 /&#x([0-9a-zA-Z]+);/gu,
-                (_, codePoint) => String.fromCodePoint(parseInt(codePoint, 16))
+                (_, codePoint) => String.fromCodePoint(parseInt(codePoint, 16)),
             )
         },
     },
diff --git a/docs/.vuepress/config.js b/docs/.vuepress/config.js
@@ -26,7 +26,10 @@ module.exports = {
         docsBranch: "master",
         editLinks: true,
 
-        nav: [{ text: "Guide", link: "/" }, { text: "Rules", link: "/rules/" }],
+        nav: [
+            { text: "Guide", link: "/" },
+            { text: "Rules", link: "/rules/" },
+        ],
 
         sidebarDepth: 0,
         sidebar: [
diff --git a/lib/rules/no-accessor-properties.js b/lib/rules/no-accessor-properties.js
@@ -23,7 +23,7 @@ module.exports = {
     create(context) {
         return {
             "Property[kind='get'], Property[kind='set'], MethodDefinition[kind='get'], MethodDefinition[kind='set']"(
-                node
+                node,
             ) {
                 context.report({ node, messageId: "forbidden" })
             },
diff --git a/lib/rules/no-arrow-functions.js b/lib/rules/no-arrow-functions.js
@@ -36,17 +36,17 @@ module.exports = {
             const paramText = params.length
                 ? sourceCode.text.slice(
                       params[0].range[0],
-                      params[params.length - 1].range[1]
+                      params[params.length - 1].range[1],
                   )
                 : ""
 
             const arrowToken = sourceCode.getTokenBefore(
                 node.body,
-                isArrowToken
+                isArrowToken,
             )
             const preText = sourceCode.text.slice(
                 arrowToken.range[1],
-                node.body.range[0]
+                node.body.range[0],
             )
             const bodyText = sourceCode.text
                 .slice(arrowToken.range[1], node.range[1])
@@ -96,7 +96,7 @@ module.exports = {
                     }
                     return fixer.replaceText(
                         node,
-                        toFunctionExpression(node, hasThis)
+                        toFunctionExpression(node, hasThis),
                     )
                 },
             })
diff --git a/lib/rules/no-block-scoped-variables.js b/lib/rules/no-block-scoped-variables.js
@@ -23,7 +23,7 @@ module.exports = {
     create(context) {
         return {
             "VariableDeclaration[kind='const'], VariableDeclaration[kind='let']"(
-                node
+                node,
             ) {
                 context.report({ node, messageId: "forbidden" })
             },
diff --git a/lib/rules/no-destructuring.js b/lib/rules/no-destructuring.js
@@ -23,7 +23,7 @@ module.exports = {
     create(context) {
         return {
             ":matches(:function, AssignmentExpression, VariableDeclarator, :function > :matches(AssignmentPattern, RestElement), ForInStatement, ForOfStatement) > :matches(ArrayPattern, ObjectPattern)"(
-                node
+                node,
             ) {
                 context.report({ node, messageId: "forbidden" })
             },
diff --git a/lib/rules/no-exponential-operators.js b/lib/rules/no-exponential-operators.js
@@ -23,7 +23,7 @@ module.exports = {
     create(context) {
         return {
             "AssignmentExpression[operator='**='], BinaryExpression[operator='**']"(
-                node
+                node,
             ) {
                 context.report({ node, messageId: "forbidden" })
             },
diff --git a/lib/rules/no-json-superset.js b/lib/rules/no-json-superset.js
@@ -44,7 +44,7 @@ module.exports = {
                         fix(fixer) {
                             return fixer.replaceTextRange(
                                 [offset + index, offset + index + 1],
-                                `\\u${code}`
+                                `\\u${code}`,
                             )
                         },
                     })
diff --git a/lib/rules/no-logical-assignment-operators.js b/lib/rules/no-logical-assignment-operators.js
@@ -42,13 +42,13 @@ module.exports = {
                             fixer.replaceText(operatorToken, newOperator),
                             fixer.insertTextAfter(
                                 operatorToken,
-                                ` ${varText} ${biOperator}`
+                                ` ${varText} ${biOperator}`,
                             ),
                         ]
                         if (!utils.isParenthesized(node.right, sourceCode)) {
                             results.push(
                                 fixer.insertTextBefore(node.right, "("),
-                                fixer.insertTextAfter(node.right, ")")
+                                fixer.insertTextAfter(node.right, ")"),
                             )
                         }
                         return results
diff --git a/lib/rules/no-modules.js b/lib/rules/no-modules.js
@@ -23,7 +23,7 @@ module.exports = {
     create(context) {
         return {
             "ExportAllDeclaration, ExportDefaultDeclaration, ExportNamedDeclaration, ImportDeclaration"(
-                node
+                node,
             ) {
                 context.report({ node, messageId: "forbidden" })
             },
diff --git a/lib/rules/no-numeric-separators.js b/lib/rules/no-numeric-separators.js
@@ -42,7 +42,7 @@ module.exports = {
                         fix: fixer =>
                             fixer.replaceText(
                                 node,
-                                removeNumericSeparators(node.raw)
+                                removeNumericSeparators(node.raw),
                             ),
                     })
                 }
diff --git a/lib/rules/no-optional-chaining.js b/lib/rules/no-optional-chaining.js
@@ -42,7 +42,7 @@ module.exports = {
                 context.report({
                     node: sourceCode.getTokenAfter(
                         node.callee,
-                        isQuestionDotToken
+                        isQuestionDotToken,
                     ),
                     messageId: "forbidden",
                 })
@@ -51,7 +51,7 @@ module.exports = {
                 context.report({
                     node: sourceCode.getTokenAfter(
                         node.object,
-                        isQuestionDotToken
+                        isQuestionDotToken,
                     ),
                     messageId: "forbidden",
                 })
diff --git a/lib/rules/no-property-shorthands.js b/lib/rules/no-property-shorthands.js
@@ -40,7 +40,7 @@ module.exports = {
                 : sourceCode.getLastToken(node.key)
             const keyText = sourceCode.text.slice(
                 firstKeyToken.range[0],
-                lastKeyToken.range[1]
+                lastKeyToken.range[1],
             )
             let functionHeader = "function"
 
@@ -53,13 +53,13 @@ module.exports = {
 
             return fixer.replaceTextRange(
                 [node.range[0], lastKeyToken.range[1]],
-                `${keyText}: ${functionHeader}`
+                `${keyText}: ${functionHeader}`,
             )
         }
 
         return {
             "ObjectExpression > :matches(Property[method=true], Property[shorthand=true])"(
-                node
+                node,
             ) {
                 context.report({
                     node,
@@ -69,7 +69,7 @@ module.exports = {
                         : fixer =>
                               fixer.insertTextAfter(
                                   node.key,
-                                  `: ${node.key.name}`
+                                  `: ${node.key.name}`,
                               ),
                 })
             },
diff --git a/lib/rules/no-spread-elements.js b/lib/rules/no-spread-elements.js
@@ -23,7 +23,7 @@ module.exports = {
     create(context) {
         return {
             ":matches(ArrayExpression, CallExpression, NewExpression) > SpreadElement"(
-                node
+                node,
             ) {
                 context.report({ node, messageId: "forbidden" })
             },
diff --git a/lib/rules/no-template-literals.js b/lib/rules/no-template-literals.js
@@ -62,7 +62,7 @@ module.exports = {
         const sourceCode = context.getSourceCode()
         return {
             "TaggedTemplateExpression, :not(TaggedTemplateExpression) > TemplateLiteral"(
-                node
+                node,
             ) {
                 context.report({
                     node,
@@ -74,8 +74,8 @@ module.exports = {
                                       node,
                                       templateLiteralToStringConcat(
                                           node,
-                                          sourceCode
-                                      )
+                                          sourceCode,
+                                      ),
                                   )
                             : undefined,
                 })
diff --git a/lib/rules/no-trailing-commas.js b/lib/rules/no-trailing-commas.js
@@ -27,7 +27,7 @@ module.exports = {
         const sourceCode = context.getSourceCode()
         return {
             "ArrayExpression, ArrayPattern, ObjectExpression, ObjectPattern"(
-                node
+                node,
             ) {
                 const token = sourceCode.getLastToken(node, 1)
                 if (isCommaToken(token)) {
diff --git a/lib/rules/no-unicode-codepoint-escapes.js b/lib/rules/no-unicode-codepoint-escapes.js
@@ -6,7 +6,7 @@
 
 const { definePatternSearchGenerator } = require("../utils")
 const codePointEscapeSearchGenerator = definePatternSearchGenerator(
-    /\\u\{[0-9a-fA-F]+\}/gu
+    /\\u\{[0-9a-fA-F]+\}/gu,
 )
 
 /**
@@ -71,12 +71,12 @@ module.exports = {
                             const highSurrogate = (codePoint >> 10) + 0xd800
                             const lowSurrogate = (codePoint % 0x400) + 0xdc00
                             replacement = `${toHex(highSurrogate)}\\u${toHex(
-                                lowSurrogate
+                                lowSurrogate,
                             )}`
                         }
                         return fixer.replaceTextRange(
                             [range[0] + 2, range[1]],
-                            replacement
+                            replacement,
                         )
                     },
                 })
diff --git a/lib/utils.js b/lib/utils.js
@@ -64,7 +64,7 @@ module.exports = {
             {
                 type: "DeprecationWarning",
                 code: "ESLINT_PLUGIN_ES_LEGACY_CONFIG",
-            }
+            },
         )
     },
 }
diff --git a/package.json b/package.json
@@ -20,7 +20,6 @@
     "@mysticatea/eslint-plugin": "^13.0.0",
     "@vuepress/plugin-pwa": "^1.2.0",
     "acorn": "^7.1.0",
-    "babel-eslint": "^10.0.1",
     "codecov": "3.7.0",
     "eslint": "^7.10.0",
     "eslint4b": "^7.10.0",
diff --git a/scripts/new-rule.js b/scripts/new-rule.js
@@ -16,7 +16,7 @@ const logger = console
         process.exitCode = 1
         return
     }
-    if (!/^[\w-]+$/u.test(ruleId)) {
+    if (!/^(?:aggressive\/)?[a-z0-9-]+$/u.test(ruleId)) {
         logger.error("Invalid RuleID '%s'.", ruleId)
         process.exitCode = 1
         return
@@ -53,7 +53,7 @@ module.exports = {
         return {}
     },
 }
-`
+`,
     )
     fs.writeFileSync(
         testFile,
@@ -66,7 +66,7 @@ module.exports = {
 const RuleTester = require("../../tester")
 const rule = require("../../../lib/rules/${ruleId}.js")
 
-if (!RuleTester.isSupported(2020)) {
+if (!RuleTester.isSupported(2021)) {
     //eslint-disable-next-line no-console
     console.log("Skip the tests of ${ruleId}.")
     return
@@ -76,11 +76,12 @@ new RuleTester().run("${ruleId}", rule, {
     valid: [],
     invalid: [],
 })
-`
+`,
     )
     fs.writeFileSync(
         docFile,
-        `#  (es/${ruleId})
+        `# es/${ruleId}
+> 
 
 This rule reports ??? as errors.
 
@@ -91,7 +92,7 @@ This rule reports ??? as errors.
 <eslint-playground type="bad" code="/*eslint es/${ruleId}: error */
 
 " />
-`
+`,
     )
 
     cp.execSync(`code "${ruleFile}"`)
diff --git a/scripts/rules.js b/scripts/rules.js
diff --git a/scripts/update-docs-readme.js b/scripts/update-docs-readme.js
diff --git a/scripts/update-docs-rules.js b/scripts/update-docs-rules.js
diff --git a/scripts/update-lib-configs.js b/scripts/update-lib-configs.js
diff --git a/scripts/update-lib-index.js b/scripts/update-lib-index.js
diff --git a/tests/tester.js b/tests/tester.js

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ export default {`
`83`	`83`	`cookedCode() {`
`84`	`84`	`return (this.code \|\| "").replace(`
`85`	`85`	`/&#x([0-9a-zA-Z]+);/gu,`
`86`		`- (_, codePoint) => String.fromCodePoint(parseInt(codePoint, 16))`
	`86`	`+ (_, codePoint) => String.fromCodePoint(parseInt(codePoint, 16)),`
`87`	`87`	`)`
`88`	`88`	`},`
`89`	`89`	`},`
Original file line number	Diff line number	Diff line change
`@@ -36,17 +36,17 @@ module.exports = {`
`36`	`36`	`const paramText = params.length`
`37`	`37`	`? sourceCode.text.slice(`
`38`	`38`	`params[0].range[0],`
`39`		`- params[params.length - 1].range[1]`
	`39`	`+ params[params.length - 1].range[1],`
`40`	`40`	`)`
`41`	`41`	`: ""`
`42`	`42`
`43`	`43`	`const arrowToken = sourceCode.getTokenBefore(`
`44`	`44`	`node.body,`
`45`		`- isArrowToken`
	`45`	`+ isArrowToken,`
`46`	`46`	`)`
`47`	`47`	`const preText = sourceCode.text.slice(`
`48`	`48`	`arrowToken.range[1],`
`49`		`- node.body.range[0]`
	`49`	`+ node.body.range[0],`
`50`	`50`	`)`
`51`	`51`	`const bodyText = sourceCode.text`
`52`	`52`	`.slice(arrowToken.range[1], node.range[1])`
`@@ -96,7 +96,7 @@ module.exports = {`
`96`	`96`	`}`
`97`	`97`	`return fixer.replaceText(`
`98`	`98`	`node,`
`99`		`- toFunctionExpression(node, hasThis)`
	`99`	`+ toFunctionExpression(node, hasThis),`
`100`	`100`	`)`
`101`	`101`	`},`
`102`	`102`	`})`