New: no-unlimited-disable rule

Author: mysticatea

docs/rules/no-unlimited-disable.md

@@ -0,0 +1,22 @@
+# disallows `eslint-disable` comments without rule names (eslint-comments/no-unlimited-disable)
+
+Disable-comments disable all rules by default. This may cause to overlook some ESLint warnings unintentionally.
+So you should specify the rules to disable accurately.
+
+## Rule Details
+
+Examples of **incorrect** code for this rule:
+
+```js
+/*eslint eslint-comments/no-unlimited-disable: error */
+
+var foo; //eslint-disable-line
+```
+
+Examples of **correct** code for this rule:
+
+```js
+/*eslint eslint-comments/no-unlimited-disable: error */
+
+var foo; //eslint-disable-line no-unused-vars
+```

lib/rules/no-unlimited-disable.js

@@ -0,0 +1,61 @@
+/**
+ * @author Toru Nagashima
+ * @copyright 2016 Toru Nagashima. All rights reserved.
+ * See LICENSE file in root directory for full license.
+ */
+"use strict"
+
+//------------------------------------------------------------------------------
+// Requirements
+//------------------------------------------------------------------------------
+
+const utils = require("../utils")
+
+//------------------------------------------------------------------------------
+// Helpers
+//------------------------------------------------------------------------------
+
+const BLOCK_COMMENT_DIRECTIVE = /^\s*(eslint-disable)\s*(\S)?/
+const LINE_COMMENT_DIRECTIVE = /^\s*(eslint-disable(?:-next)?-line)\s*(\S)?/
+const MESSAGE = "Unexpected unlimited '{{kind}}' comment. Specify some rule names to disable."
+
+//------------------------------------------------------------------------------
+// Rule Definition
+//------------------------------------------------------------------------------
+
+module.exports = {
+    meta: {
+        docs: {
+            description: "disallows `eslint-disable` comments without rule names",
+            category: "Best Practices",
+        },
+        fixable: false,
+        schema: [],
+    },
+
+    create(context) {
+        return {
+            BlockComment(token) {
+                const m = BLOCK_COMMENT_DIRECTIVE.exec(token.value)
+                if (m && !m[2]) {
+                    context.report({
+                        loc: utils.toForceLocation(token.loc),
+                        message: MESSAGE,
+                        data: {kind: m[1]},
+                    })
+                }
+            },
+
+            LineComment(token) {
+                const m = LINE_COMMENT_DIRECTIVE.exec(token.value)
+                if (m && !m[2]) {
+                    context.report({
+                        loc: utils.toForceLocation(token.loc),
+                        message: MESSAGE,
+                        data: {kind: m[1]},
+                    })
+                }
+            },
+        }
+    },
+}

tests/lib/rules/no-unlimited-disable.js

@@ -0,0 +1,59 @@
+/**
+ * @author Toru Nagashima
+ * @copyright 2016 Toru Nagashima. All rights reserved.
+ * See LICENSE file in root directory for full license.
+ */
+"use strict"
+
+//------------------------------------------------------------------------------
+// Requirements
+//------------------------------------------------------------------------------
+
+const RuleTester = require("eslint").RuleTester
+const rule = require("../../../lib/rules/no-unlimited-disable")
+
+//------------------------------------------------------------------------------
+// Tests
+//------------------------------------------------------------------------------
+
+const tester = new RuleTester()
+
+tester.run("no-unlimited-disable", rule, {
+    valid: [
+        "/*eslint-enable*/",
+        "/*eslint-disable foo*/",
+        "//eslint-disable-line foo",
+        "//eslint-disable-next-line foo",
+        "var foo;\n//eslint-disable-line foo",
+    ],
+    invalid: [
+        {
+            code: "/*eslint-disable */",
+            errors: ["Unexpected unlimited 'eslint-disable' comment. Specify some rule names to disable."],
+        },
+        {
+            code: "/* eslint-disable */",
+            errors: ["Unexpected unlimited 'eslint-disable' comment. Specify some rule names to disable."],
+        },
+        {
+            code: "//eslint-disable-line",
+            errors: ["Unexpected unlimited 'eslint-disable-line' comment. Specify some rule names to disable."],
+        },
+        {
+            code: "// eslint-disable-line ",
+            errors: ["Unexpected unlimited 'eslint-disable-line' comment. Specify some rule names to disable."],
+        },
+        {
+            code: "//eslint-disable-next-line",
+            errors: ["Unexpected unlimited 'eslint-disable-next-line' comment. Specify some rule names to disable."],
+        },
+        {
+            code: "// eslint-disable-next-line ",
+            errors: ["Unexpected unlimited 'eslint-disable-next-line' comment. Specify some rule names to disable."],
+        },
+        {
+            code: "var foo;\n//eslint-disable-line",
+            errors: ["Unexpected unlimited 'eslint-disable-line' comment. Specify some rule names to disable."],
+        },
+    ],
+})