Merge branch 'patch-10' into eslint-7

# Conflicts:
#	.eslintrc.yml
#	package.json

Author: MichaelDeBoey

.eslintrc.yml

@@ -2,3 +2,18 @@ root: true
 extends:
     - plugin:@mysticatea/es2015
     - plugin:@mysticatea/+eslint-plugin
+
+overrides:
+  - files: [ "lib/utils.js", "scripts/*.js" ]
+    rules:
+      "@mysticatea/node/no-sync": off
+
+  - files:
+      [
+          "lib/configs.js",
+          "lib/foreign-rules/ts.js",
+          "lib/processors.js",
+          "lib/rules.js",
+      ]
+    rules:
+      "@mysticatea/node/global-require": off

lib/configs/+node.js

@@ -46,19 +46,30 @@ module.exports = {
         require: "readonly",
     },
     rules: {
+        "@mysticatea/node/callback-return": "error",
         "@mysticatea/node/exports-style": ["error", "module.exports"],
         "@mysticatea/node/file-extension-in-import": [
             "error",
             "always",
             { ".js": "never", ".ts": "never", ".tsx": "never" },
         ],
+        "@mysticatea/node/global-require": "error",
+        "@mysticatea/node/handle-callback-err": "error",
         "@mysticatea/node/no-callback-literal": "off",
         "@mysticatea/node/no-deprecated-api": "error",
         "@mysticatea/node/no-exports-assign": "error",
         "@mysticatea/node/no-extraneous-import": "error",
         "@mysticatea/node/no-extraneous-require": "error",
         "@mysticatea/node/no-missing-import": "error",
         "@mysticatea/node/no-missing-require": "error",
+        "@mysticatea/node/no-mixed-requires": "error",
+        "@mysticatea/node/no-new-require": "error",
+        "@mysticatea/node/no-path-concat": "error",
+        "@mysticatea/node/no-process-env": "error",
+        "@mysticatea/node/no-process-exit": "error",
+        "@mysticatea/node/no-restricted-import": "error",
+        "@mysticatea/node/no-restricted-require": "error",
+        "@mysticatea/node/no-sync": "error",
         "@mysticatea/node/no-unpublished-bin": "error",
         "@mysticatea/node/no-unpublished-import": "error",
         "@mysticatea/node/no-unpublished-require": "error",

package.json

@@ -17,7 +17,7 @@
     "@typescript-eslint/parser": "^4.33.0",
     "eslint-plugin-eslint-comments": "^3.2.0",
     "eslint-plugin-eslint-plugin": "^3.6.1",
-    "eslint-plugin-node": "^10.0.0",
+    "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-prettier": "^3.4.1",
     "eslint-plugin-vue": "^6.2.2",
     "prettier": "^2.7.1",

tests/lib/configs/_rules.js

@@ -9,6 +9,7 @@ const {
     ConfigArrayFactory,
 } = require("eslint/lib/cli-engine/config-array-factory")
 const Validator = require("eslint/lib/shared/config-validator")
+const { rules: removedRules } = require("eslint/conf/replacements.json")
 const { rules: PluginRulesIndex } = require("@mysticatea/eslint-plugin")
 
 const coreRules = new Linter().getRules()
@@ -25,9 +26,7 @@ const deprecatedRuleNames = new Set(
         .filter(([, rule]) => rule && rule.meta && rule.meta.deprecated)
         .map(([ruleId]) => ruleId)
 )
-const removedRuleNames = new Set(
-    Object.keys(require("eslint/conf/replacements.json").rules)
-)
+const removedRuleNames = new Set(Object.keys(removedRules))
 
 const configFactory = new ConfigArrayFactory()
 

tests/lib/configs/browser.js

@@ -5,11 +5,10 @@
  */
 "use strict"
 
+const config = require("../../../lib/configs/+browser")
 const Rules = require("./_rules")
 
 describe("'+browser.js'", () => {
-    const config = require("../../../lib/configs/+browser")
-
     it("should be a valid config.", () => {
         Rules.validateConfig(config, "+browser.js")
     })

tests/lib/configs/es2015.js

@@ -6,6 +6,7 @@
 "use strict"
 
 const assert = require("assert")
+const config = require("../../../lib/configs/es2015")
 const Rules = require("./_rules")
 
 /**
@@ -22,7 +23,6 @@ function isES6Rule(ruleId) {
 }
 
 describe("'es2015.js'", () => {
-    const config = require("../../../lib/configs/es2015")
     const configuredRules = Rules.getRulesOfConfig(config, "es2015")
     const existingRules = Rules.getCoreRuleNames()
 

tests/lib/configs/es2016.js

@@ -5,11 +5,10 @@
  */
 "use strict"
 
+const config = require("../../../lib/configs/es2016")
 const Rules = require("./_rules")
 
 describe("'es2016.js'", () => {
-    const config = require("../../../lib/configs/es2016")
-
     it("should be a valid config.", () => {
         Rules.validateConfig(config, "es2016.js")
     })

tests/lib/configs/es2017.js

@@ -5,11 +5,10 @@
  */
 "use strict"
 
+const config = require("../../../lib/configs/es2017")
 const Rules = require("./_rules")
 
 describe("'es2017.js'", () => {
-    const config = require("../../../lib/configs/es2017")
-
     it("should be a valid config.", () => {
         Rules.validateConfig(config, "es2017.js")
     })

tests/lib/configs/es2018.js

@@ -5,11 +5,10 @@
  */
 "use strict"
 
+const config = require("../../../lib/configs/es2018")
 const Rules = require("./_rules")
 
 describe("'es2018.js'", () => {
-    const config = require("../../../lib/configs/es2018")
-
     it("should be a valid config.", () => {
         Rules.validateConfig(config, "es2018.js")
     })

tests/lib/configs/es2019.js

@@ -4,11 +4,10 @@
  */
 "use strict"
 
+const config = require("../../../lib/configs/es2019")
 const Rules = require("./_rules")
 
 describe("'es2019.js'", () => {
-    const config = require("../../../lib/configs/es2019")
-
     it("should be a valid config.", () => {
         Rules.validateConfig(config, "es2019.js")
     })