⚒ update devDependencies

Author: mysticatea

.eslintrc.yml

@@ -1,8 +1,9 @@
+root: true
 extends:
-  - plugin:mysticatea/es2018
+  - plugin:@mysticatea/es2018
 
-overrides:
-  - files: "*.ts"
-    rules:
-      require-jsdoc: off
-      mysticatea/ts/no-use-before-define: off
+rules:
+  # tsc does.
+  "no-redeclare": "off"
+  # https://github.com/typescript-eslint/typescript-eslint/issues/743
+  "@mysticatea/ts/unbound-method": "off"

.travis.yml

@@ -7,5 +7,17 @@ node_js:
   - "10"
   - "12"
 
+script:
+  # eslint and nyc don't support Node 6.
+  - |
+    if [ $TRAVIS_NODE_VERSION != "6.5" ]; then
+      npm test
+    else
+      npm run -s test:node6
+    fi
+
 after_success:
-  - npm run coveralls
+  - |
+    if [ $TRAVIS_NODE_VERSION != "6.5" ]; then
+      npm run coveralls
+    fi

package.json

@@ -11,24 +11,22 @@
   ],
   "dependencies": {},
   "devDependencies": {
+    "@mysticatea/eslint-plugin": "^11.0.0",
     "@types/eslint": "^4.16.2",
     "@types/mocha": "^5.2.2",
-    "@types/node": "^10.3.3",
+    "@types/node": "^12.6.8",
     "coveralls": "^3.0.1",
     "dts-bundle": "^0.7.3",
-    "eslint": "^4.19.1",
-    "eslint-plugin-mysticatea": "^5.0.0-beta.15",
-    "mocha": "^5.2.0",
-    "npm-run-all": "^4.1.3",
-    "nyc": "^12.0.2",
+    "eslint": "^6.1.0",
+    "mocha": "^6.2.0",
+    "npm-run-all": "^4.1.5",
+    "nyc": "^14.1.1",
     "rimraf": "^2.6.2",
-    "rollup": "^0.60.7",
-    "rollup-plugin-node-resolve": "^3.3.0",
+    "rollup": "^1.17.0",
+    "rollup-plugin-node-resolve": "^5.2.0",
     "rollup-plugin-sourcemaps": "^0.4.2",
-    "rollup-watch": "^4.3.1",
-    "ts-node": "^6.1.1",
-    "typescript": "^2.9.2",
-    "typescript-eslint-parser": "^16.0.0"
+    "ts-node": "^8.3.0",
+    "typescript": "^3.5.3"
   },
   "scripts": {
     "prebuild": "npm run -s clean",
@@ -41,6 +39,7 @@
     "lint": "eslint scripts src test --ext .ts",
     "pretest": "run-s build lint",
     "test": "nyc _mocha \"test/*.ts\" --reporter dot --timeout 10000",
+    "test:node6": "_mocha \"test/*.ts\" --require ts-node/register --reporter dot --timeout 10000",
     "update:test": "ts-node scripts/update-fixtures.ts",
     "update:ids": "ts-node scripts/update-unicode-ids.ts",
     "preversion": "npm test",

scripts/clone-without-circular.ts

@@ -1,4 +1,4 @@
-const relative = require("path").posix.relative
+import { posix } from "path"
 
 function resolveLocation(
     obj: any,
@@ -61,10 +61,10 @@ function getRelativePath(
         return to.map(el => getRelativePath(from, el, pathMap))
     }
 
-    const fromPath = pathMap.get(from)
-    const toPath = pathMap.get(to)
+    const fromPath = pathMap.get(from)!
+    const toPath = pathMap.get(to)!
     try {
-        return `♻️${relative(fromPath, toPath).replace(/\/$/u, "")}`
+        return `♻️${posix.relative(fromPath, toPath).replace(/\/$/u, "")}`
     } catch (err) {
         console.error(fromPath, toPath, err.stack)
         return "💥💥💥💥💥💥💥💥"

scripts/update-unicode-ids.ts

@@ -4,8 +4,8 @@ import { CLIEngine } from "eslint"
 
 const DB_URL = "http://unicode.org/Public/UNIDATA/DerivedCoreProperties.txt"
 const FILE_PATH = "src/unicode/ids.ts"
-const ID_START = /^([0-9a-z]+)(?:\.\.([0-9a-z]+))?[^;]*; ID_Start /i
-const ID_CONTINUE = /^([0-9a-z]+)(?:\.\.([0-9a-z]+))?[^;]*; ID_Continue /i
+const ID_START = /^([0-9a-z]+)(?:\.\.([0-9a-z]+))?[^;]*; ID_Start /iu
+const ID_CONTINUE = /^([0-9a-z]+)(?:\.\.([0-9a-z]+))?[^;]*; ID_Continue /iu
 const BORDER = 0x7f
 const logger = console
 
@@ -19,10 +19,10 @@ enum Mode {
 ;(async () => {
     let banner = ""
     const idStartSet: Set<string> = new Set()
-    const idStartSmall: Array<[number, number]> = []
-    const idStartLarge: Array<[number, number]> = []
-    const idContinueSmall: Array<[number, number]> = []
-    const idContinueLarge: Array<[number, number]> = []
+    const idStartSmall: [number, number][] = []
+    const idStartLarge: [number, number][] = []
+    const idContinueSmall: [number, number][] = []
+    const idContinueLarge: [number, number][] = []
 
     logger.log("Fetching data... (%s)", DB_URL)
     await processEachLine(line => {
@@ -86,30 +86,28 @@ ${makeCondition(idContinueLarge, Mode.Former)}
 
 function processEachLine(cb: (line: string) => void): Promise<void> {
     return new Promise((resolve, reject) => {
-        http
-            .get(DB_URL, res => {
-                let buffer = ""
-                res.setEncoding("utf8")
-                res.on("data", chunk => {
-                    const lines = (buffer + chunk).split("\n")
-                    if (lines.length === 1) {
-                        buffer = lines[0]
-                    } else {
-                        buffer = lines.pop()!
-                        for (const line of lines) {
-                            cb(line)
-                        }
+        http.get(DB_URL, res => {
+            let buffer = ""
+            res.setEncoding("utf8")
+            res.on("data", chunk => {
+                const lines = (buffer + String(chunk)).split("\n")
+                if (lines.length === 1) {
+                    buffer = lines[0]
+                } else {
+                    buffer = lines.pop()!
+                    for (const line of lines) {
+                        cb(line)
                     }
-                })
-                res.on("end", () => {
-                    if (buffer) {
-                        cb(buffer)
-                    }
-                    resolve()
-                })
-                res.on("error", reject)
+                }
+            })
+            res.on("end", () => {
+                if (buffer) {
+                    cb(buffer)
+                }
+                resolve()
             })
-            .on("error", reject)
+            res.on("error", reject)
+        }).on("error", reject)
     })
 }
 
@@ -148,10 +146,8 @@ function makeSmallCondtion(ranges: [number, number][], mode: Mode): string {
 
 function save(content: string): Promise<void> {
     return new Promise((resolve, reject) => {
-        fs.writeFile(
-            FILE_PATH,
-            content,
-            error => (error ? reject(error) : resolve()),
+        fs.writeFile(FILE_PATH, content, error =>
+            error ? reject(error) : resolve(),
         )
     })
 }

src/parser.ts

@@ -23,9 +23,9 @@ type AppendableNode =
     | CharacterClass
     | LookaroundAssertion
 
-const DummyPattern = {} as Pattern
-const DummyFlags = {} as Flags
-const DummyCapturingGroup = {} as CapturingGroup
+const DummyPattern: Pattern = {} as any
+const DummyFlags: Flags = {} as any
+const DummyCapturingGroup: CapturingGroup = {} as any
 
 class RegExpParserState {
     public readonly strict: boolean
@@ -251,7 +251,7 @@ class RegExpParserState {
             throw new Error("UnknownError")
         }
 
-        this._node = {
+        const node: LookaroundAssertion = (this._node = {
             type: "Assertion",
             parent,
             start,
@@ -260,8 +260,8 @@ class RegExpParserState {
             kind,
             negate,
             alternatives: [],
-        } as LookaroundAssertion
-        parent.elements.push(this._node)
+        })
+        parent.elements.push(node)
     }
 
     public onLookaroundAssertionLeave(start: number, end: number): void {

src/regexp-syntax-error.ts

@@ -8,7 +8,7 @@ export class RegExpSyntaxError extends SyntaxError {
     ) {
         /*eslint-disable no-param-reassign */
         if (source) {
-            if (source[0] !== "/") {
+            if (!source.startsWith("/")) {
                 source = `/${source}/${uFlag ? "u" : ""}`
             }
             source = `: ${source}`

src/validator.ts

@@ -449,7 +449,7 @@ export class RegExpValidator {
         this.onLiteralEnter(start)
         if (this.eat(Solidus) && this.eatRegExpBody() && this.eat(Solidus)) {
             const flagStart = this.index
-            const uFlag = source.indexOf("u", flagStart) !== -1
+            const uFlag = source.includes("u", flagStart)
             this.validateFlags(source, flagStart, end)
             this.validatePattern(source, start + 1, flagStart - 1, uFlag)
         } else if (start >= end) {

test/fixtures/visitor/index.ts

@@ -17,16 +17,13 @@ const fixturesRoot = __dirname
 export const Fixtures: FixtureData = fs
     .readdirSync(fixturesRoot)
     .filter(filename => path.extname(filename) === ".json")
-    .reduce(
-        (fixtures, filename) => {
-            fixtures[filename] = JSON.parse(
-                fs.readFileSync(path.join(fixturesRoot, filename), "utf8"),
-                (_, v) => (v === "$$Infinity" ? Infinity : v),
-            )
-            return fixtures
-        },
-        {} as FixtureData,
-    )
+    .reduce<FixtureData>((fixtures, filename) => {
+        fixtures[filename] = JSON.parse(
+            fs.readFileSync(path.join(fixturesRoot, filename), "utf8"),
+            (_, v) => (v === "$$Infinity" ? Infinity : v),
+        )
+        return fixtures
+    }, {})
 export function save(): void {
     for (const filename of Object.keys(Fixtures)) {
         fs.writeFileSync(

test/parser.ts

@@ -13,14 +13,14 @@ describe("parseRegExpLiteral function:", () => {
         const options = fixture.options
 
         describe(`${filename} (options=${JSON.stringify(options)})`, () => {
-            if (filename.indexOf("-valid") !== -1) {
+            if (filename.includes("-valid")) {
                 it("should not contain any invalid test case", () => {
                     for (const source of Object.keys(fixture.patterns)) {
                         const result = fixture.patterns[source]
                         assert("ast" in result, `${source} is invalid`)
                     }
                 })
-            } else if (filename.indexOf("-invalid") !== -1) {
+            } else if (filename.includes("-invalid")) {
                 it("should not contain any valid test case", () => {
                     for (const source of Object.keys(fixture.patterns)) {
                         const result = fixture.patterns[source]
@@ -43,9 +43,7 @@ describe("parseRegExpLiteral function:", () => {
                         assert.strictEqual(
                             expected.message.slice(0, 27),
                             "Invalid regular expression:",
-                            `The error message '${
-                                expected.message
-                            }' was not syntax error.`,
+                            `The error message '${expected.message}' was not syntax error.`,
                         )
                         try {
                             parseRegExpLiteral(source, options)
@@ -62,8 +60,8 @@ describe("parseRegExpLiteral function:", () => {
     }
 
     it("should parse RegExp object", () => {
-        const actual = cloneWithoutCircular(parseRegExpLiteral(/[A-Z]+/))
-        const expected = cloneWithoutCircular(parseRegExpLiteral("/[A-Z]+/"))
+        const actual = cloneWithoutCircular(parseRegExpLiteral(/[A-Z]+/u))
+        const expected = cloneWithoutCircular(parseRegExpLiteral("/[A-Z]+/u"))
 
         assert.deepStrictEqual(actual, expected)
     })
@@ -74,7 +72,7 @@ describe("RegExpParser:", () => {
         it("should throw syntax error on '\\'.", () => {
             assert.throws(
                 () => new RegExpParser().parsePattern("\\"),
-                /\\ at end of pattern/,
+                /\\ at end of pattern/u,
             )
         })
     })