fix: new players have their balance fixed to 0 until they rejoin

Author: U8092

api/src/main/java/ovh/mythmc/banco/api/accounts/AccountManager.java

@@ -4,7 +4,6 @@
 import lombok.Getter;
 import lombok.RequiredArgsConstructor;
 
-import org.bukkit.Bukkit;
 import org.jetbrains.annotations.ApiStatus;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.ApiStatus.Internal;
@@ -40,6 +39,8 @@ public final class AccountManager {
     public synchronized void create(final @NotNull UUID uuid) {
         Account account = new Account();
         account.setUuid(uuid);
+        account.setAmount(BigDecimal.ZERO);
+        account.setTransactions(BigDecimal.ZERO);
 
         create(account);
     }
@@ -53,6 +54,8 @@ public synchronized void create(final @NotNull UUID uuid, final @NotNull String
         Account account = new Account();
         account.setUuid(uuid);
         account.setName(name);
+        account.setAmount(BigDecimal.ZERO);
+        account.setTransactions(BigDecimal.ZERO);
 
         create(account);
     }
@@ -215,8 +218,8 @@ public boolean has(final @NotNull Account account, final @NotNull BigDecimal amo
      */
     public @NotNull BigDecimal amount(final @NotNull Account account) {
         // Fake players / accounts
-        if (!Bukkit.getOfflinePlayer(account.getUuid()).hasPlayedBefore())
-            return account.getTransactions().add(getValueOfPlayer(account.getUuid(), false));
+        //if (!Bukkit.getOfflinePlayer(account.getUuid()).hasPlayedBefore())
+        //    return account.getTransactions().add(getValueOfPlayer(account.getUuid(), false));
 
         final Optional<OfflinePlayerReference> optionalOfflinePlayerReference = uuidResolver.resolveOfflinePlayer(account.getUuid());
 
@@ -229,7 +232,8 @@ public boolean has(final @NotNull Account account, final @NotNull BigDecimal amo
         }
 
         // Offline players
-        return account.getAmount().add(account.getTransactions());
+        //return account.getAmount().add(account.getTransactions());
+        return account.getTransactions().add(getValueOfPlayer(account.getUuid(), false)).add(account.getAmount());
     }
 
     @Internal

platform-common/src/main/java/ovh/mythmc/banco/common/listeners/PlayerListener.java

@@ -8,29 +8,25 @@
 import lombok.RequiredArgsConstructor;
 import ovh.mythmc.banco.api.Banco;
 import ovh.mythmc.banco.api.accounts.Account;
-import ovh.mythmc.banco.api.scheduler.BancoScheduler;
 
-import java.math.BigDecimal;
 import java.util.UUID;
 
 @RequiredArgsConstructor
 public class PlayerListener implements Listener {
 
     @EventHandler
     public void onPlayerJoin(PlayerJoinEvent event) {
-        BancoScheduler.get().run(() ->{
-            UUID uuid = event.getPlayer().getUniqueId();
-            Account account = Banco.get().getAccountManager().getByUuid(uuid);
-    
-            if (account == null) {
-                account = new Account(uuid, event.getPlayer().getName(), BigDecimal.valueOf(0), BigDecimal.valueOf(0));
-                Banco.get().getAccountManager().create(account);
-            } else {
-                Banco.get().getAccountManager().updateName(account, event.getPlayer().getName());
-            }
-    
-            Banco.get().getAccountManager().updateTransactions(account);
-        });
+        UUID uuid = event.getPlayer().getUniqueId();
+        Account account = Banco.get().getAccountManager().getByUuid(uuid);
+
+        if (account == null) {
+            Banco.get().getAccountManager().create(uuid, event.getPlayer().getName());
+            account = Banco.get().getAccountManager().getByUuid(uuid);
+        } else {
+            Banco.get().getAccountManager().updateName(account, event.getPlayer().getName());
+        }
+
+        Banco.get().getAccountManager().updateTransactions(account);
     }
 
     @EventHandler