Small changes suggested by Yaron

jeffw16 · jeffw16 · commit 38da555fcc0c · 2026-03-27T15:57:55.000-06:00
diff --git a/.github/instructions/mediawiki-extensions-clean-code.instructions.md b/.github/instructions/mediawiki-extensions-clean-code.instructions.md
@@ -8,10 +8,14 @@ applyTo: "*"
 
 Use the service container pattern (based on MediaWikiServices) to define how key objects are constructed and wired together.
 
+Absolutely no MediaWikiServices references should be in the code because everything should be injected.
+
 ## Dependency injection
 
 Use this example from PluggableAuth to implement dependency injection.
 
+Objects should only be instantiated in `ServiceWiring.php`, not in any other file.
+
 Below is an `includes/ServiceWiring.php` file.
 
 ```php
@@ -150,4 +154,4 @@ class PluggableAuthServiceTest extends MediaWikiIntegrationTestCase {
 	}
 
 }
-```
+```
diff --git a/extension.json b/extension.json
@@ -40,7 +40,7 @@
             "value": "HTTP/1.0 403 Forbidden"
         },
         "CrawlerProtectionRawDenialText": {
-            "value": "403 Forbidden"
+            "value": "403 Forbidden. You must be logged in to view this page."
         }
     },
     "ServiceWiringFiles": [
diff --git a/includes/CrawlerProtectionService.php b/includes/CrawlerProtectionService.php
@@ -1,6 +1,6 @@
 <?php
 /**
- * Copyright (c) 2025 MyWikis
+ * Copyright (c) 2025-2026 MyWikis
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
diff --git a/includes/Hooks.php b/includes/Hooks.php
@@ -1,6 +1,6 @@
 <?php
 /**
- * Copyright (c) 2025 MyWikis
+ * Copyright (c) 2025-2026 MyWikis
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
diff --git a/includes/ResponseFactory.php b/includes/ResponseFactory.php
@@ -1,6 +1,6 @@
 <?php
 /**
- * Copyright (c) 2025 MyWikis
+ * Copyright (c) 2025-2026 MyWikis
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
diff --git a/includes/ServiceWiring.php b/includes/ServiceWiring.php
@@ -1,6 +1,6 @@
 <?php
 /**
- * Copyright (c) 2025 MyWikis
+ * Copyright (c) 2025-2026 MyWikis
  *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal

Original file line number	Diff line number	Diff line change
`@@ -8,10 +8,14 @@ applyTo: "*"`
`8`	`8`
`9`	`9`	`Use the service container pattern (based on MediaWikiServices) to define how key objects are constructed and wired together.`
`10`	`10`
	`11`	`+Absolutely no MediaWikiServices references should be in the code because everything should be injected.`
	`12`	`+`
`11`	`13`	`## Dependency injection`
`12`	`14`
`13`	`15`	`Use this example from PluggableAuth to implement dependency injection.`
`14`	`16`
	`17`	+Objects should only be instantiated in `ServiceWiring.php`, not in any other file.
	`18`	`+`
`15`	`19`	Below is an `includes/ServiceWiring.php` file.
`16`	`20`
`17`	`21`	```php
`@@ -150,4 +154,4 @@ class PluggableAuthServiceTest extends MediaWikiIntegrationTestCase {`
`150`	`154`	`}`
`151`	`155`
`152`	`156`	`}`
`153`		-```
	`157`	+```
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@`
`40`	`40`	`"value": "HTTP/1.0 403 Forbidden"`
`41`	`41`	`},`
`42`	`42`	`"CrawlerProtectionRawDenialText": {`
`43`		`- "value": "403 Forbidden"`
	`43`	`+ "value": "403 Forbidden. You must be logged in to view this page."`
`44`	`44`	`}`
`45`	`45`	`},`
`46`	`46`	`"ServiceWiringFiles": [`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`<?php`
`2`	`2`	`/**`
`3`		`- * Copyright (c) 2025 MyWikis`
	`3`	`+ * Copyright (c) 2025-2026 MyWikis`
`4`	`4`	`*`
`5`	`5`	`* Permission is hereby granted, free of charge, to any person obtaining a copy`
`6`	`6`	`* of this software and associated documentation files (the "Software"), to deal`