Remove unnecessary escaping of header() input

yaronkoren · web-flow · commit f38af88dd746 · 2026-03-05T15:38:48.000-08:00
diff --git a/includes/Hooks.php b/includes/Hooks.php
@@ -138,7 +138,7 @@ public function onSpecialPageBeforeExecute( $special, $subPage ) {
 	 * @suppress PhanPluginNeverReturnMethod
 	 */
 	protected function denyAccessCustom( $customDenialHeader, $customDenialText ) {
-		header( htmlspecialchars( $customDenialHeader ) );
+		header( $customDenialHeader );
 		die( htmlspecialchars( $customDenialText ) );
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ public function onSpecialPageBeforeExecute( $special, $subPage ) {`
`138`	`138`	`* @suppress PhanPluginNeverReturnMethod`
`139`	`139`	`*/`
`140`	`140`	`protected function denyAccessCustom( $customDenialHeader, $customDenialText ) {`
`141`		`- header( htmlspecialchars( $customDenialHeader ) );`
	`141`	`+ header( $customDenialHeader );`
`142`	`142`	`die( htmlspecialchars( $customDenialText ) );`
`143`	`143`	`}`
`144`	`144`