Action "slavelag" for master-slave replication (legacy) #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the action "slavelag" to determine the lag behind the master of a master slave replication (legacy).
|
@heuri thank you for adding it to the plugin. how about adding perf data to it? this check throws an exception if missing lagSeconds, perhaps print the node type primary/arbi etc. in the message? patch: --- check_mongodb.py 2015-05-30 05:52:17.603794569 +0000
+++ check_mongodb.py.me 2015-05-30 05:47:36.707526065 +0000
@@ -253,7 +253,7 @@
elif action == "replset_quorum":
return check_replset_quorum(con, perf_data)
elif action == "slavelag":
- return check_slavelag(con, warning, critical)
+ return check_slavelag(con, warning, critical, perf_data)
else:
return check_connect(host, port, warning, critical, perf_data, user, passwd, conn_time)
@@ -1237,7 +1237,7 @@
primary_status = 1
return check_levels(primary_status, warning, critical, message)
-def check_slavelag(con, warning, critical):
+def check_slavelag(con, warning, critical, perf_data):
warning = warning or 30
critical = critical or 60
@@ -1251,11 +1251,12 @@
try:
seconds = int(data['repl']['sources'][0]['lagSeconds'])
master = data['repl']['sources'][0]['host']
+ message = "Master Slave Replication " + str(seconds) + " secs behind '" + master + "' (master)."
except (KeyError, IndexError):
- raise Exception("Missing lagSeconds-Value, not running with --slave?")
-
- message = "Master Slave Replication " + str(seconds) + " secs behind '" + master + "' (master)."
+ seconds = 0
+ message = "Missing lagSeconds-Value, not running with --slave or connected to a master/primary node"
+ message += performance_data(perf_data, [(seconds, "slavelag", warning, critical)])
return check_levels(seconds, warning, critical, message)
except Exception, e: |
Author
|
@vkhatri great idea, works like a charm. Yes we could determine the node status by checking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the action "slavelag" to determine the lag behind the master of a master slave replication (legacy).
Currently the command
rs.printSlaveReplicationInfo()is not supported by pymongo, so we determine the lag by using('serverStatus', 1), ('repl', 2)