Remove deprecated code (thoughtbot#2832)

Before going into v1.0, we should shed deprecated APIs that we have supported
for back-compatibility:

* Remove deprecated APIs
* Remove specs of removed APIs
* Remove docs on removed APIs

Author: pablobm

app/controllers/administrate/application_controller.rb

@@ -122,15 +122,6 @@ def existing_action?(resource, action_name)
     end
     helper_method :existing_action?
 
-    # @deprecated Use {#existing_action} instead. Note that, in
-    #   {#existing_action}, the order of parameters is reversed and
-    #   there is no default value for the `resource` parameter.
-    def valid_action?(action_name, resource = resource_class)
-      Administrate.warn_of_deprecated_authorization_method(__method__)
-      existing_action?(resource, action_name)
-    end
-    helper_method :valid_action?
-
     def routes
       @routes ||= Namespace.new(namespace).routes.to_set
     end
@@ -265,14 +256,6 @@ def authorized_action?(_resource, _action_name)
     end
     helper_method :authorized_action?
 
-    # @deprecated Use {#authorized_action} instead. Note that the order of
-    #   parameters is reversed in {#authorized_action}.
-    def show_action?(action, resource)
-      Administrate.warn_of_deprecated_authorization_method(__method__)
-      authorized_action?(resource, action)
-    end
-    helper_method :show_action?
-
     def new_resource(params = {})
       resource_class.new(params)
     end

app/controllers/concerns/administrate/punditize.rb

@@ -41,15 +41,7 @@ def policy_scope!(user, scope)
             "Invalid #<#{policy_scope_class}> constructor is called")
         end
 
-        if policy_scope.respond_to? :resolve_admin
-          Administrate.deprecator.warn(
-            "Pundit policy scope `resolve_admin` method is deprecated. " \
-            "Please use a namespaced pundit policy instead."
-          )
-          policy_scope.resolve_admin
-        else
-          policy_scope.resolve
-        end
+        policy_scope.resolve
       end
 
       def pundit_model(record)

docs/customizing_dashboards.md

@@ -115,10 +115,6 @@ If neither is specified, sorting will be done using the foreign key.
 
 `:class_name` - Specifies the name of the associated class.
 
-`:primary_key` (deprecated) - Specifies the association's primary_key.
-
-`:foreign_key` (deprecated) - Specifies the name of the foreign key directly.
-
 **Field::HasMany**
 
 `:collection_attributes` - Set the columns to display in the show view.
@@ -141,10 +137,6 @@ For `HasMany` associations, sorting is based on the count, so this option is not
 
 `:class_name` - Specifies the name of the associated class.
 
-`:primary_key` (deprecated) - Specifies object's primary_key.
-
-`:foreign_key` (deprecated) - Specifies the name of the foreign key directly.
-
 **Field::HasOne**
 
 `:order` - Specifies the column used to order the records. It will apply both in

lib/administrate.rb

@@ -2,44 +2,6 @@
 require "administrate/version"
 
 module Administrate
-  def self.warn_of_missing_resource_class
-    deprecator.warn(
-      "Calling Field::Base.permitted_attribute without the option " \
-      ":resource_class is deprecated. If you are seeing this " \
-      "message, you are probably using a custom field type that" \
-      "does this. Please make sure to update it to a version that " \
-      "does not use a deprecated API"
-    )
-  end
-
-  def self.warn_of_deprecated_option(name)
-    deprecator.warn(
-      "The option :#{name} is deprecated. " \
-      "Administrate should detect it automatically. " \
-      "Please file an issue at " \
-      "https://github.com/thoughtbot/administrate/issues " \
-      "if you think otherwise."
-    )
-  end
-
-  def self.warn_of_deprecated_method(klass, method)
-    deprecator.warn(
-      "The method #{klass}##{method} is deprecated. " \
-      "If you are seeing this message you are probably " \
-      "using a dashboard that depends explicitly on it. " \
-      "Please make sure you update it to a version that " \
-      "does not use a deprecated API"
-    )
-  end
-
-  def self.warn_of_deprecated_authorization_method(method)
-    deprecator.warn(
-      "The method `#{method}` is deprecated. " \
-      "Please use `accessible_action?` instead, " \
-      "or see the documentation for other options."
-    )
-  end
-
   def self.deprecator
     @deprecator ||= ActiveSupport::Deprecation.new(VERSION, "Administrate")
   end

lib/administrate/base_dashboard.rb

@@ -111,12 +111,6 @@ def collection_includes
       attribute_includes(collection_attributes)
     end
 
-    def item_includes
-      # Deprecated, internal usage has moved to #item_associations
-      Administrate.warn_of_deprecated_method(self.class, :item_includes)
-      attribute_includes(show_page_attributes)
-    end
-
     def item_associations
       attributes = if show_page_attributes.is_a?(Hash)
         show_page_attributes.values.flatten

lib/administrate/field/associative.rb

@@ -56,36 +56,17 @@ def associated_dashboard
         "#{associated_class_name}Dashboard".constantize.new
       end
 
-      def primary_key
-        # Deprecated, renamed `association_primary_key`
-        Administrate.warn_of_deprecated_method(self.class, :primary_key)
-        association_primary_key
-      end
-
       def association_primary_key
-        if option_given?(:primary_key)
-          deprecated_option(:primary_key)
-        else
-          self.class.association_primary_key_for(resource.class, attribute)
-        end
+        self.class.association_primary_key_for(resource.class, attribute)
       end
 
       def foreign_key
-        if option_given?(:foreign_key)
-          deprecated_option(:foreign_key)
-        else
-          self.class.foreign_key_for(resource.class, attribute)
-        end
+        self.class.foreign_key_for(resource.class, attribute)
       end
 
       def option_given?(name)
         options.key?(name)
       end
-
-      def deprecated_option(name)
-        Administrate.warn_of_deprecated_option(name)
-        options.fetch(name)
-      end
     end
   end
 end

lib/administrate/field/belongs_to.rb

@@ -5,12 +5,7 @@ module Field
     class BelongsTo < Associative
       def self.permitted_attribute(attr, options = {})
         resource_class = options[:resource_class]
-        if resource_class
-          foreign_key_for(resource_class, attr)
-        else
-          Administrate.warn_of_missing_resource_class
-          :"#{attr}_id"
-        end
+        foreign_key_for(resource_class, attr)
       end
 
       def self.eager_load?

lib/administrate/field/deferred.rb

@@ -41,32 +41,16 @@ def searchable?
         end
       end
 
-      def searchable_field
-        Administrate.deprecator.warn(
-          "searchable_field is deprecated, use searchable_fields instead"
-        )
-        options.fetch(:searchable_field)
-      end
-
       def searchable_fields
-        if options.key?(:searchable_field)
-          [searchable_field]
-        else
-          options.fetch(:searchable_fields)
-        end
+        options.fetch(:searchable_fields)
       end
 
       def sortable?
         options.fetch(:sortable, deferred_class.sortable?)
       end
 
       def permitted_attribute(attr, opts = {})
-        if options.key?(:foreign_key)
-          Administrate.warn_of_deprecated_option(:foreign_key)
-          options.fetch(:foreign_key)
-        else
-          deferred_class.permitted_attribute(attr, options.merge(opts))
-        end
+        deferred_class.permitted_attribute(attr, options.merge(opts))
       end
 
       delegate :html_class, to: :deferred_class

lib/administrate/field/has_one.rb

@@ -8,15 +8,8 @@ def self.permitted_attribute(attr, options = {})
         final_associated_class_name =
           if options.key?(:class_name)
             options.fetch(:class_name)
-          elsif resource_class
-            associated_class_name(resource_class, attr)
           else
-            Administrate.warn_of_missing_resource_class
-            if options
-              attr.to_s.singularize.camelcase
-            else
-              attr
-            end
+            associated_class_name(resource_class, attr)
           end
         related_dashboard_attributes =
           Administrate::ResourceResolver

spec/controllers/admin/application_controller_spec.rb

@@ -100,38 +100,4 @@ def authorized_action?(resource, _action)
         .to raise_error(Administrate::NotAuthorizedError)
     end
   end
-
-  describe "deprecated methods: show_action" do
-    controller(Administrate::ApplicationController) do
-      def index
-        show_action?(:index, Order)
-      end
-    end
-
-    it "triggers a deprecation warning" do
-      allow(Administrate.deprecator).to receive(:warn)
-      get :index
-      expect(Administrate.deprecator).to(
-        have_received(:warn)
-          .with(/`show_action\?` is deprecated/)
-      )
-    end
-  end
-
-  describe "deprecated methods: valid_action" do
-    controller(Administrate::ApplicationController) do
-      def index
-        valid_action?(:index, Order)
-      end
-    end
-
-    it "triggers a deprecation warning" do
-      allow(Administrate.deprecator).to receive(:warn)
-      get :index
-      expect(Administrate.deprecator).to(
-        have_received(:warn)
-          .with(/`valid_action\?` is deprecated/)
-      )
-    end
-  end
 end