chore(iroh): Update n0-watcher (#3405)

## Description

Updates the `n0-watcher` dependency to the new version (that has a lot
fewer `Result`s everywhere).
- [x] Depends on n0-computer/net-tools#31
- [x] Needs a release of `net-tools`

## Breaking Changes

- Updated `n0-watcher` from version `0.2` to `0.3`.
  Migration guide for users:
- `endpoint.node_addr().initialized().await?` ->
`endpoint.node_addr().initialized().await` (no `?` needed anymore) and
similarly for `endpoint.home_relay()` and other uses of `Watcher`s.
- `endpoint.node_addr().get()?` -> `endpoint.node_addr().get()` and
similarly for `endpoint.home_relay()` and other uses of `Watcher`s.
- If all you have is a `&impl Watcher` but you need the current value,
then you can't call `Watcher::get` anymore, as that now takes a `&mut
self` instead of `&self`. You can work around this by `.clone()`ing to
an intermediate watcher:
    `watcher_ref.get()` -> `watcher_ref.clone().get()`

## Change checklist
<!-- Remove any that are not relevant. -->
- [x] Self-review.
- [x] Documentation updates following the [style
guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text),
if relevant.
- [x] All breaking changes documented.

Author: matheus23

Cargo.lock

@@ -41,9 +41,9 @@ iroh-base = { version = "0.90.0", default-features = false, features = ["key", "
 iroh-relay = { version = "0.90", path = "../iroh-relay", default-features = false }
 n0-future = "0.1.2"
 n0-snafu = "0.2.1"
-n0-watcher = "0.2"
+n0-watcher = "0.3"
 nested_enum_utils = "0.2.1"
-netwatch = { version = "0.7" }
+netwatch = { version = "0.8" }
 pin-project = "1"
 pkarr = { version = "3.7", default-features = false, features = [
     "relays",

iroh/Cargo.toml

@@ -12,7 +12,6 @@ iroh = { path = ".." }
 iroh-metrics = "0.35"
 n0-future = "0.1.1"
 n0-snafu = "0.2.0"
-n0-watcher = "0.2"
 quinn = { package = "iroh-quinn", version = "0.14" }
 rand = "0.8"
 rcgen = "0.14"

iroh/bench/Cargo.toml

@@ -5,11 +5,10 @@ use std::{
 
 use bytes::Bytes;
 use iroh::{
-    Endpoint, NodeAddr, RelayMode, RelayUrl,
+    Endpoint, NodeAddr, RelayMode, RelayUrl, Watcher as _,
     endpoint::{Connection, ConnectionError, RecvStream, SendStream, TransportConfig},
 };
 use n0_snafu::{Result, ResultExt};
-use n0_watcher::Watcher as _;
 use tracing::{trace, warn};
 
 use crate::{
@@ -50,7 +49,7 @@ pub fn server_endpoint(
             .unwrap();
 
         if relay_url.is_some() {
-            ep.home_relay().initialized().await.unwrap();
+            ep.home_relay().initialized().await;
         }
 
         let addr = ep.bound_sockets();
@@ -111,7 +110,7 @@ pub async fn connect_client(
         .unwrap();
 
     if relay_url.is_some() {
-        endpoint.home_relay().initialized().await?;
+        endpoint.home_relay().initialized().await;
     }
 
     // TODO: We don't support passing client transport config currently

iroh/bench/src/iroh.rs

@@ -52,7 +52,7 @@ async fn main() -> n0_snafu::Result<()> {
         .bind()
         .await?;
 
-    let node_addr = endpoint.node_addr().initialized().await?;
+    let node_addr = endpoint.node_addr().initialized().await;
     let me = node_addr.node_id;
     println!("node id: {me}");
     println!("node listening addresses:");

iroh/examples/connect-unreliable.rs

@@ -55,19 +55,13 @@ async fn main() -> Result<()> {
     let me = endpoint.node_id();
     println!("node id: {me}");
     println!("node listening addresses:");
-    for local_endpoint in endpoint
-        .direct_addresses()
-        .initialized()
-        .await
-        .context("no direct addresses")?
-    {
+    for local_endpoint in endpoint.direct_addresses().initialized().await {
         println!("\t{}", local_endpoint.addr)
     }
 
     let relay_url = endpoint
         .home_relay()
         .get()
-        .unwrap()
         .first()
         .cloned()
         .expect("should be connected to a relay server, try calling `endpoint.local_endpoints()` or `endpoint.connect()` first, to ensure the endpoint has actually attempted a connection before checking for the connected relay server");

iroh/examples/connect.rs

@@ -20,7 +20,7 @@ const ALPN: &[u8] = b"iroh-example/echo/0";
 #[tokio::main]
 async fn main() -> Result<()> {
     let endpoint = start_accept_side().await?;
-    let node_addr = endpoint.node_addr().initialized().await?;
+    let node_addr = endpoint.node_addr().initialized().await;
 
     connect_side(node_addr).await?;
 

iroh/examples/echo-no-router.rs

@@ -23,7 +23,7 @@ const ALPN: &[u8] = b"iroh-example/echo/0";
 #[tokio::main]
 async fn main() -> Result<()> {
     let router = start_accept_side().await?;
-    let node_addr = router.endpoint().node_addr().initialized().await?;
+    let node_addr = router.endpoint().node_addr().initialized().await;
 
     connect_side(node_addr).await?;
 

iroh/examples/echo.rs

@@ -37,7 +37,7 @@ async fn main() -> Result<()> {
     println!("node id: {me}");
     println!("node listening addresses:");
 
-    let node_addr = endpoint.node_addr().initialized().await?;
+    let node_addr = endpoint.node_addr().initialized().await;
     let local_addrs = node_addr
         .direct_addresses
         .into_iter()

iroh/examples/listen-unreliable.rs

@@ -42,7 +42,7 @@ async fn main() -> n0_snafu::Result<()> {
     let local_addrs = endpoint
         .direct_addresses()
         .initialized()
-        .await?
+        .await
         .into_iter()
         .map(|addr| {
             let addr = addr.addr.to_string();
@@ -51,7 +51,7 @@ async fn main() -> n0_snafu::Result<()> {
         })
         .collect::<Vec<_>>()
         .join(" ");
-    let relay_url = endpoint.home_relay().initialized().await?;
+    let relay_url = endpoint.home_relay().initialized().await;
     println!("node relay server url: {relay_url}");
     println!("\nin a separate terminal run:");