Address review

Author: matheus23

Cargo.lock

@@ -19,7 +19,6 @@ workspace = true
 atomic-waker = "1.1.2"
 bytes = "1.7"
 n0-future = "0.1.1"
-n0-snafu = { git = "https://github.com/n0-computer/n0-snafu", branch = "matheus23/clone" }
 nested_enum_utils = "0.2.0"
 snafu = "0.8.5"
 time = "0.3.20"

netwatch/Cargo.toml

@@ -601,20 +601,18 @@ type RIBType = i32;
 
 #[common_fields({
     backtrace: Option<Backtrace>,
-    #[snafu(implicit)]
-    span_trace: n0_snafu::SpanTrace,
 })]
 #[derive(Debug, Snafu)]
 #[non_exhaustive]
 pub enum RouteError {
     #[snafu(display("message mismatch"))]
-    MessageMismatch {},
+    MessageMismatch,
     #[snafu(display("message too short"))]
-    MessageTooShort {},
+    MessageTooShort,
     #[snafu(display("invalid message"))]
-    InvalidMessage {},
+    InvalidMessage,
     #[snafu(display("invalid address"))]
-    InvalidAddress {},
+    InvalidAddress,
     #[snafu(display("invalid rib type {rib_type}"))]
     InvalidRibType { rib_type: RIBType },
     #[snafu(display("io error calling '{name}'"))]

netwatch/src/interfaces/bsd.rs

@@ -13,8 +13,6 @@ use super::DefaultRouteDetails;
 
 #[common_fields({
     backtrace: Option<Backtrace>,
-    #[snafu(implicit)]
-    span_trace: n0_snafu::SpanTrace,
 })]
 #[derive(Debug, Snafu)]
 #[non_exhaustive]

netwatch/src/interfaces/linux.rs

@@ -17,8 +17,6 @@ struct Win32_IP4RouteTable {
 
 #[common_fields({
     backtrace: Option<Backtrace>,
-    #[snafu(implicit)]
-    span_trace: n0_snafu::SpanTrace,
 })]
 #[derive(Debug, Snafu)]
 #[non_exhaustive]

netwatch/src/interfaces/windows.rs

@@ -39,14 +39,12 @@ pub struct Monitor {
 
 #[common_fields({
     backtrace: Option<Backtrace>,
-    #[snafu(implicit)]
-    span_trace: n0_snafu::SpanTrace,
 })]
 #[derive(Debug, Snafu)]
 #[non_exhaustive]
 pub enum Error {
     #[snafu(display("channel closed"))]
-    ChannelClosed {},
+    ChannelClosed,
     #[snafu(display("actor error"))]
     Actor { source: actor::Error },
 }

netwatch/src/netmon.rs

@@ -22,8 +22,6 @@ pub enum Error {
     Io {
         source: std::io::Error,
         backtrace: Option<Backtrace>,
-        #[snafu(implicit)]
-        span_trace: n0_snafu::SpanTrace,
     },
 }
 

netwatch/src/netmon/bsd.rs

@@ -39,8 +39,6 @@ pub enum Error {
     Io {
         source: std::io::Error,
         backtrace: Option<Backtrace>,
-        #[snafu(implicit)]
-        span_trace: n0_snafu::SpanTrace,
     },
 }
 

netwatch/src/netmon/linux.rs

@@ -22,8 +22,6 @@ pub(super) struct RouteMonitor {
 
 #[common_fields({
     backtrace: Option<Backtrace>,
-    #[snafu(implicit)]
-    span_trace: n0_snafu::SpanTrace,
 })]
 #[derive(Debug, Snafu)]
 #[non_exhaustive]

netwatch/src/netmon/windows.rs

@@ -24,7 +24,6 @@ futures-util = "0.3.25"
 igd-next = { version = "0.15.1", features = ["aio_tokio"] }
 iroh-metrics = { version = "0.32", default-features = false }
 libc = "0.2.139"
-n0-snafu = { git = "https://github.com/n0-computer/n0-snafu", branch = "matheus23/clone" }
 nested_enum_utils = "0.2.0"
 netwatch = { version = "0.4.0", path = "../netwatch" }
 num_enum = "0.7"