Skip to content

Commit af2a378

Browse files
committed
* fix violation of Roslyn analyzer rule SS004 @ Replace
* merge field `_replaceMap` with primary ctor param `replaceMap` as NRT enabled @ `crawler.ExtensionMethods.FilterByItemsExpressionReplacer` * replace the value of `CopyToPublishDirectory` from `None` to `Never` to match with its XML schema type `msb:CopyItemMode`: https://learn.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props#copytopublishdirectory @ `crawler.csproj` & `imagePipeline.csproj` @ c#
1 parent c149112 commit af2a378

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

c#/crawler/src/ExtensionMethods.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -103,16 +103,14 @@ public static IQueryable<T> FilterByItems<T, TItem>(
103103

104104
private sealed class FilterByItemsExpressionReplacer(IDictionary<Expression, Expression> replaceMap) : ExpressionVisitor
105105
{
106-
private readonly IDictionary<Expression, Expression> _replaceMap =
107-
replaceMap ?? throw new ArgumentNullException(nameof(replaceMap));
108-
106+
[SuppressMessage("Correctness", "SS004:Implement Equals() and GetHashcode() methods for a type used in a collection.")]
109107
public static Expression Replace(Expression expr, Expression toReplace, Expression toExpr) =>
110108
new FilterByItemsExpressionReplacer(new Dictionary<Expression, Expression> {{toReplace, toExpr}})
111109
.Visit(expr);
112110

113111
[return: NotNullIfNotNull(nameof(node))]
114112
public override Expression? Visit(Expression? node) =>
115-
node != null && _replaceMap.TryGetValue(node, out var replacement)
113+
node != null && replaceMap.TryGetValue(node, out var replacement)
116114
? replacement
117115
: base.Visit(node);
118116
}

c#/crawler/tbm.Crawler.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@
1717
<PackageReference Include="System.IO.Hashing" Version="9.0.4" />
1818
</ItemGroup>
1919
<ItemGroup>
20-
<None Update="appsettings.Development.json" CopyToOutputDirectory="PreserveNewest" CopyToPublishDirectory="None" />
21-
<None Update="appsettings.Production.json" CopyToOutputDirectory="PreserveNewest" CopyToPublishDirectory="None" />
20+
<None Update="appsettings.Development.json" CopyToOutputDirectory="PreserveNewest" CopyToPublishDirectory="Never" />
21+
<None Update="appsettings.Production.json" CopyToOutputDirectory="PreserveNewest" CopyToPublishDirectory="Never" />
2222
<None Update="appsettings.json" CopyToOutputDirectory="PreserveNewest" />
2323
<None Update="nlog.config" CopyToOutputDirectory="PreserveNewest" />
2424
</ItemGroup>

c#/imagePipeline/tbm.ImagePipeline.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
<PackageReference Include="ThumbHash" Version="2.1.1" />
2121
</ItemGroup>
2222
<ItemGroup>
23-
<None Update="appsettings.Development.json" CopyToOutputDirectory="PreserveNewest" CopyToPublishDirectory="None" />
24-
<None Update="appsettings.Production.json" CopyToOutputDirectory="PreserveNewest" CopyToPublishDirectory="None" />
23+
<None Update="appsettings.Development.json" CopyToOutputDirectory="PreserveNewest" CopyToPublishDirectory="Never" />
24+
<None Update="appsettings.Production.json" CopyToOutputDirectory="PreserveNewest" CopyToPublishDirectory="Never" />
2525
<None Update="appsettings.json" CopyToOutputDirectory="PreserveNewest" />
2626
<None Update="nlog.config" CopyToOutputDirectory="PreserveNewest" />
2727
</ItemGroup>

0 commit comments

Comments
 (0)