Skip to content

Commit f22754d

Browse files
committed
* fix $hasMorePages will always be null, partial revert fd7df92 @ App\PostsQuery\QueryResult::getQueryResult()
* fix `User Deprecated: Your output walker class App\Doctrine\InterpolateParametersSQLOutputWalker should implement Doctrine\ORM\Query\OutputWalker in order to provide a Doctrine\ORM\Query\Exec\SqlFinalizer. This also means the output walker should not use the query firstResult/maxResult values, which should be read from the query by the SqlFinalizer only.`: doctrine/orm#11188 @ `App\Doctrine\InterpolateParametersSQLOutputWalker` @ be
1 parent e3a9c88 commit f22754d

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

be/src/Doctrine/InterpolateParametersSQLOutputWalker.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@
88
use Doctrine\DBAL\Types\Exception\ValueNotConvertible;
99
use Doctrine\DBAL\Types\Type;
1010
use Doctrine\ORM\Query\AST;
11-
use Doctrine\ORM\Query\SqlWalker;
11+
use Doctrine\ORM\Query\SqlOutputWalker;
1212

1313
/** @see https://stackoverflow.com/questions/2095394/doctrine-how-to-print-out-the-real-sql-not-just-the-prepared-statement/79647754#79647754 */
14-
class InterpolateParametersSQLOutputWalker extends SqlWalker
14+
class InterpolateParametersSQLOutputWalker extends SqlOutputWalker
1515
{
1616
/** {@inheritdoc} */
1717
public function walkInputParameter(AST\InputParameter $inputParam): string

be/src/PostsQuery/QueryResult.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,9 @@ public function __construct(
4646
) {}
4747

4848
/** @return array{result: Collection, hasMorePages: bool, queryPlan: array} */
49-
public function getQueryResult(AbstractQuery $query, int $maxResults): array
49+
public function getQueryResult(AbstractQuery $query, int $limit): array
5050
{
51+
$maxResults = $limit + 1;
5152
$explainJSON = \Safe\json_decode($query->getEntityManager()->getConnection()->executeQuery(
5253
'EXPLAIN (COSTS, VERBOSE, BUFFERS, FORMAT JSON) ' . $query->getSQL()
5354
)->fetchOne(), true);

0 commit comments

Comments
 (0)