Much shorter UI freeze when loading many tracks into list

Author: n00mkrad

ff-utils-winforms/Forms/MainForm.StreamList.cs

@@ -63,21 +63,18 @@ public void UpdateTrackListUpDownBtnsState()
                 trackListMoveDownBtn.Visible = newState;
         }
 
-        public bool ignoreNextStreamListItemCheck;
+        public bool ignoreStreamListCheck;
 
         private void streamList_ItemCheck(object sender, ItemCheckEventArgs e)
         {
-            if (ignoreNextStreamListItemCheck)
-            {
-                ignoreNextStreamListItemCheck = false;
+            if (ignoreStreamListCheck)
                 return;
-            }
 
             if (e.NewValue != e.CurrentValue)
                 this.BeginInvoke((MethodInvoker)(() => OnCheckedStreamsChange()));
         }
 
-        private void OnCheckedStreamsChange()
+        public void OnCheckedStreamsChange()
         {
             UpdateDefaultStreamsUi();
             QuickConvertUi.LoadMetadataGrid();

ff-utils-winforms/UI/TrackList.cs

@@ -98,25 +98,30 @@ public static async Task AddStreamsToList(MediaFile mediaFile, Color color, bool
 
             Random r = new Random();
 
+            Program.mainForm.ignoreStreamListCheck = true;
+            list.BeginUpdate();
+
             foreach (Stream s in mediaFile.AllStreams)
             {
                 try
                 {
                     MediaStreamListEntry entry = new MediaStreamListEntry(mediaFile, s);
-                    list.Items.Add(new ListViewItem { Text = entry.ToString(), Tag = entry, BackColor = color });
                     bool check = s.Codec.ToLower().Trim() != "unknown" && !(s.Type == Stream.StreamType.Video && alreadyHasVidStream);
-                    Program.mainForm.ignoreNextStreamListItemCheck = true;
-                    list.Items.Cast<ListViewItem>().Last().Checked = check;
+                    list.Items.Add(new ListViewItem { Text = entry.ToString(), Tag = entry, BackColor = color, Checked = check });
                 }
                 catch (Exception e)
                 {
                     Logger.Log($"Error trying to load streams into UI: {e.Message}\n{e.StackTrace}");
                 }
             }
 
+            list.EndUpdate();
+
             if (switchToList && !RunTask.RunInstantly())
                 Program.mainForm.MainTabList.SelectedIndex = 1;
 
+            Program.mainForm.OnCheckedStreamsChange();
+            Program.mainForm.ignoreStreamListCheck = false;
             Program.mainForm.UpdateDefaultStreamsUi();
             Program.mainForm.UpdateTrackListUpDownBtnsState();
         }
@@ -244,7 +249,7 @@ public static void CheckAll(bool check)
         {
             for (int i = 0; i < Program.mainForm.streamList.Items.Count; i++)
             {
-                Program.mainForm.ignoreNextStreamListItemCheck = i < (Program.mainForm.streamList.Items.Count - 1);
+                Program.mainForm.ignoreStreamListCheck = i < (Program.mainForm.streamList.Items.Count - 1);
                 Program.mainForm.streamList.Items[i].Checked = check;
             }
         }
@@ -253,7 +258,7 @@ public static void InvertSelection(object sender = null, EventArgs e = null)
         {
             for (int i = 0; i < Program.mainForm.streamList.Items.Count; i++)
             {
-                Program.mainForm.ignoreNextStreamListItemCheck = i < (Program.mainForm.streamList.Items.Count - 1);
+                Program.mainForm.ignoreStreamListCheck = i < (Program.mainForm.streamList.Items.Count - 1);
                 Program.mainForm.streamList.Items[i].Checked = !Program.mainForm.streamList.Items[i].Checked;
             }
         }
@@ -262,7 +267,7 @@ public static void CheckTracksOfType(Stream.StreamType type)
         {
             for (int i = 0; i < Program.mainForm.streamList.Items.Count; i++)
             {
-                Program.mainForm.ignoreNextStreamListItemCheck = i < (Program.mainForm.streamList.Items.Count - 1);
+                Program.mainForm.ignoreStreamListCheck = i < (Program.mainForm.streamList.Items.Count - 1);
                 Program.mainForm.streamList.Items[i].Checked = ((MediaStreamListEntry)Program.mainForm.streamList.Items[i].Tag).Stream.Type == type;
             }
         }