Show message box for all ffmpeg errors

Author: n00mkrad

ff-utils-winforms/Main/RunTask.cs

@@ -42,10 +42,10 @@ public static void Cancel(string reason = "", bool noMsgBox = false)
             Logger.LogIfLastLineDoesNotContainMsg("Canceled.");
 
             if (!string.IsNullOrWhiteSpace(reason) && !noMsgBox)
-                MessageBox.Show($"Canceled:\n\n{reason}", "Message");
+                System.Windows.Forms.MessageBox.Show($"Canceled:\n\n{reason}", "Message", MessageBoxButtons.OK, MessageBoxIcon.Warning, MessageBoxDefaultButton.Button1, System.Windows.Forms.MessageBoxOptions.ServiceNotification);
         }
 
-        public static async Task Start (TaskType batchTask = TaskType.Null)
+        public static async Task Start(TaskType batchTask = TaskType.Null)
         {
             if (batchTask == TaskType.Null)
                 runningBatch = false;
@@ -69,7 +69,7 @@ public static async Task Start (TaskType batchTask = TaskType.Null)
 
             if (taskType == TaskType.None)
             {
-                if(!RunInstantly())
+                if (!RunInstantly())
                     MessageBox.Show("No task selected! Please select an option (Quick Encode or one of the actions in Utilities).", "Error");
 
                 return;
@@ -93,7 +93,7 @@ public static async Task Start (TaskType batchTask = TaskType.Null)
             Program.mainForm.SetWorking(false);
         }
 
-        public static async Task StartBatch ()
+        public static async Task StartBatch()
         {
             TaskType batchTask = Program.mainForm.GetCurrentTaskType();
 
@@ -125,7 +125,7 @@ public static async Task StartBatch ()
             Logger.Log($"Queue: Completed {taskItems.Length} tasks.");
         }
 
-        public static bool RunInstantly ()
+        public static bool RunInstantly()
         {
             return Config.GetInt("taskMode") == 1;
         }

ff-utils-winforms/Media/AvProcess.cs

@@ -83,8 +83,9 @@ public static async Task<string> RunFfmpeg(string args, string workingDir, LogMo
 
             if (!show)
             {
-                ffmpeg.OutputDataReceived += (sender, outLine) => { FfmpegOutputHandler.LogOutput(outLine.Data, ref processOutput, "ffmpeg", logMode, progressBar); timeSinceLastOutput.sw.Restart(); };
-                ffmpeg.ErrorDataReceived += (sender, outLine) => { FfmpegOutputHandler.LogOutput(outLine.Data, ref processOutput, "ffmpeg", logMode, progressBar); timeSinceLastOutput.sw.Restart(); };
+                string[] ignore = GetIgnoreStringsFromFfmpegCmd(args);
+                ffmpeg.OutputDataReceived += (sender, outLine) => { FfmpegOutputHandler.LogOutput(outLine.Data, ignore, ref processOutput, "ffmpeg", logMode, progressBar); timeSinceLastOutput.sw.Restart(); };
+                ffmpeg.ErrorDataReceived += (sender, outLine) => { FfmpegOutputHandler.LogOutput(outLine.Data, ignore, ref processOutput, "ffmpeg", logMode, progressBar); timeSinceLastOutput.sw.Restart(); };
             }
 
             ffmpeg.Start();
@@ -105,6 +106,15 @@ public static async Task<string> RunFfmpeg(string args, string workingDir, LogMo
             return processOutput;
         }
 
+        private static string[] GetIgnoreStringsFromFfmpegCmd (string cmd)
+        {
+            string inputPath = cmd.Split(" -i ")[1].Split("\"")[1].Trim();
+            string[] splitByQuotes = cmd.Split("\"");
+            string outPath = splitByQuotes[splitByQuotes.Length - 2];
+            Logger.Log($"Filtering out input path ({inputPath}) and output path ({outPath})");
+            return new string[] { inputPath, outPath };
+        }
+
         public static async Task<string> GetFfmpegOutputAsync(string args, bool setBusy = false, bool progressBar = false)
         {
             if (setBusy) Program.mainForm.SetWorking(true);
@@ -131,8 +141,9 @@ public static async Task<string> RunFfprobe(string args, LogMode logMode = LogMo
 
             if (!show)
             {
-                ffprobe.OutputDataReceived += (sender, outLine) => { FfmpegOutputHandler.LogOutput(outLine.Data, ref processOutput, "ffmpeg", logMode, false); timeSinceLastOutput.sw.Restart(); };
-                ffprobe.ErrorDataReceived += (sender, outLine) => { FfmpegOutputHandler.LogOutput(outLine.Data, ref processOutput, "ffmpeg", logMode, false); timeSinceLastOutput.sw.Restart(); };
+                string[] ignore = new string[0];
+                ffprobe.OutputDataReceived += (sender, outLine) => { FfmpegOutputHandler.LogOutput(outLine.Data, ignore, ref processOutput, "ffmpeg", logMode, false); timeSinceLastOutput.sw.Restart(); };
+                ffprobe.ErrorDataReceived += (sender, outLine) => { FfmpegOutputHandler.LogOutput(outLine.Data, ignore, ref processOutput, "ffmpeg", logMode, false); timeSinceLastOutput.sw.Restart(); };
             }
 
             ffprobe.Start();

ff-utils-winforms/Media/FfmpegOutputHandler.cs

@@ -4,6 +4,7 @@
 using Nmkoder.UI;
 using Nmkoder.Utils;
 using System;
+using System.Collections.Generic;
 using System.Linq;
 using System.Text.RegularExpressions;
 using System.Threading.Tasks;
@@ -16,7 +17,7 @@ class FfmpegOutputHandler
         public static readonly string prefix = "[ffmpeg]";
         public static long overrideTargetDurationMs = -1;
 
-        public static void LogOutput(string line, ref string appendStr, string logFilename, LogMode logMode, bool showProgressBar)
+        public static void LogOutput(string line, string[] ignoreStrings, ref string appendStr, string logFilename, LogMode logMode, bool showProgressBar)
         {
             if (RunTask.canceled || string.IsNullOrWhiteSpace(line) || line.Trim().Length < 1)
                 return;
@@ -40,62 +41,65 @@ public static void LogOutput(string line, ref string appendStr, string logFilena
                 UpdateFfmpegProgress(timeRegex.Match(line).Value);
             }
 
+            string lineWithoutPath = RemoveStringsFromLine(line, ignoreStrings);
 
-            if (line.Contains("Unable to"))
+            if (lineWithoutPath.Contains("Error ") || lineWithoutPath.Contains("Unable to ") || lineWithoutPath.Contains("Could not open file"))
             {
                 RunTask.Cancel($"Error: {line}");
                 return;
             }
 
-            if (line.Contains("Could not open file"))
-            {
-                RunTask.Cancel($"Error: {line}");
-                return;
-            }
-
-            if (line.Contains("No NVENC capable devices found") || line.MatchesWildcard("*nvcuda.dll*"))
+            if (lineWithoutPath.Contains("No NVENC capable devices found") || lineWithoutPath.MatchesWildcard("*nvcuda.dll*"))
             {
                 RunTask.Cancel($"Error: {line}\n\nMake sure you have an NVENC-capable Nvidia GPU.");
                 return;
             }
 
-            if (line.Contains("not currently supported in container") || line.Contains("Unsupported codec id"))
+            if (lineWithoutPath.Contains("not currently supported in container") || lineWithoutPath.Contains("Unsupported codec id"))
             {
                 RunTask.Cancel($"Error: {line}\n\nIt looks like you are trying to copy a stream into a container that doesn't support this codec.");
                 return;
             }
 
-            if (line.Contains("Subtitle encoding currently only possible from text to text or bitmap to bitmap"))
+            if (lineWithoutPath.Contains("Subtitle encoding currently only possible from text to text or bitmap to bitmap"))
             {
                 RunTask.Cancel($"Error: {line}\n\nYou cannot encode image-based subtitles into text-based subtitles. Please use the Copy Subtitles option instead, with a compatible container.");
                 return;
             }
 
-            if (line.Contains("Only VP8 or VP9 or AV1 video and Vorbis or Opus audio and WebVTT subtitles are supported for WebM"))
+            if (lineWithoutPath.Contains("Only VP8 or VP9 or AV1 video and Vorbis or Opus audio and WebVTT subtitles are supported for WebM"))
             {
                 RunTask.Cancel($"Error: {line}\n\nIt looks like you are trying to copy an unsupported stream into WEBM!");
                 return;
             }
 
-            if (line.MatchesWildcard("*codec*not supported*"))
+            if (lineWithoutPath.MatchesWildcard("*codec*not supported*"))
             {
                 RunTask.Cancel($"Error: {line}\n\nTry using a different codec.");
                 return;
             }
 
-            if (line.Contains("GIF muxer supports only a single video GIF stream"))
+            if (lineWithoutPath.Contains("GIF muxer supports only a single video GIF stream"))
             {
                 RunTask.Cancel($"Error: {line}\n\nYou tried to mux a non-GIF stream into a GIF file.");
                 return;
             }
 
-            if (line.Contains("Width and height of input videos must be same"))
+            if (lineWithoutPath.Contains("Width and height of input videos must be same"))
             {
                 RunTask.Cancel($"Error: {line}");
                 return;
             }
         }
 
+        private static string RemoveStringsFromLine (string s, string[] ignoreStrings)
+        {
+            foreach(string ign in ignoreStrings)
+                s = s.Replace(ign, "");
+
+            return s;
+        }
+
         static void UpdateFfmpegProgress(string ffmpegTime)
         {
             try