fix unit test. accept tags as object for e2e tests

Author: guillaumejacquart

packages/@n8n/api-types/src/dto/workflows/base-workflow.dto.ts

@@ -79,7 +79,17 @@ export const baseWorkflowShape = {
 	parentFolderId: z.string().optional(),
 
 	// Tags
-	tags: z.array(z.string()).optional(),
+	tags: z
+		// Accept either array of tag IDs (strings) or array of tag objects ({ id, name }) for backwards compatibility
+		.union([z.array(z.string()), z.array(z.object({ id: z.string(), name: z.string() }))])
+		.transform((val): string[] => {
+			// If array of objects, extract just the ids
+			if (val.length > 0 && typeof val[0] === 'object' && 'id' in val[0]) {
+				return (val as Array<{ id: string; name: string }>).map((tag) => tag.id);
+			}
+			return val as string[];
+		})
+		.optional(),
 
 	// UI context and builder metadata
 	uiContext: z.string().optional(),

packages/@n8n/api-types/src/dto/workflows/create-workflow.dto.ts

@@ -21,7 +21,7 @@ export class CreateWorkflowDto extends Z.class({
 	// always overridden in the controller to enforce security policies:
 	// - active is always set to false (workflows must be activated via separate endpoint)
 	// - activeVersionId is always set to null (managed by the system)
-	active: z.boolean().optional().default(false),
+	active: z.boolean().optional(),
 	activeVersionId: z.string().nullable().optional(),
 	activeVersion: z.unknown().optional(),
 

packages/cli/src/workflows/__tests__/workflows.controller.test.ts

@@ -1,22 +1,26 @@
-import type { ImportWorkflowFromUrlDto } from '@n8n/api-types';
+import type { CreateWorkflowDto, ImportWorkflowFromUrlDto } from '@n8n/api-types';
 import type { Logger } from '@n8n/backend-common';
-import type { AuthenticatedRequest, IExecutionResponse, CredentialsEntity, User } from '@n8n/db';
 import { WorkflowEntity } from '@n8n/db';
-import type { WorkflowRepository } from '@n8n/db';
+import type {
+	AuthenticatedRequest,
+	IExecutionResponse,
+	CredentialsEntity,
+	User,
+	WorkflowRepository,
+} from '@n8n/db';
 import axios from 'axios';
 import type { Response } from 'express';
 import { mock } from 'jest-mock-extended';
 
+import { WorkflowsController } from '../workflows.controller';
+
+import type { CredentialsService } from '@/credentials/credentials.service';
 import { BadRequestError } from '@/errors/response-errors/bad-request.error';
 import { ForbiddenError } from '@/errors/response-errors/forbidden.error';
 import type { ExecutionService } from '@/executions/execution.service';
-import type { CredentialsService } from '@/credentials/credentials.service';
-import type { EnterpriseWorkflowService } from '@/workflows/workflow.service.ee';
 import type { License } from '@/license';
-import type { WorkflowRequest } from '../workflow.request';
 import type { ProjectService } from '@/services/project.service.ee';
-
-import { WorkflowsController } from '../workflows.controller';
+import type { EnterpriseWorkflowService } from '@/workflows/workflow.service.ee';
 
 jest.mock('axios');
 
@@ -190,13 +194,13 @@ describe('WorkflowsController', () => {
 				 * Arrange
 				 */
 				const mockUser = mock<User>({ id: 'user-123' });
-				const mockRequest = mock<WorkflowRequest.Create>({
+				const mockBody: CreateWorkflowDto = {
+					name: 'Test Workflow',
+					nodes: [],
+					connections: {},
+				};
+				const mockRequest = mock<AuthenticatedRequest>({
 					user: mockUser,
-					body: {
-						name: 'Test Workflow',
-						nodes: [],
-						connections: {},
-					},
 				});
 
 				const mockGlobalCredential = mock<CredentialsEntity>({
@@ -243,7 +247,9 @@ describe('WorkflowsController', () => {
 				/**
 				 * Act & Assert
 				 */
-				await expect(controller.create(mockRequest)).rejects.toThrow(BadRequestError);
+				await expect(
+					controller.create(mockRequest, res, mockBody),
+				).rejects.toThrow(BadRequestError);
 
 				/**
 				 * Assert - Verify credentials were fetched with includeGlobal: true
@@ -262,13 +268,13 @@ describe('WorkflowsController', () => {
 				 * Arrange
 				 */
 				const mockUser = mock<User>({ id: 'user-123' });
-				const mockRequest = mock<WorkflowRequest.Create>({
+				const mockBody: CreateWorkflowDto = {
+					name: 'Test Workflow',
+					nodes: [],
+					connections: {},
+				};
+				const mockRequest = mock<AuthenticatedRequest>({
 					user: mockUser,
-					body: {
-						name: 'Test Workflow',
-						nodes: [],
-						connections: {},
-					},
 				});
 
 				const mockGlobalCredential = mock<CredentialsEntity>({
@@ -303,8 +309,12 @@ describe('WorkflowsController', () => {
 				/**
 				 * Act & Assert
 				 */
-				await expect(controller.create(mockRequest)).rejects.toThrow(BadRequestError);
-				await expect(controller.create(mockRequest)).rejects.toThrow(
+				await expect(
+					controller.create(mockRequest, res, mockBody),
+				).rejects.toThrow(BadRequestError);
+				await expect(
+					controller.create(mockRequest, res, mockBody),
+				).rejects.toThrow(
 					'The workflow you are trying to save contains credentials that are not shared with you',
 				);