Merge pull request #2030 from edgarsn/helpers_type_hinting

dcblogdev · web-flow · commit ba4d44d2f81d · 2025-03-07T13:04:57.000Z
Added missing type hinting for helpers.php
diff --git a/src/helpers.php b/src/helpers.php
@@ -4,7 +4,7 @@
 use Illuminate\Support\Facades\Vite as ViteFacade;
 
 if (! function_exists('module_path')) {
-    function module_path($name, $path = '')
+    function module_path(string $name, string $path = ''): string
     {
         $module = app('modules')->find($name);
 
@@ -36,7 +36,7 @@ function public_path(string $path = ''): string
     /**
      * support for vite
      */
-    function module_vite($module, $asset, $hotFilePath = null): Vite
+    function module_vite(string $module, string $asset, ?string $hotFilePath = null): Vite
     {
         return ViteFacade::useHotFile($hotFilePath ?: storage_path('vite.hot'))->useBuildDirectory($module)->withEntryPoints([$asset]);
     }

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`use Illuminate\Support\Facades\Vite as ViteFacade;`
`5`	`5`
`6`	`6`	`if (! function_exists('module_path')) {`
`7`		`- function module_path($name, $path = '')`
	`7`	`+ function module_path(string $name, string $path = ''): string`
`8`	`8`	`{`
`9`	`9`	`$module = app('modules')->find($name);`
`10`	`10`
`@@ -36,7 +36,7 @@ function public_path(string $path = ''): string`
`36`	`36`	`/**`
`37`	`37`	`* support for vite`
`38`	`38`	`*/`
`39`		`- function module_vite($module, $asset, $hotFilePath = null): Vite`
	`39`	`+ function module_vite(string $module, string $asset, ?string $hotFilePath = null): Vite`
`40`	`40`	`{`
`41`	`41`	`return ViteFacade::useHotFile($hotFilePath ?: storage_path('vite.hot'))->useBuildDirectory($module)->withEntryPoints([$asset]);`
`42`	`42`	`}`