Skip to content

Commit c4dd018

Browse files
authored
Merge pull request #2045 from solomon-ochepa/feature/pluralize-module-route-paths
Feature/pluralize module route paths
2 parents 8097896 + 56d73ad commit c4dd018

7 files changed

+13
-6
lines changed

src/Commands/stubs/routes/api.stub

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ use Illuminate\Support\Facades\Route;
44
use $MODULE_NAMESPACE$\$STUDLY_NAME$\$CONTROLLER_NAMESPACE$\$STUDLY_NAME$Controller;
55

66
Route::middleware(['auth:sanctum'])->prefix('v1')->group(function () {
7-
Route::apiResource('$LOWER_NAME$', $STUDLY_NAME$Controller::class)->names('$LOWER_NAME$');
7+
Route::apiResource('$PLURAL_LOWER_NAME$', $STUDLY_NAME$Controller::class)->names('$LOWER_NAME$');
88
});

src/Commands/stubs/routes/web.stub

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ use Illuminate\Support\Facades\Route;
44
use $MODULE_NAMESPACE$\$STUDLY_NAME$\$CONTROLLER_NAMESPACE$\$STUDLY_NAME$Controller;
55

66
Route::middleware(['auth', 'verified'])->group(function () {
7-
Route::resource('$LOWER_NAME$', $STUDLY_NAME$Controller::class)->names('$LOWER_NAME$');
7+
Route::resource('$PLURAL_LOWER_NAME$', $STUDLY_NAME$Controller::class)->names('$LOWER_NAME$');
88
});

src/Generators/ModuleGenerator.php

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -468,9 +468,16 @@ protected function getReplacement($stub): array
468468
{
469469
$replacements = $this->module->config('stubs.replacements');
470470

471+
// Temporarily check if the replacements are defined; remove in the next major version.
471472
if (! isset($replacements['composer']['APP_FOLDER_NAME'])) {
472473
$replacements['composer'][] = 'APP_FOLDER_NAME';
473474
}
475+
if (! isset($replacements['routes/web']['PLURAL_LOWER_NAME'])) {
476+
$replacements['routes/web'][] = 'PLURAL_LOWER_NAME';
477+
}
478+
if (! isset($replacements['routes/api']['PLURAL_LOWER_NAME'])) {
479+
$replacements['routes/api'][] = 'PLURAL_LOWER_NAME';
480+
}
474481

475482
if (! isset($replacements[$stub])) {
476483
return [];

tests/Commands/Make/__snapshots__/ModuleMakeCommandTest__test_it_generates_api_route_file__1.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ use Illuminate\Support\Facades\Route;
44
use Modules\Blog\Http\Controllers\BlogController;
55

66
Route::middleware(['auth:sanctum'])->prefix('v1')->group(function () {
7-
Route::apiResource('blog', BlogController::class)->names('blog');
7+
Route::apiResource('blogs', BlogController::class)->names('blog');
88
});

tests/Commands/Make/__snapshots__/ModuleMakeCommandTest__test_it_generates_api_route_file_with_multi_segment_default_namespace__1.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ use Illuminate\Support\Facades\Route;
44
use Custom\Modules\Blog\Http\Controllers\BlogController;
55

66
Route::middleware(['auth:sanctum'])->prefix('v1')->group(function () {
7-
Route::apiResource('blog', BlogController::class)->names('blog');
7+
Route::apiResource('blogs', BlogController::class)->names('blog');
88
});

tests/Commands/Make/__snapshots__/ModuleMakeCommandTest__test_it_generates_web_route_file__1.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ use Illuminate\Support\Facades\Route;
44
use Modules\Blog\Http\Controllers\BlogController;
55

66
Route::middleware(['auth', 'verified'])->group(function () {
7-
Route::resource('blog', BlogController::class)->names('blog');
7+
Route::resource('blogs', BlogController::class)->names('blog');
88
});

tests/Commands/Make/__snapshots__/ModuleMakeCommandTest__test_it_generates_web_route_file_with_multi_segment_default_namespace__1.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@ use Illuminate\Support\Facades\Route;
44
use Custom\Modules\Blog\Http\Controllers\BlogController;
55

66
Route::middleware(['auth', 'verified'])->group(function () {
7-
Route::resource('blog', BlogController::class)->names('blog');
7+
Route::resource('blogs', BlogController::class)->names('blog');
88
});

0 commit comments

Comments
 (0)