Skip to content

Commit 425b9a6

Browse files
nam-hleclaude
andauthored
test: remove indicative console.log from test task bodies (#545)
## Summary - Remove `console.log()` calls from fixture and config task bodies that only served to indicate a task ran — these interleave with reporter output and cause flaky CI failures - Remove the `log` option from `createNadleConfig()` helper and all its usages across workspace test files - Preserve functional logs that test actual behavior (env injection, working-dir resolution, traverse-up) ## Test plan - [ ] CI passes on all platforms (Ubuntu, macOS, Windows) - [ ] Snapshot updates may be needed — CI will show if any fail 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 parent dfb9f37 commit 425b9a6

30 files changed

+132
-286
lines changed

packages/nadle/test/README.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -158,10 +158,7 @@ Generates a `nadle.config.ts` string with task registrations and optional config
158158
```typescript
159159
createNadleConfig({
160160
configure: { cacheDir: ".custom-cache" },
161-
tasks: [
162-
{ name: "build", log: "Building..." },
163-
{ name: "test", log: "Testing...", config: { dependsOn: ["build"] } }
164-
]
161+
tasks: [{ name: "build" }, { name: "test", config: { dependsOn: ["build"] } }]
165162
});
166163
```
167164

Lines changed: 7 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,41 +1,15 @@
11
import { tasks } from "nadle";
22

3-
tasks.register("node", () => {
4-
console.log("Setup node...");
5-
});
3+
tasks.register("node");
64

7-
tasks
8-
.register("install", () => {
9-
console.log("Installing npm...");
10-
})
11-
.config({ dependsOn: ["node"] });
5+
tasks.register("install").config({ dependsOn: ["node"] });
126

13-
tasks
14-
.register("compileTs", () => {
15-
console.log("Compiling ts...");
16-
})
17-
.config({ dependsOn: ["install"] });
7+
tasks.register("compileTs").config({ dependsOn: ["install"] });
188

19-
tasks
20-
.register("compileSvg", () => {
21-
console.log("Compiling svg...");
22-
})
23-
.config({ dependsOn: ["install"] });
9+
tasks.register("compileSvg").config({ dependsOn: ["install"] });
2410

25-
tasks
26-
.register("compile", () => {
27-
console.log("Compiling...");
28-
})
29-
.config({ dependsOn: ["compileSvg", "compileTs"] });
11+
tasks.register("compile").config({ dependsOn: ["compileSvg", "compileTs"] });
3012

31-
tasks
32-
.register("test", () => {
33-
console.log("Running tests...");
34-
})
35-
.config({ dependsOn: ["install"] });
13+
tasks.register("test").config({ dependsOn: ["install"] });
3614

37-
tasks
38-
.register("build", () => {
39-
console.log("Building...");
40-
})
41-
.config({ dependsOn: ["test", "compile"] });
15+
tasks.register("build").config({ dependsOn: ["test", "compile"] });
Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
import { tasks } from "nadle";
22

3-
tasks.register("hello", () => {
4-
console.log("Hi there!");
5-
});
3+
tasks.register("hello");
64

7-
tasks.register("hello", () => {
8-
console.log("hello");
9-
});
5+
tasks.register("hello");

packages/nadle/test/__fixtures__/main/nadle.config.ts

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,26 +3,18 @@ import { tasks, type Task } from "nadle";
33
tasks
44
.register("hello", async () => {
55
await new Promise((r) => setTimeout(r, 100));
6-
console.log("Hello from nadle!");
76
})
87
.config({ group: "Greetings", description: "Say hello to nadle!" });
98

10-
tasks
11-
.register("goodbye", () => {
12-
console.log("Goodbye, tak!");
13-
})
14-
.config({ group: "Greetings", description: "Say goodbye to nadle!" });
9+
tasks.register("goodbye").config({ group: "Greetings", description: "Say goodbye to nadle!" });
1510

1611
interface CopyOptions {
1712
to: string;
1813
from: string;
1914
}
2015

2116
const CopyTask: Task<CopyOptions> = {
22-
run: ({ options }) => {
23-
const { to, from } = options;
24-
console.log(`Copying from ${from} to ${to}`);
25-
}
17+
run: () => {}
2618
};
2719
tasks.register("copy", CopyTask, { to: "dist/", from: "assets/" }).config({
2820
group: "Utils",
@@ -31,8 +23,6 @@ tasks.register("copy", CopyTask, { to: "dist/", from: "assets/" }).config({
3123

3224
tasks.register("prepare", async () => {
3325
await new Promise((r) => setTimeout(r, 2000));
34-
35-
console.log("Preparing...");
3626
});
3727

3828
tasks
Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
11
import { tasks } from "nadle";
22

3-
tasks.register("build", () => {
4-
console.log("Build backend successfully!");
5-
});
3+
tasks.register("build");
Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
import { tasks } from "nadle";
22

3-
tasks.register("check", () => {
4-
console.log("Check frontend successfully!");
5-
});
3+
tasks.register("check");
64

7-
tasks
8-
.register("build", () => {
9-
console.log("Build frontend successfully!");
10-
})
11-
.config({ dependsOn: ["check", "api:check", "shared:types:check"] });
5+
tasks.register("build").config({ dependsOn: ["check", "api:check", "shared:types:check"] });

packages/nadle/test/__fixtures__/pnpm-workspaces/nadle.config.ts

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,8 @@ configure({
88
}
99
});
1010

11-
tasks.register("check", () => {
12-
console.log("Check project successfully!");
13-
});
11+
tasks.register("check");
1412

15-
tasks
16-
.register("build", () => {
17-
console.log("Build project successfully!");
18-
})
19-
.config({ dependsOn: ["check", "shared:types:build"] });
13+
tasks.register("build").config({ dependsOn: ["check", "shared:types:build"] });
2014

21-
tasks.register("deploy", () => {
22-
console.log("Deploy project successfully!");
23-
});
15+
tasks.register("deploy");
Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
import { tasks } from "nadle";
22

3-
tasks.register("check", () => {
4-
console.log("Check API successfully!");
5-
});
3+
tasks.register("check");
64

7-
tasks
8-
.register("build", () => {
9-
console.log("Build API successfully!");
10-
})
11-
.config({ dependsOn: ["check"] });
5+
tasks.register("build").config({ dependsOn: ["check"] });
Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
import { tasks } from "nadle";
22

3-
tasks.register("check", () => {
4-
console.log("Check types successfully!");
5-
});
3+
tasks.register("check");
64

7-
tasks.register("build", () => {
8-
console.log("Build types successfully!");
9-
});
5+
tasks.register("build");

packages/nadle/test/__setup__/create-files.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,7 @@ export function createPnpmWorkspace(packages: string[] = ["./**"]) {
1414
return yaml.stringify({ packages });
1515
}
1616

17-
export function createNadleConfig(params?: {
18-
configure?: NadleFileOptions;
19-
tasks?: { log?: string; name: string; config?: TaskConfiguration }[];
20-
}): string {
17+
export function createNadleConfig(params?: { configure?: NadleFileOptions; tasks?: { name: string; config?: TaskConfiguration }[] }): string {
2118
const project = new Project({
2219
useInMemoryFileSystem: true,
2320
compilerOptions: { target: ScriptTarget.ESNext },
@@ -36,9 +33,9 @@ export function createNadleConfig(params?: {
3633
}
3734

3835
for (const task of params?.tasks ?? []) {
39-
const { log, name, config } = task;
36+
const { name, config } = task;
4037

41-
let taskRegisterStatement = log ? `tasks.register("${name}", () => {console.log("${log}");})` : `tasks.register("${name}")`;
38+
let taskRegisterStatement = `tasks.register("${name}")`;
4239

4340
if (config) {
4441
taskRegisterStatement += `\n.config(${serializeJson(config, 2)})`;

0 commit comments

Comments
 (0)