Optimize spf try parse logic

Author: tinohager

src/Nager.EmailAuthentication/FragmentParsers/DmarcRecordDataFragmentParserV1.cs

@@ -13,29 +13,29 @@ public static class DmarcRecordDataFragmentParserV1
         /// <summary>
         /// Attempts to parse a raw DMARC string into a <see cref="DmarcRecordDataFragmentV1"/> object.
         /// </summary>
-        /// <param name="dmarcRaw">The raw DMARC string to parse.</param>
+        /// <param name="dmarcString">The raw DMARC string to parse.</param>
         /// <param name="dmarcDataFragment">The parsed DMARC record, if successful.</param>
         /// <returns><see langword="true"/> if parsing is successful; otherwise <see langword="false"/>.</returns>
         public static bool TryParse(
-            string? dmarcRaw,
+            string? dmarcString,
             [NotNullWhen(true)] out DmarcRecordDataFragmentV1? dmarcDataFragment)
         {
-            return TryParse(dmarcRaw, out dmarcDataFragment, out _);
+            return TryParse(dmarcString, out dmarcDataFragment, out _);
         }
 
         /// <summary>
         /// Attempts to parse a raw DMARC string into a <see cref="DmarcRecordDataFragmentV1"/> object.
         /// </summary>
-        /// <param name="dmarcRaw">The raw DMARC string to parse.</param>
+        /// <param name="dmarcString">The raw DMARC string to parse.</param>
         /// <param name="dmarcDataFragment">The parsed DMARC record, if successful.</param>
         /// <param name="parsingResults">A list of errors in the DMARC string, if any.</param>
         /// <returns><see langword="true"/> if parsing is successful; otherwise <see langword="false"/>.</returns>
         public static bool TryParse(
-            string? dmarcRaw,
+            string? dmarcString,
             [NotNullWhen(true)] out DmarcRecordDataFragmentV1? dmarcDataFragment,
             out ParsingResult[]? parsingResults)
         {
-            if (string.IsNullOrWhiteSpace(dmarcRaw))
+            if (string.IsNullOrWhiteSpace(dmarcString))
             {
                 parsingResults = null;
                 dmarcDataFragment = null;
@@ -125,7 +125,7 @@ public static bool TryParse(
             };
 
             var parserBase = new KeyValueParserBase<DmarcRecordDataFragmentV1>(handlers);
-            return parserBase.TryParse(dmarcRaw, out dmarcDataFragment, out parsingResults);
+            return parserBase.TryParse(dmarcString, out dmarcDataFragment, out parsingResults);
         }
 
         private static ParsingResult[] ValidateVersion(ValidateRequest validateRequest)

src/Nager.EmailAuthentication/FragmentParsers/SpfRecordDataFragmentParserV1.cs

@@ -13,16 +13,22 @@ public static class SpfRecordDataFragmentParserV1
         /// <summary>
         /// Try Parse
         /// </summary>
-        /// <param name="spf"></param>
+        /// <param name="spfString"></param>
         /// <param name="spfDataFragment"></param>
         /// <returns></returns>
         public static bool TryParse(
-            string spf,
+            string? spfString,
             [NotNullWhen(true)] out SpfRecordDataFragmentV1? spfDataFragment)
         {
             var spfPrefix = "v=spf1 ";
 
-            if (!spf.StartsWith(spfPrefix, StringComparison.OrdinalIgnoreCase))
+            if (string.IsNullOrWhiteSpace(spfString))
+            {
+                spfDataFragment = null;
+                return false;
+            }
+
+            if (!spfString.StartsWith(spfPrefix, StringComparison.OrdinalIgnoreCase))
             {
                 spfDataFragment = null;
                 return false;
@@ -49,7 +55,7 @@ public static bool TryParse(
 
             var spfTermDelimiter = ' ';
             var allowedQualifiers = new char[] { '+', '?', '~', '-' };
-            var inputSpan = spf.AsSpan()[spfPrefix.Length..];
+            var inputSpan = spfString.AsSpan()[spfPrefix.Length..];
             var nextIndexOfDelimiter = 0;
             var termIndex = 0;
 

src/Nager.EmailAuthentication/Nager.EmailAuthentication.csproj

@@ -20,7 +20,7 @@
 
     <TargetFrameworks>net8.0;net9.0</TargetFrameworks>
 
-    <Version>3.0.0</Version>
+    <Version>3.0.1</Version>
   </PropertyGroup>
 
   <ItemGroup>