Skip to content

Commit fcbefca

Browse files
authored
Merge pull request #363 from dgolombek/wip/sni_fix
Fix SNI handling for JRuby
2 parents 5cfed97 + 091b711 commit fcbefca

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

lib/httpclient/jruby_ssl_socket.rb

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -555,8 +555,11 @@ def create_ssl_socket(socket, dest, config, opts)
555555
if socket
556556
ssl_socket = factory.createSocket(socket, dest.host, dest.port, true)
557557
else
558-
ssl_socket = factory.createSocket
559-
JavaSocketWrap.connect(ssl_socket, dest, opts)
558+
# Create a plain socket first to set connection timeouts on,
559+
# then wrap it in a SSL socket so that SNI gets setup on it.
560+
socket = javax.net.SocketFactory.getDefault.createSocket
561+
JavaSocketWrap.connect(socket, dest, opts)
562+
ssl_socket = factory.createSocket(socket, dest.host, dest.port, true)
560563
end
561564
ssl_socket
562565
end

0 commit comments

Comments
 (0)