Skip to content

Commit fe9c9b0

Browse files
davidvedvickdavidvedvick
authored
Merge pull request #581 from namehillsoftware/bugfix/normalize-file-properties
[Bugfix] Normalize File Properties
2 parents 7feb1e0 + e245fe5 commit fe9c9b0

File tree

104 files changed

+1359
-943
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

104 files changed

+1359
-943
lines changed

‎projectBlueWater/build.gradle‎

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
22

33
plugins {
4-
id "de.mannodermaus.android-junit5" version "1.13.1.0"
5-
id 'org.jetbrains.kotlin.plugin.serialization' version '2.2.10'
4+
id "de.mannodermaus.android-junit5" version "1.13.4.0"
5+
id 'org.jetbrains.kotlin.plugin.serialization' version '2.2.20'
66
}
77

88
apply plugin: 'com.android.application'
@@ -167,16 +167,17 @@ def getGeneratedVersionCode() {
167167
}
168168

169169
dependencies {
170-
def compose_version = '1.9.1'
170+
def compose_version = '1.9.2'
171171
def media3_version = '1.8.0'
172172
def lifecycle_version = '2.9.4'
173173
def junit5_version = '5.13.4'
174174

175175
coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:2.1.5'
176176

177+
implementation "org.jetbrains.kotlin:kotlin-reflect:2.2.20"
177178
implementation 'androidx.core:core-ktx:1.17.0'
178179
implementation 'androidx.annotation:annotation:1.9.1'
179-
implementation 'androidx.work:work-runtime:2.10.4'
180+
implementation 'androidx.work:work-runtime:2.10.5'
180181
implementation 'androidx.media:media:1.7.1'
181182
implementation 'androidx.palette:palette-ktx:1.0.0'
182183
implementation 'androidx.preference:preference-ktx:1.2.1'
@@ -192,7 +193,7 @@ dependencies {
192193
implementation 'org.slf4j:slf4j-api:2.0.17'
193194
implementation 'com.github.tony19:logback-android:3.0.0'
194195
implementation 'com.namehillsoftware:handoff:0.30.1'
195-
implementation 'io.reactivex.rxjava3:rxjava:3.1.11'
196+
implementation 'io.reactivex.rxjava3:rxjava:3.1.12'
196197
implementation 'com.namehillsoftware:lazy-j:0.11.0'
197198
implementation 'org.jsoup:jsoup:1.21.2'
198199
implementation "androidx.media3:media3-exoplayer:$media3_version"
@@ -213,7 +214,7 @@ dependencies {
213214
testCompileOnly 'junit:junit:4.13.2'
214215
testImplementation 'commons-codec:commons-codec:1.19.0'
215216
testImplementation "org.junit.jupiter:junit-jupiter-api:$junit5_version"
216-
testImplementation 'org.assertj:assertj-core:3.27.5'
217+
testImplementation 'org.assertj:assertj-core:3.27.6'
217218
testImplementation 'org.robolectric:robolectric:4.16'
218219
testImplementation 'androidx.test.ext:junit-ktx:1.3.0'
219220
testImplementation 'androidx.test:core:1.7.0'

‎projectBlueWater/src/main/java/com/lasthopesoftware/bluewater/android/ui/components/BoundedScrollConnection.kt‎

Lines changed: 21 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ import androidx.compose.ui.input.nestedscroll.NestedScrollConnection
2323
import androidx.compose.ui.input.nestedscroll.NestedScrollSource
2424
import androidx.compose.ui.unit.Velocity
2525
import com.lasthopesoftware.compilation.DebugFlag
26+
import kotlinx.coroutines.flow.drop
2627
import kotlinx.parcelize.Parcelize
27-
import kotlin.math.abs
2828

2929
interface BoundedScrollConnection : NestedScrollConnection {
3030
fun goToMax()
@@ -90,6 +90,7 @@ class AnchoredProgressScrollConnectionDispatcher(
9090
LaunchedEffect(dispatcher) {
9191
if (state is MutableAnchoredScrollConnectionState) {
9292
snapshotFlow { dispatcher.selectedProgressState }
93+
.drop(1)
9394
.collect { state.selectedProgress = it }
9495
}
9596
}
@@ -98,6 +99,7 @@ class AnchoredProgressScrollConnectionDispatcher(
9899
if (state is MutableAnchoredScrollConnectionState) {
99100
if (fullDistance != 0f) {
100101
snapshotFlow { dispatcher.totalDistanceTraveled }
102+
.drop(1)
101103
.collect {
102104
state.progress = (it / fullDistance).coerceIn(0f, 1f)
103105
}
@@ -186,6 +188,7 @@ fun rememberFullScreenScrollConnectedScalerState(min: Float, max: Float): Scaler
186188

187189
class FullScreenScrollConnectedScaler(
188190
private val state: ScalerState,
191+
start: Float = 0f,
189192
maxTravelDistance: Float = Float.MAX_VALUE,
190193
) : BoundedScrollConnection {
191194

@@ -197,21 +200,22 @@ class FullScreenScrollConnectedScaler(
197200
* https://developer.android.com/reference/kotlin/androidx/compose/ui/input/nestedscroll/package-summary#extension-functions
198201
*/
199202
@Composable
200-
fun remember(min: Float, max: Float, maxTravelDistance: Float = Float.MAX_VALUE): FullScreenScrollConnectedScaler {
203+
fun remember(min: Float, max: Float, start: Float = 0f, maxTravelDistance: Float = Float.MAX_VALUE): FullScreenScrollConnectedScaler {
201204
val scalerState = rememberFullScreenScrollConnectedScalerState(min, max)
202205

203-
return remember(scalerState, maxTravelDistance)
206+
return remember(scalerState, start, maxTravelDistance)
204207
}
205208

206209
@Composable
207-
fun remember(scalerState: ScalerState, maxTravelDistance: Float = Float.MAX_VALUE): FullScreenScrollConnectedScaler {
208-
val scaler = remember(scalerState, maxTravelDistance) {
209-
FullScreenScrollConnectedScaler(scalerState, maxTravelDistance)
210+
fun remember(scalerState: ScalerState, start: Float = 0f, maxTravelDistance: Float = Float.MAX_VALUE): FullScreenScrollConnectedScaler {
211+
val scaler = remember(scalerState, start, maxTravelDistance) {
212+
FullScreenScrollConnectedScaler(scalerState, start, maxTravelDistance)
210213
}
211214

212215
LaunchedEffect(scaler) {
213216
if (scalerState is MutableScalerState) {
214-
snapshotFlow { scaler.totalDistanceTraveled }
217+
snapshotFlow { scaler.totalDistanceTraveled.floatValue }
218+
.drop(1)
215219
.collect {
216220
scalerState.totalDistanceTraveled = it
217221
}
@@ -222,14 +226,15 @@ class FullScreenScrollConnectedScaler(
222226
}
223227
}
224228

225-
private val absoluteMax = abs(maxTravelDistance)
229+
private val negativeStart = -start
230+
private val negativeMax = -maxTravelDistance
226231
private val fullDistance = state.max - state.min
227232

228-
private var totalDistanceTraveled by mutableFloatStateOf(keepWithinMaxTravelDistance(state.totalDistanceTraveled))
233+
private val totalDistanceTraveled by lazy { mutableFloatStateOf(keepWithinMaxTravelDistance(state.totalDistanceTraveled)) }
229234

230235
val valueState by lazy {
231236
derivedStateOf {
232-
(state.max + totalDistanceTraveled).coerceIn(state.min, state.max)
237+
(state.max + totalDistanceTraveled.floatValue).coerceIn(state.min, state.max)
233238
}
234239
}
235240

@@ -239,10 +244,10 @@ class FullScreenScrollConnectedScaler(
239244
override fun onPreScroll(available: Offset, source: NestedScrollSource): Offset {
240245
// try to consume before LazyColumn to collapse toolbar if needed, hence pre-scroll
241246
val originalValue = valueState.value
242-
totalDistanceTraveled = keepWithinMaxTravelDistance(totalDistanceTraveled + available.y)
247+
totalDistanceTraveled.floatValue = totalDistanceTraveled.floatValue + available.y
243248

244249
if (DebugFlag.isDebugCompilation) {
245-
Log.d(logTag, "totalDistanceTraveled: $totalDistanceTraveled")
250+
Log.d(logTag, "totalDistanceTraveled: ${totalDistanceTraveled.floatValue}")
246251
Log.d(logTag, "valueState.value: ${valueState.value}")
247252
}
248253

@@ -252,7 +257,7 @@ class FullScreenScrollConnectedScaler(
252257
@SuppressLint("LongLogTag")
253258
override fun onPostScroll(consumed: Offset, available: Offset, source: NestedScrollSource): Offset {
254259
val originalValue = valueState.value
255-
totalDistanceTraveled = keepWithinMaxTravelDistance(totalDistanceTraveled - available.y)
260+
totalDistanceTraveled.floatValue = keepWithinMaxTravelDistance(totalDistanceTraveled.floatValue - available.y)
256261

257262
if (DebugFlag.isDebugCompilation) {
258263
Log.d(logTag, "totalDistanceTraveled: $totalDistanceTraveled")
@@ -264,16 +269,16 @@ class FullScreenScrollConnectedScaler(
264269
}
265270

266271
override fun goToMax() {
267-
totalDistanceTraveled = keepWithinMaxTravelDistance(0f)
272+
totalDistanceTraveled.floatValue = keepWithinMaxTravelDistance(0f)
268273
}
269274

270275
override fun goToMin() {
271-
totalDistanceTraveled = keepWithinMaxTravelDistance(-fullDistance)
276+
totalDistanceTraveled.floatValue = keepWithinMaxTravelDistance(-fullDistance)
272277
}
273278

274279
private fun calculateProgress(value: Float) = if (fullDistance == 0f) 1f else (state.max - value) / fullDistance
275280

276-
private fun keepWithinMaxTravelDistance(value: Float): Float = value.coerceIn(-absoluteMax, absoluteMax)
281+
private fun keepWithinMaxTravelDistance(value: Float): Float = value.coerceIn(negativeMax, negativeStart)
277282
}
278283

279284
/**

‎projectBlueWater/src/main/java/com/lasthopesoftware/bluewater/client/access/RemoteLibraryAccess.kt‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package com.lasthopesoftware.bluewater.client.access
22

33
import com.lasthopesoftware.bluewater.client.browsing.files.ServiceFile
4-
import com.lasthopesoftware.bluewater.client.browsing.files.properties.EditableFilePropertyDefinition
4+
import com.lasthopesoftware.bluewater.client.browsing.files.properties.LookupFileProperties
55
import com.lasthopesoftware.bluewater.client.browsing.items.IItem
66
import com.lasthopesoftware.bluewater.client.browsing.items.ItemId
77
import com.lasthopesoftware.bluewater.client.browsing.items.KeyedIdentifier
@@ -11,7 +11,7 @@ import com.namehillsoftware.handoff.promises.Promise
1111
import java.io.InputStream
1212

1313
interface RemoteLibraryAccess {
14-
fun promiseFileProperties(serviceFile: ServiceFile): Promise<Map<String, String>>
14+
fun promiseFileProperties(serviceFile: ServiceFile): Promise<LookupFileProperties>
1515
fun promiseFilePropertyUpdate(
1616
serviceFile: ServiceFile,
1717
property: String,
@@ -37,5 +37,4 @@ interface RemoteLibraryAccess {
3737
fun promiseShuffledFileStringList(playlistId: PlaylistId): Promise<String>
3838
fun promiseImageBytes(serviceFile: ServiceFile): Promise<ByteArray>
3939
fun promiseImageBytes(itemId: ItemId): Promise<ByteArray>
40-
fun promiseEditableFilePropertyDefinitions(): Promise<Set<EditableFilePropertyDefinition>>
4140
}

‎projectBlueWater/src/main/java/com/lasthopesoftware/bluewater/client/browsing/ScopedViewModelRegistry.kt‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ import com.lasthopesoftware.bluewater.client.browsing.files.details.FileDetailsV
77
import com.lasthopesoftware.bluewater.client.browsing.files.details.ListedFileDetailsViewModel
88
import com.lasthopesoftware.bluewater.client.browsing.files.list.FileListViewModel
99
import com.lasthopesoftware.bluewater.client.browsing.files.list.search.SearchFilesViewModel
10-
import com.lasthopesoftware.bluewater.client.browsing.files.properties.EditableFilePropertyDefinitionProvider
11-
import com.lasthopesoftware.bluewater.client.browsing.files.properties.EditableLibraryFilePropertiesProvider
1210
import com.lasthopesoftware.bluewater.client.browsing.items.AggregateItemViewModel
1311
import com.lasthopesoftware.bluewater.client.browsing.items.list.ItemListViewModel
1412
import com.lasthopesoftware.bluewater.client.settings.LibrarySettingsViewModel
@@ -73,10 +71,7 @@ class ScopedViewModelRegistry(
7371
override val fileDetailsViewModel by viewModelStoreOwner.buildViewModelLazily {
7472
FileDetailsViewModel(
7573
connectionPermissions = connectionAuthenticationChecker,
76-
filePropertiesProvider = EditableLibraryFilePropertiesProvider(
77-
freshLibraryFileProperties,
78-
EditableFilePropertyDefinitionProvider(libraryConnectionProvider),
79-
),
74+
filePropertiesProvider = freshLibraryFileProperties,
8075
updateFileProperties = filePropertiesStorage,
8176
defaultImageProvider = defaultImageProvider,
8277
imageProvider = imageBytesProvider,

‎projectBlueWater/src/main/java/com/lasthopesoftware/bluewater/client/browsing/files/details/FileDetailsActivity.kt‎

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ import com.lasthopesoftware.bluewater.ApplicationDependenciesContainer.applicati
1616
import com.lasthopesoftware.bluewater.android.intents.safelyGetParcelableExtra
1717
import com.lasthopesoftware.bluewater.android.ui.ProjectBlueComposableApplication
1818
import com.lasthopesoftware.bluewater.client.browsing.files.ServiceFile
19-
import com.lasthopesoftware.bluewater.client.browsing.files.properties.EditableFilePropertyDefinitionProvider
20-
import com.lasthopesoftware.bluewater.client.browsing.files.properties.EditableLibraryFilePropertiesProvider
2119
import com.lasthopesoftware.bluewater.client.browsing.files.properties.LibraryFilePropertiesDependentsRegistry
2220
import com.lasthopesoftware.bluewater.client.browsing.items.list.ConnectionLostView
2321
import com.lasthopesoftware.bluewater.client.browsing.library.repository.LibraryId
@@ -50,21 +48,14 @@ import java.io.IOException
5048
LibraryConnectionRegistry(localApplicationDependencies)
5149
}
5250

53-
private val filePropertiesProvider by lazy {
54-
EditableLibraryFilePropertiesProvider(
55-
libraryConnectedDependencies.freshLibraryFileProperties,
56-
EditableFilePropertyDefinitionProvider(localApplicationDependencies.libraryConnectionProvider),
57-
)
58-
}
59-
6051
private val libraryFilePropertiesDependents by lazy {
6152
LibraryFilePropertiesDependentsRegistry(localApplicationDependencies, libraryConnectedDependencies)
6253
}
6354

6455
private val vm by buildViewModelLazily {
6556
FileDetailsViewModel(
6657
libraryConnectedDependencies.connectionAuthenticationChecker,
67-
filePropertiesProvider,
58+
libraryConnectedDependencies.freshLibraryFileProperties,
6859
libraryConnectedDependencies.filePropertiesStorage,
6960
localApplicationDependencies.defaultImageProvider,
7061
libraryFilePropertiesDependents.imageBytesProvider,

‎projectBlueWater/src/main/java/com/lasthopesoftware/bluewater/client/browsing/files/details/FileDetailsView.kt‎

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ import com.lasthopesoftware.bluewater.android.ui.theme.Dimensions.topRowOuterPad
9898
import com.lasthopesoftware.bluewater.android.ui.theme.Dimensions.viewPaddingUnit
9999
import com.lasthopesoftware.bluewater.client.browsing.files.properties.FilePropertyType
100100
import com.lasthopesoftware.bluewater.client.browsing.files.properties.NormalizedFileProperties
101-
import com.lasthopesoftware.bluewater.client.browsing.files.properties.ReadOnlyFileProperty
102101
import com.lasthopesoftware.bluewater.shared.NullBox
103102
import com.lasthopesoftware.bluewater.shared.android.colors.MediaStylePalette
104103
import com.lasthopesoftware.bluewater.shared.android.colors.MediaStylePaletteProvider
@@ -274,7 +273,7 @@ fun FilePropertyRow(
274273
.indicateFocus(interactionSource),
275274
) {
276275
Text(
277-
text = property.property,
276+
text = property.propertyName,
278277
color = palette.primaryTextColor,
279278
modifier = Modifier
280279
.weight(1f)
@@ -288,7 +287,7 @@ fun FilePropertyRow(
288287

289288
val propertyValue by property.committedValue.subscribeAsState()
290289

291-
when (property.property) {
290+
when (property.propertyName) {
292291
NormalizedFileProperties.Rating -> {
293292
Box(
294293
modifier = Modifier
@@ -342,7 +341,7 @@ private fun FileDetailsEditor(
342341
) {
343342
val maybeHighlightedFileProperty by viewModel.highlightedProperty.subscribeAsState()
344343
maybeHighlightedFileProperty?.let { fileProperty ->
345-
val property = fileProperty.property
344+
val property = fileProperty.propertyName
346345

347346
Dialog(onDismissRequest = fileProperty::cancel) {
348347
ControlSurface(
@@ -388,7 +387,7 @@ private fun FileDetailsEditor(
388387
contentAlignment = Alignment.Center
389388
) {
390389
when {
391-
fileProperty.property == NormalizedFileProperties.Rating -> {
390+
fileProperty.propertyName == NormalizedFileProperties.Rating -> {
392391
val ratingValue by remember { derivedStateOf { propertyValue.toInt() } }
393392
RatingBar(
394393
rating = ratingValue,
@@ -455,7 +454,7 @@ private fun FileDetailsEditor(
455454
viewModel.activeLibraryId?.also {
456455
navigateApplication.search(
457456
it,
458-
ReadOnlyFileProperty(property, propertyValue)
457+
fileProperty.fileProperty
459458
)
460459
}
461460
},

‎projectBlueWater/src/main/java/com/lasthopesoftware/bluewater/client/browsing/files/details/FileDetailsViewModel.kt‎

Lines changed: 25 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ import androidx.lifecycle.ViewModel
44
import com.lasthopesoftware.bluewater.client.browsing.files.ServiceFile
55
import com.lasthopesoftware.bluewater.client.browsing.files.properties.EditableFileProperty
66
import com.lasthopesoftware.bluewater.client.browsing.files.properties.FileProperty
7+
import com.lasthopesoftware.bluewater.client.browsing.files.properties.FilePropertyHelpers.editableFilePropertyDefinition
78
import com.lasthopesoftware.bluewater.client.browsing.files.properties.NormalizedFileProperties
8-
import com.lasthopesoftware.bluewater.client.browsing.files.properties.ProvideEditableLibraryFileProperties
9-
import com.lasthopesoftware.bluewater.client.browsing.files.properties.editableFilePropertyDefinition
9+
import com.lasthopesoftware.bluewater.client.browsing.files.properties.ProvideFreshLibraryFileProperties
1010
import com.lasthopesoftware.bluewater.client.browsing.files.properties.getFormattedValue
1111
import com.lasthopesoftware.bluewater.client.browsing.files.properties.storage.FilePropertiesUpdatedMessage
1212
import com.lasthopesoftware.bluewater.client.browsing.files.properties.storage.UpdateFileProperties
@@ -24,15 +24,17 @@ import com.lasthopesoftware.bluewater.shared.observables.MutableInteractionState
2424
import com.lasthopesoftware.bluewater.shared.observables.mapNotNull
2525
import com.lasthopesoftware.bluewater.shared.observables.toMaybeObservable
2626
import com.lasthopesoftware.promises.extensions.keepPromise
27+
import com.lasthopesoftware.promises.extensions.preparePromise
2728
import com.lasthopesoftware.promises.extensions.unitResponse
2829
import com.lasthopesoftware.resources.emptyByteArray
30+
import com.lasthopesoftware.resources.executors.ThreadPools
2931
import com.namehillsoftware.handoff.promises.Promise
3032
import com.namehillsoftware.handoff.promises.response.ImmediateAction
3133

3234

3335
class FileDetailsViewModel(
3436
private val connectionPermissions: CheckIfConnectionIsReadOnly,
35-
private val filePropertiesProvider: ProvideEditableLibraryFileProperties,
37+
private val filePropertiesProvider: ProvideFreshLibraryFileProperties,
3638
private val updateFileProperties: UpdateFileProperties,
3739
defaultImageProvider: ProvideDefaultImage,
3840
private val imageProvider: GetImageBytes,
@@ -164,23 +166,27 @@ class FileDetailsViewModel(
164166
private fun loadFileProperties(libraryId: LibraryId, serviceFile: ServiceFile): Promise<Unit> =
165167
filePropertiesProvider
166168
.promiseFileProperties(libraryId, serviceFile)
167-
.then { fileProperties ->
168-
val filePropertiesList = fileProperties.toList()
169-
val filePropertiesMap = filePropertiesList.associateBy { it.name }
170-
171-
mutableFileName.value = filePropertiesMap[NormalizedFileProperties.Name]?.value ?: ""
172-
mutableArtist.value = filePropertiesMap[NormalizedFileProperties.Artist]?.value ?: ""
173-
mutableAlbum.value = filePropertiesMap[NormalizedFileProperties.Album]?.value ?: ""
174-
mutableRating.value = filePropertiesMap[NormalizedFileProperties.Rating]?.value?.toIntOrNull() ?: 0
175-
176-
mutableFileProperties.value = filePropertiesList
177-
.filterNot { e -> propertiesToSkip.contains(e.name) }
178-
.sortedBy { it.name }
179-
.map(::FilePropertyViewModel)
169+
.eventually { fileProperties ->
170+
ThreadPools.compute.preparePromise { cs ->
171+
if (cs.isCancelled) return@preparePromise
172+
173+
mutableFileName.value = fileProperties.name?.value ?: ""
174+
mutableArtist.value = fileProperties.artist?.value ?: ""
175+
mutableAlbum.value = fileProperties.album?.value ?: ""
176+
mutableRating.value = fileProperties.rating?.value?.toIntOrNull() ?: 0
177+
178+
if (cs.isCancelled) return@preparePromise
179+
180+
mutableFileProperties.value = fileProperties.allProperties
181+
.filterNot { e -> propertiesToSkip.contains(e.name) }
182+
.sortedBy { it.name }
183+
.map(::FilePropertyViewModel)
184+
.toList()
185+
}
180186
}
181187
.keepPromise(Unit)
182188

183-
inner class FilePropertyViewModel(fileProperty: FileProperty) {
189+
inner class FilePropertyViewModel(val fileProperty: FileProperty) {
184190

185191
private val formattedValue by lazy(LazyThreadSafetyMode.PUBLICATION) { fileProperty.getFormattedValue() }
186192
private val editableFilePropertyDefinition by lazy(LazyThreadSafetyMode.PUBLICATION) {
@@ -200,7 +206,7 @@ class FileDetailsViewModel(
200206
!isConnectionReadOnly && fileProperty is EditableFileProperty
201207
}
202208
val editableType by lazy(LazyThreadSafetyMode.PUBLICATION) { editableFilePropertyDefinition?.type }
203-
val property = fileProperty.name
209+
val propertyName = fileProperty.name
204210

205211
fun highlight() {
206212
mutableHighlightedProperty.value = this
@@ -224,7 +230,7 @@ class FileDetailsViewModel(
224230
activeServiceFile
225231
?.let { serviceFile ->
226232
updateFileProperties
227-
.promiseFileUpdate(l, serviceFile, property, newValue, true)
233+
.promiseFileUpdate(l, serviceFile, propertyName, newValue, true)
228234
.then { _ -> mutableCommittedValue.value = newValue }
229235
}
230236
}

0 commit comments

Comments
 (0)