Add support for windows shell and command wrapping

Author: hugosantos

pkg/config/config.go

@@ -5,12 +5,13 @@ import (
 	"errors"
 	"fmt"
 	"os"
+	"runtime"
 	"time"
 
 	"github.com/rs/zerolog"
 	"google.golang.org/grpc/metadata"
 	internalv1 "namespacelabs.dev/breakpoint/api/private/v1"
-	"namespacelabs.dev/breakpoint/api/public/v1"
+	v1 "namespacelabs.dev/breakpoint/api/public/v1"
 	"namespacelabs.dev/breakpoint/pkg/github"
 	"namespacelabs.dev/breakpoint/pkg/githuboidc"
 	"namespacelabs.dev/breakpoint/pkg/jsonfile"
@@ -36,7 +37,11 @@ func LoadConfig(ctx context.Context, file string) (ParsedConfig, error) {
 		if sh, ok := os.LookupEnv("SHELL"); ok {
 			cfg.Shell = []string{sh}
 		} else {
-			cfg.Shell = []string{"/bin/sh"}
+			if runtime.GOOS == "windows" {
+				cfg.Shell = []string{"C:\\Windows\\System32\\cmd.exe"}
+			} else {
+				cfg.Shell = []string{"/bin/sh"}
+			}
 		}
 	}
 

pkg/sshd/sshd.go

@@ -8,6 +8,7 @@ import (
 	"io"
 	"net"
 	"os/exec"
+	"runtime"
 	"time"
 
 	"github.com/gliderlabs/ssh"
@@ -61,7 +62,11 @@ func MakeServer(ctx context.Context, opts SSHServerOpts) (*SSHServer, error) {
 
 			args := opts.Shell[1:]
 			if session.RawCommand() != "" {
-				args = []string{"-c", session.RawCommand()}
+				if runtime.GOOS == "windows" {
+					args = []string{"/C", session.RawCommand()}
+				} else {
+					args = []string{"-c", session.RawCommand()}
+				}
 			}
 
 			cmd := exec.Command(opts.Shell[0], args...)