refactor: make fromCborMap constructors private

Author: falko17

lib/src/endpoints/creation_hint.dart

@@ -70,7 +70,7 @@ class AuthServerRequestCreationHint extends CborMapSerializable {
   /// Creates a new [AuthServerRequestCreationHint] instance from the given
   /// [serialized] CBOR.
   AuthServerRequestCreationHint.fromSerialized(List<int> serialized)
-      : this.fromCborMap(
+      : this._fromCborMap(
             CborMapSerializable.valueToCborMap(cborDecode(serialized)));
 
   /// Creates a new [AuthServerRequestCreationHint] instance.
@@ -83,7 +83,7 @@ class AuthServerRequestCreationHint extends CborMapSerializable {
 
   /// Creates a new [AuthServerRequestCreationHint] instance from the given
   /// CBOR [map].
-  AuthServerRequestCreationHint.fromCborMap(Map<int, CborValue> map) {
+  AuthServerRequestCreationHint._fromCborMap(Map<int, CborValue> map) {
     // TODO(falko17): Better error handling
     map.forEach((key, value) {
       switch (key) {

lib/src/endpoints/error_response.dart

@@ -58,7 +58,7 @@ class ErrorResponse extends CborMapSerializable {
   ErrorResponse({required this.error, this.description, this.uri});
 
   /// Creates a new [ErrorResponse] instance from the given CBOR [map].
-  ErrorResponse.fromCborMap(Map<int, CborValue> map)
+  ErrorResponse._fromCborMap(Map<int, CborValue> map)
       : error = ErrorCode.fromCborValue(map[token_const.error]!) {
     map.forEach((key, value) {
       switch (key) {
@@ -79,7 +79,7 @@ class ErrorResponse extends CborMapSerializable {
 
   /// Creates a new [ErrorResponse] instance from the given [serialized] CBOR.
   ErrorResponse.fromSerialized(List<int> serialized)
-      : this.fromCborMap(
+      : this._fromCborMap(
             CborMapSerializable.valueToCborMap(cborDecode(serialized)));
 
   @override

lib/src/endpoints/token_request.dart

@@ -100,7 +100,7 @@ class AccessTokenRequest extends CborMapSerializable {
       this.issuer});
 
   /// Creates a new [AccessTokenRequest] instance from the given CBOR [map].
-  AccessTokenRequest.fromCborMap(Map<int, CborValue> map) {
+  AccessTokenRequest._fromCborMap(Map<int, CborValue> map) {
     map.forEach((key, value) {
       switch (key) {
         case token_const.clientId:
@@ -125,8 +125,7 @@ class AccessTokenRequest extends CborMapSerializable {
           includeAceProfile = true;
           break;
         case token_const.reqCnf:
-          reqCnf = ProofOfPossessionKey.fromCborMap(
-              CborMapSerializable.valueToCborMap(value));
+          reqCnf = ProofOfPossessionKey.fromCborValue(value);
           break;
         case intro_const.issuer:
           issuer = (value as CborString).toString();
@@ -140,7 +139,7 @@ class AccessTokenRequest extends CborMapSerializable {
   /// Creates a new [AccessTokenRequest] instance from the given
   /// [serialized] CBOR.
   AccessTokenRequest.fromSerialized(List<int> serialized)
-      : this.fromCborMap(
+      : this._fromCborMap(
             CborMapSerializable.valueToCborMap(cborDecode(serialized)));
 
   @override

lib/src/endpoints/token_response.dart

@@ -137,7 +137,7 @@ class AccessTokenResponse extends CborMapSerializable {
 
   /// Creates a new [AccessTokenResponse] instance from the given
   /// CBOR [map].
-  AccessTokenResponse.fromCborMap(Map<int, CborValue> map)
+  AccessTokenResponse._fromCborMap(Map<int, CborValue> map)
       : accessToken = _initializeAccessToken(map[token_const.accessToken]) {
     map.forEach((key, value) {
       switch (key) {
@@ -180,7 +180,7 @@ class AccessTokenResponse extends CborMapSerializable {
   /// Creates a new [AccessTokenResponse] instance from the given
   /// [serialized] CBOR.
   AccessTokenResponse.fromSerialized(List<int> serialized)
-      : this.fromCborMap(
+      : this._fromCborMap(
             CborMapSerializable.valueToCborMap(cborDecode(serialized)));
 
   @override

lib/src/pop.dart

@@ -45,11 +45,11 @@ abstract class ProofOfPossessionKey extends CborMapSerializable {
 
   /// Creates a new [ProofOfPossessionKey] from the given [map],
   /// which maps from CBOR labels to [CborValue]s.
-  factory ProofOfPossessionKey.fromCborMap(Map<int, CborValue> map) {
+  factory ProofOfPossessionKey._fromCborMap(Map<int, CborValue> map) {
     final MapEntry<int, CborValue> entry = map.entries.single;
     switch (entry.key) {
       case 1:
-        return PlainCoseKey.fromCborMap(
+        return PlainCoseKey._fromCborMap(
             CborMapSerializable.valueToCborMap(entry.value));
       case 2:
         return EncryptedCoseKey.fromValue(entry.value);
@@ -68,7 +68,7 @@ abstract class ProofOfPossessionKey extends CborMapSerializable {
 
   /// Creates a new [ProofOfPossessionKey] from the given CBOR [value].
   factory ProofOfPossessionKey.fromCborValue(CborValue value) {
-    return ProofOfPossessionKey.fromCborMap(
+    return ProofOfPossessionKey._fromCborMap(
         CborMapSerializable.valueToCborMap(value));
   }
 }
@@ -132,7 +132,7 @@ class PlainCoseKey extends ProofOfPossessionKey {
 
   /// Creates a new [PlainCoseKey] instance from the given [map] from
   /// CBOR labels to [CborValue]s.
-  PlainCoseKey.fromCborMap(Map<int, CborValue> map)
+  PlainCoseKey._fromCborMap(Map<int, CborValue> map)
       : this(CoseKey.fromMap(map));
 
   @override