Skip to content

Commit 0c90db0

Browse files
committed
ksmbd: fix infinite loop caused by next_smb2_rcv_hdr_off reset in error paths
The problem occurs when a signed request fails smb2 signature verification check. In __process_request(), if check_sign_req() returns an error, set_smb2_rsp_status(work, STATUS_ACCESS_DENIED) is called. set_smb2_rsp_status() set work->next_smb2_rcv_hdr_off as zero. By resetting next_smb2_rcv_hdr_off to zero, the pointer to the next command in the chain is lost. Consequently, is_chained_smb2_message() continues to point to the same request header instead of advancing. If the header's NextCommand field is non-zero, the function returns true, causing __handle_ksmbd_work() to repeatedly process the same failed request in an infinite loop. This results in the kernel log being flooded with "bad smb2 signature" messages and high CPU usage. This patch fixes the issue by changing the return value from SERVER_HANDLER_CONTINUE to SERVER_HANDLER_ABORT. This ensures that the processing loop terminates immediately rather than attempting to continue from an invalidated offset. Reported-by: tianshuo han <hantianshuo233@gmail.com> Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
1 parent 18abb79 commit 0c90db0

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

server.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,21 +129,21 @@ static int __process_request(struct ksmbd_work *work, struct ksmbd_conn *conn,
129129
andx_again:
130130
if (command >= conn->max_cmds) {
131131
conn->ops->set_rsp_status(work, STATUS_INVALID_PARAMETER);
132-
return SERVER_HANDLER_CONTINUE;
132+
return SERVER_HANDLER_ABORT;
133133
}
134134

135135
cmds = &conn->cmds[command];
136136
if (!cmds->proc) {
137137
ksmbd_debug(SMB, "*** not implemented yet cmd = %x\n", command);
138138
conn->ops->set_rsp_status(work, STATUS_NOT_IMPLEMENTED);
139-
return SERVER_HANDLER_CONTINUE;
139+
return SERVER_HANDLER_ABORT;
140140
}
141141

142142
if (work->sess && conn->ops->is_sign_req(work, command)) {
143143
ret = conn->ops->check_sign_req(work);
144144
if (!ret) {
145145
conn->ops->set_rsp_status(work, STATUS_ACCESS_DENIED);
146-
return SERVER_HANDLER_CONTINUE;
146+
return SERVER_HANDLER_ABORT;
147147
}
148148
}
149149

0 commit comments

Comments
 (0)